From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: eric.jin@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Mon, 12 Aug 2019 08:16:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 08:16:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,377,1559545200"; d="scan'208";a="193988578" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 12 Aug 2019 08:16:52 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 08:16:52 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 08:16:51 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 23:16:49 +0800 From: "Eric Jin" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Jin, Eric" Subject: Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution Thread-Topic: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution Thread-Index: AQHVUK/GfmXT1zZvMUi+7vtQ9Vb6x6b2+XWAgAAJl7D//7TsgIAA58cw Date: Mon, 12 Aug 2019 15:16:49 +0000 Message-ID: References: <20190812014603.42484-1-eric.jin@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CE84D@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CEC0D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CEC0D@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzFkM2E2NzAtM2UwZi00MDIyLWIyODEtZTZjYzAxMGFjOWY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU29kVDFYVFwvTnhtRTFKRUc5OWhiS3FkSFwvQys5R2ZQdnB5bEVPZG5DazJiT25RUmRiem5KVmtJREo1OHlkMG9sIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming,=20 Thank you for comment. We will update GetLowestSupportedVersion() API function header to include = Private param when we push the code to repo. Thanks. Best Regards Eric -----Original Message----- From: Gao, Liming=20 Sent: Monday, August 12, 2019 5:24 PM To: Jin, Eric ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support so= lution That's good information.=20 In patch 5, GetLowestSupportedVersion() API function header should be upda= ted to include Private param. I have no other comments.=20 With this change, Reviewed-by: Liming Gao /// @@ -193,7 +200,7 @@ GetImageTypeNameString ( **/ UINT32 GetLowestSupportedVersion ( - VOID + FIRMWARE_MANAGEMENT_PRIVATE_DATA *Private ) Thanks Liming >-----Original Message----- >From: Jin, Eric >Sent: Monday, August 12, 2019 3:14 PM >To: Gao, Liming ; devel@edk2.groups.io >Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support= =20 >solution > >Liming, > >The differences between V2 and V1 are listed below. > >1) The series is composed of 10 patches in V2 (14 in V1). patch 14 is=20 >merged into patch 4, and patch 11/12/13 are merged into patch 5. >2) Try to fix the issue exposed by ECC. > >Btw, the patch of edk2-platform >Platform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\FmpDeviceLib=20 >to support new APIs is provided in separated patch >https://edk2.groups.io/g/devel/message/45328 > >Best Regards >Eric > >-----Original Message----- >From: Gao, Liming >Sent: Monday, August 12, 2019 1:19 PM >To: devel@edk2.groups.io; Jin, Eric >Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support= =20 >solution > >Eric: > Can you list the difference compared to version 1? > >Thanks >Liming >>-----Original Message----- >>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 >>Eric Jin >>Sent: Monday, August 12, 2019 9:46 AM >>To: devel@edk2.groups.io >>Subject: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support=20 >>solution >> >>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1525 >> >>The patch set is to support drivers that manage multiple controllers=20 >>and also provide a firmware update capability to each managed controller= . >> >>The following modules are related to Multiple Controllers Support=20 >>solution >> >>FmpDevicePkg\FmpDxe\FmpDxe.inf - Driver to manage multiple controllers= =20 >>and provide the firmware update capability to each managed controller. >>FmpDevicePkg\CapsuleUpdatePolicyDxe\CapsuleUpdatePolicyDxe.inf - >Driver >>to produce the Capsule Update Policy Protocol using the services of=20 >>the CapsuleUpdatePolicyLib class. The protocol is a private interface=20 >>to the FmpDevicePkg=20 >>FmpDevicePkg\Library\CapsuleUpdatePolicyLibOnProtocol\CapsuleUpdateP >o >>licyLibOnProtocol.inf - >>CapsuleUpdatePolicyLib instance that uses the services of the Capsule=20 >>Update Policy Protocol produced by CapsuleUpdatePolicyDxe=20 >>FmpDevicePkg\Library\CapsuleUpdatePolicyLibNull\CapsuleUpdatePolicyLib >N >>ull.inf - >>Null CapsuleUpdatePolicyLib instance and the template for platform=20 >>specific implementation=20 >>FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLibNull.inf - Null=20 >>FmpDeviceLib instance and the template for platform specific=20 >>implementation >> >>Eric Jin (10): >> FmpDevicePkg: Add UEFI_DRIVER support >> FmpDevicePkg: Add APIs to FmpDeviceLib >> FmpDEvicePkg/FmpDeviceLibNull: Implement new APIs >> FmpDevicePkg/FmpDxe: Use new FmpDeviceLib APIs >> FmpDevicePkg/FmpDxe: Different variable for each FMP Descriptor >> FmpDevicePkg: Add Capsule Update Policy Protocol >> FmpDevicePkg/FmpDxe: Improve all DEBUG() messages >> FmpDevicePkg/FmpDxe: Add PcdFmpDeviceImageTypeIdGuid >> FmpDevicePkg/FmpDxe: Add PcdFmpDeviceStorageAccessEnable >> FmpDevicePkg/FmpDxe: Remove use of CatSprint() >> >> .../CapsuleUpdatePolicyDxe.c | 173 ++++ >> .../CapsuleUpdatePolicyDxe.h | 140 +++ >> .../CapsuleUpdatePolicyDxe.inf | 48 + >> .../CapsuleUpdatePolicyDxe.uni | 14 + >> .../CapsuleUpdatePolicyDxeExtra.uni | 14 + >> FmpDevicePkg/FmpDevicePkg.dec | 43 +- >> FmpDevicePkg/FmpDevicePkg.dsc | 64 +- >> FmpDevicePkg/FmpDevicePkg.uni | 16 +- >> FmpDevicePkg/FmpDxe/DetectTestKey.c | 16 +- >> FmpDevicePkg/FmpDxe/FmpDxe.c | 792 ++++++++++------ >> FmpDevicePkg/FmpDxe/FmpDxe.h | 355 ++++++++ >> FmpDevicePkg/FmpDxe/FmpDxe.inf | 7 +- >> FmpDevicePkg/FmpDxe/FmpDxeLib.inf | 7 +- >> FmpDevicePkg/FmpDxe/VariableSupport.c | 844 +++++++++++++----- >> FmpDevicePkg/FmpDxe/VariableSupport.h | 135 ++- >> FmpDevicePkg/Include/Library/FmpDeviceLib.h | 104 ++- >> .../CapsuleUpdatePolicyLibOnProtocol.c | 171 ++++ >> .../CapsuleUpdatePolicyLibOnProtocol.inf | 40 + >> .../CapsuleUpdatePolicyLibOnProtocol.uni | 15 + >> .../Library/FmpDeviceLibNull/FmpDeviceLib.c | 93 +- >> .../FmpDeviceLibNull/FmpDeviceLibNull.inf | 4 +- >> .../FmpPayloadHeaderLibV1.inf | 4 +- >> .../Library/FmpPayloadHeaderLib.h | 0 >> .../Protocol/CapsuleUpdatePolicy.h | 132 +++ >> 24 files changed, 2644 insertions(+), 587 deletions(-) create mode >>100644 FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c >> create mode 100644 >>FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.h >> create mode 100644 >>FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf >> create mode 100644 >>FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.uni >> create mode 100644 >>FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxeExtra.uni >> create mode 100644 FmpDevicePkg/FmpDxe/FmpDxe.h create mode >100644 >>FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >o >>licyLibOnProtocol.c >> create mode 100644 >>FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >o >>licyLibOnProtocol.inf >> create mode 100644 >>FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >o >>licyLibOnProtocol.uni >> rename FmpDevicePkg/{Include =3D> >>PrivateInclude}/Library/FmpPayloadHeaderLib.h (100%) create mode >>100644 FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h >> >>-- >>2.20.1.windows.1 >> >> >>