Re: [edk2-devel] [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag

["Eric Jin" <eric.jin@intel.com>]

Hi Leif,

Thank for the valuable suggestion.
In the patch series V2, Sean has been set as author on patch 1/2. Thank you.

Best Regards
Eric

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm
Sent: Wednesday, August 14, 2019 2:47 AM
To: Gao, Liming <liming.gao@intel.com>
Cc: Jin, Eric <eric.jin@intel.com>; rfc@edk2.groups.io; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Cetola, Stephano <stephano.cetola@intel.com>; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag

Hi Liming,

This is the other one. As I said, the fact that we are slipping multiple scripts in *just* before freeze is a concern for me.

I have no objection to the code here though.

I would however request that Sean is set as author on patch 1/2 as he was the original author of the script. (This was easy for me to find out because the commit message was exemplary.)

Best Regards,

Leif

On Tue, Aug 13, 2019 at 01:49:24PM +0000, Gao, Liming wrote:
> I see this patch was sent a week ago. This is a standalone tool. There is no impact on normal build and boot. I am OK to add it for 201908 stable tag.
> 
> Thanks
> Liming
> From: Jin, Eric
> Sent: Monday, August 12, 2019 3:09 PM
> To: rfc@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Jin, Eric 
> <eric.jin@intel.com>; devel@edk2.groups.io; Feng, Bob C 
> <bob.c.feng@intel.com>
> Subject: [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in 
> Edk2/BaseTools for 201908 stable tag
> 
> Hi All,
> 
> It is the request to Enable Windows Firmware Update Driver Tool in Edk2/BaseTools  and catch the Q3 tag.
> The new tool will leverage the edk2-pytool-library to generate the cat/inf file based on the cap file. The output driver package can be trigged in Windows OS to complete capsule update.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1837
> 
> Patch link: https://edk2.groups.io/g/devel/topic/32780378#44992
> 
> Best Regards
> Eric
> 
>