From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: eric.jin@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Mon, 02 Sep 2019 22:46:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 22:46:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,461,1559545200"; d="scan'208";a="211876857" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 02 Sep 2019 22:46:03 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Sep 2019 22:46:03 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Sep 2019 22:46:03 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.89]) with mapi id 14.03.0439.000; Tue, 3 Sep 2019 13:46:01 +0800 From: "Eric Jin" To: Heinrich Schuchardt , "devel@edk2.groups.io" CC: Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: assertion for UninstallMultipleProtocols Thread-Topic: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: assertion for UninstallMultipleProtocols Thread-Index: AQHVYWqhmHtxLUQDR0671q7ILHkW3KcZckfg Date: Tue, 3 Sep 2019 05:46:01 +0000 Message-ID: References: <20190902084412.3731-1-xypron.glpk@gmx.de> In-Reply-To: <20190902084412.3731-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Jin -----Original Message----- From: Heinrich Schuchardt =20 Sent: Monday, September 2, 2019 4:44 PM To: devel@edk2.groups.io Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuc= hardt Subject: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: assertion for UninstallMu= ltipleProtocols REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1869 BS.UninstallMultipleProtocolInterfaces - InterfaceTestCheckpoint6 expects UninstallMultipleProtocols() to return EFI_ACCESS_DENIED but the UEFI spec has: "If any errors are generated while the protocol interfaces are being uninst= alled, then the protocols uninstalled prior to the error will be reinstalle= d with the boot service EFI_BOOT_SERVICES.InstallProtocolInterface() and the status code EFI_INVALI= D_PARAMETER is returned." So the SCT should check for EFI_INVALID_PARAMETER and not for EFI_ACCESS_DE= NIED. Correct the assertion. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/ProtocolHandlerBBTestFunction_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandler= Services/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c b/uefi-sct/SctPkg/T= estCase/UEFI/EFI/BootServices/ProtocolHandlerServices/BlackBoxTest/Protocol= HandlerBBTestFunction_2.c index c143e558..fe6146b2 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandlerService= s/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandlerServ +++ ices/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c @@ -12778,7 +12778,7 @@ BBTestUninstallMultipleProtocolInterfacesInterfaceT= estCheckPoint6 ( // // Step 1: check return status //- if (EFI_ACCESS_DENIED= =3D=3D Status) {+ if (EFI_INVALID_PARAMETER =3D=3D Status) { Asse= rtionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType = =3D EFI_TEST_ASSERTION_FAILED;--=20 2.20.1