From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: eric.jin@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Tue, 03 Sep 2019 00:43:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 00:42:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,462,1559545200"; d="scan'208";a="382990245" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 03 Sep 2019 00:42:59 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 00:42:58 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Tue, 3 Sep 2019 15:42:57 +0800 From: "Eric Jin" To: Heinrich Schuchardt , "devel@edk2.groups.io" CC: Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-test] [PATCH] uefi-sct/SctPkg: StrUpr() test for cyrillic letters Thread-Topic: [edk2-test] [PATCH] uefi-sct/SctPkg: StrUpr() test for cyrillic letters Thread-Index: AQHVYXTQNriTgS/us0CUyq35ZN49UqcZk3OA Date: Tue, 3 Sep 2019 07:42:56 +0000 Message-ID: References: <20190902095651.4585-1-xypron.glpk@gmx.de> In-Reply-To: <20190902095651.4585-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Jin -----Original Message----- From: Heinrich Schuchardt =20 Sent: Monday, September 2, 2019 5:57 PM To: devel@edk2.groups.io Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuc= hardt Subject: [edk2-test] [PATCH] uefi-sct/SctPkg: StrUpr() test for cyrillic le= tters REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1911 The test of StrUpr() of the UnicodeCollationProtocol2 uses the following te= st string: L"\x30\x50[A-D]\x40\x20\x30\x50f\x40\x20" This string contains the Unicode code point 0x050f (CYRILLIC SMALL LETTER K= OMI TJE). The correct conversion to upper case is 0x050e (CYRILLIC CAPITAL = LETTER KOMI TJE). The SCT code uses function ToUpper() which is not a part of the SCT code it= self for the verification. As the EDK2 implementation of StrUpr() does not = support upper-casing cyrillic letters it does not convert 0x050f but leaves= it unchanged. This leads to rejecting the output of UEFI implementations fully supporting= cyrillic letters. Replace cyrillic 0x50f by 0x50 ('P') to avoid false positives. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/UnicodeCollation2BBTestFunction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/B= lackBoxTest/UnicodeCollation2BBTestFunction.c b/uefi-sct/SctPkg/TestCase/UE= FI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/UnicodeCollation2BBTestFunct= ion.c index a8652a5c..653b263a 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBox= Test/UnicodeCollation2BBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/Black +++ BoxTest/UnicodeCollation2BBTestFunction.c @@ -451,7 +451,7 @@ BBTestStrUprFunctionAutoTest ( CHAR16 *TestData[] =3D{ = L"\x21\x22\x31\x32\x41\x42\x43\x44\x45\x46\x47\x= 48\x49\x4A\x4B\x4C\x4D\x4E\x4F\x50\x51\x52\x53\x54\x55\x56\x57\x58\x59\x5Ax= 61\x62\x7D\x7E", L"\x30\x50[ab= cdzyxw!)(@#*]\x40\x20\x30\x50\ab\x40\x20",- = L"\x30\x50[A-D]\x40\x20\x30\x50f\x40\x20",+ = L"\x30\x50[A-D]\x40\x20\x30\x50\x40\x20", = L"" = }; --=20 2.20.1