public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Eric Jin" <eric.jin@intel.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
	Stephano Cetola <stephano.cetola@linux.intel.com>
Subject: Re: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'
Date: Wed, 4 Sep 2019 02:27:56 +0000	[thread overview]
Message-ID: <DA72DC7456565B47808A57108259571F6380DF9F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20190903095256.7673-1-xypron.glpk@gmx.de>

Hi Heinrich Schuchardt,

According to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
The statement "Contributed-under:..." need be removed.
With that: Reviewed-by: Eric Jin <eric.jin@intel.com>

If no object, I will help to push with this change by end of this week. 

-----Original Message-----
From: Heinrich Schuchardt <xypron.glpk@gmx.de> 
Sent: Tuesday, September 3, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Stephano Cetola <stephano.cetola@linux.intel.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

%s/Remained/Remaining/g

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 .../SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
index 9e7f672e..6fd36914 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
@@ -608,10 +608,10 @@ Routine Description:
   //

   while (TRUE) {

     //

-    // Calculate the number of remained cases

+    // Calculate the number of remaining test cases

     //

     GetTestCaseRemainNum(&Remain);

-    SctPrint(L"  Remained test cases: %d\n", Remain);

+    SctPrint(L"  Remaining test cases: %d\n", Remain);

 

     //

     // Send assertion to remotion computer in passive mode to inform case begin.

-- 
2.23.0.rc1


  reply	other threads:[~2019-09-04  2:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03  9:52 [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases' Heinrich Schuchardt
2019-09-04  2:27 ` Eric Jin [this message]
2019-09-04  6:37   ` Heinrich Schuchardt
2019-09-06  3:54     ` Eric Jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DA72DC7456565B47808A57108259571F6380DF9F@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox