From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: eric.jin@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Thu, 05 Sep 2019 20:53:11 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 20:53:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,472,1559545200"; d="scan'208";a="358665190" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 05 Sep 2019 20:53:10 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Sep 2019 20:53:09 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Sep 2019 20:53:09 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Fri, 6 Sep 2019 11:53:07 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "Jin, Eric" , Heinrich Schuchardt CC: Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: assertion for UninstallMultipleProtocols Thread-Topic: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: assertion for UninstallMultipleProtocols Thread-Index: AQHVYWqhmHtxLUQDR0671q7ILHkW3KcZckfggASX8BA= Date: Fri, 6 Sep 2019 03:53:06 +0000 Message-ID: References: <20190902084412.3731-1-xypron.glpk@gmx.de> <15C0D77452E5C8B1.15710@groups.io> In-Reply-To: <15C0D77452E5C8B1.15710@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed at 30c4031acbdbdaddc824c67a27ac89a749447138 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Tuesday, September 3, 2019 1:46 PM To: Heinrich Schuchardt ; devel@edk2.groups.io Cc: Supreeth Venkatesh ; Stephano Cetola Subject: Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: asserti= on for UninstallMultipleProtocols Reviewed-by: Eric Jin -----Original Message----- From: Heinrich Schuchardt =20 Sent: Monday, September 2, 2019 4:44 PM To: devel@edk2.groups.io Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schu= chardt Subject: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: assertion for UninstallM= ultipleProtocols REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1869 BS.UninstallMultipleProtocolInterfaces - InterfaceTestCheckpoint6 expects UninstallMultipleProtocols() to return EFI_ACCESS_DENIED but the UEFI spec has: "If any errors are generated while the protocol interfaces are being unins= talled, then the protocols uninstalled prior to the error will be reinstall= ed with the boot service EFI_BOOT_SERVICES.InstallProtocolInterface() and the status code EFI_INVAL= ID_PARAMETER is returned." So the SCT should check for EFI_INVALID_PARAMETER and not for EFI_ACCESS_D= ENIED. Correct the assertion. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/ProtocolHandlerBBTestFunction_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandle= rServices/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c b/uefi-sct/SctPkg/= TestCase/UEFI/EFI/BootServices/ProtocolHandlerServices/BlackBoxTest/Protoco= lHandlerBBTestFunction_2.c index c143e558..fe6146b2 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandlerServic= es/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandlerServ +++ ices/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c @@ -12778,7 +12778,7 @@ BBTestUninstallMultipleProtocolInterfacesInterface= TestCheckPoint6 ( // // Step 1: check return status //- if (EFI_ACCESS_DENIE= D =3D=3D Status) {+ if (EFI_INVALID_PARAMETER =3D=3D Status) { Ass= ertionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType = = =3D EFI_TEST_ASSERTION_FAILED;--=20 2.20.1