From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: eric.jin@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Wed, 11 Sep 2019 19:33:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 19:33:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="197085509" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 11 Sep 2019 19:33:04 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 19:33:01 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 19:33:01 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Thu, 12 Sep 2019 10:32:59 +0800 From: "Eric Jin" To: Heinrich Schuchardt , EDK II Development CC: Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported Thread-Topic: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported Thread-Index: AQHVaNEDTjWoDbjSiUGVilgQ/3UXJKcnUvpw Date: Thu, 12 Sep 2019 02:32:58 +0000 Message-ID: References: <20190911184430.29684-1-xypron.glpk@gmx.de> In-Reply-To: <20190911184430.29684-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Heinrich, Could you please provide your company/organization info in copyright part? I could help to add it when I push the patch. With that - Reviewed by: Eric Jin Best Regards Eric -----Original Message----- From: Heinrich Schuchardt =20 Sent: Thursday, September 12, 2019 2:45 AM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuc= hardt Subject: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle sta= te may be unsupported REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2169 The UEFI specification allows EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState() to return EFI_UNSUPPORTED if a state change is not supported. This for inst= ance may be the case when connecting via a serial connection. Up to now the SCT has marked the conformance test as FAILED if SetState() w= as called with invalid parameters and EFI_UNSUPPORTED was returned which co= ntradicts the specification. Instead create a warning if SetState() returns EFI_UNSUPPORTED. This allows= the user to check if the non-support is justified. Signed-off-by: Heinrich Schuchardt --- v2: Issue warning if EFI_UNSUPPORTED is returned when called with invalid parameters. --- .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/B= lackBoxTest/SimpleTextInputExBBTestConformance.c b/uefi-sct/SctPkg/TestCase= /UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestCo= nformance.c index d997b651..946cb274 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBox= Test/SimpleTextInputExBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/Black +++ BoxTest/SimpleTextInputExBBTestConformance.c @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 ( ); } }- - if ( EFI_INVALID_PARAMETER !=3D = Status) {++ if (Status =3D=3D EFI_UNSUPPORTED) {+ AssertionType =3D EFI= _TEST_ASSERTION_WARNING;+ } else if (Status !=3D EFI_INVALID_PARAMETER) { = AssertionType =3D EFI_TEST_ASSERTION_FAILED; } else { AssertionTy= pe =3D EFI_TEST_ASSERTION_PASSED;--=20 2.20.1