From: "Eric Jin" <eric.jin@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
Stephano Cetola <stephano.cetola@linux.intel.com>
Subject: Re: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported
Date: Mon, 16 Sep 2019 01:50:15 +0000 [thread overview]
Message-ID: <DA72DC7456565B47808A57108259571F638128B0@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <15C390254A59DD09.12914@groups.io>
Pushed at fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eric Jin
Sent: Thursday, September 12, 2019 10:33 AM
To: Heinrich Schuchardt <xypron.glpk@gmx.de>; EDK II Development <devel@edk2.groups.io>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Stephano Cetola <stephano.cetola@linux.intel.com>
Subject: Re: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported
Heinrich,
Could you please provide your company/organization info in copyright part?
I could help to add it when I push the patch.
With that - Reviewed by: Eric Jin <eric.jin@intel.com>
Best Regards
Eric
-----Original Message-----
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Sent: Thursday, September 12, 2019 2:45 AM
To: EDK II Development <devel@edk2.groups.io>
Cc: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Stephano Cetola <stephano.cetola@linux.intel.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2169
The UEFI specification allows EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState()
to return EFI_UNSUPPORTED if a state change is not supported. This for instance may be the case when connecting via a serial connection.
Up to now the SCT has marked the conformance test as FAILED if SetState() was called with invalid parameters and EFI_UNSUPPORTED was returned which contradicts the specification.
Instead create a warning if SetState() returns EFI_UNSUPPORTED. This allows the user to check if the non-support is justified.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
v2:
Issue warning if EFI_UNSUPPORTED is returned when called with
invalid parameters.
---
.../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestConformance.c
index d997b651..946cb274 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/Black
+++ BoxTest/SimpleTextInputExBBTestConformance.c
@@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 (
); } }- - if ( EFI_INVALID_PARAMETER != Status) {++ if (Status == EFI_UNSUPPORTED) {+ AssertionType = EFI_TEST_ASSERTION_WARNING;+ } else if (Status != EFI_INVALID_PARAMETER) { AssertionType = EFI_TEST_ASSERTION_FAILED; } else { AssertionType = EFI_TEST_ASSERTION_PASSED;--
2.20.1
prev parent reply other threads:[~2019-09-16 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 18:44 [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported Heinrich Schuchardt
2019-09-12 2:32 ` Eric Jin
2019-09-12 5:43 ` Heinrich Schuchardt
[not found] ` <15C390254A59DD09.12914@groups.io>
2019-09-16 1:50 ` Eric Jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA72DC7456565B47808A57108259571F638128B0@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox