From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: eric.jin@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Sun, 15 Sep 2019 18:50:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2019 18:50:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="188471864" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 15 Sep 2019 18:50:18 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Sep 2019 18:50:17 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 15 Sep 2019 18:50:17 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 15 Sep 2019 18:50:17 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Mon, 16 Sep 2019 09:50:15 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , Heinrich Schuchardt CC: Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported Thread-Topic: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported Thread-Index: AQHVaNEDTjWoDbjSiUGVilgQ/3UXJKcnUvpwgAY9ZRA= Date: Mon, 16 Sep 2019 01:50:15 +0000 Message-ID: References: <20190911184430.29684-1-xypron.glpk@gmx.de> <15C390254A59DD09.12914@groups.io> In-Reply-To: <15C390254A59DD09.12914@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed at fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Thursday, September 12, 2019 10:33 AM To: Heinrich Schuchardt ; EDK II Development Cc: Supreeth Venkatesh ; Stephano Cetola Subject: Re: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: sett= ing key toggle state may be unsupported Heinrich, Could you please provide your company/organization info in copyright part? I could help to add it when I push the patch. With that - Reviewed by: Eric Jin Best Regards Eric -----Original Message----- From: Heinrich Schuchardt =20 Sent: Thursday, September 12, 2019 2:45 AM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schu= chardt Subject: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle st= ate may be unsupported REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2169 The UEFI specification allows EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState() to return EFI_UNSUPPORTED if a state change is not supported. This for ins= tance may be the case when connecting via a serial connection. Up to now the SCT has marked the conformance test as FAILED if SetState() = was called with invalid parameters and EFI_UNSUPPORTED was returned which c= ontradicts the specification. Instead create a warning if SetState() returns EFI_UNSUPPORTED. This allow= s the user to check if the non-support is justified. Signed-off-by: Heinrich Schuchardt --- v2: Issue warning if EFI_UNSUPPORTED is returned when called with invalid parameters. --- .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/= BlackBoxTest/SimpleTextInputExBBTestConformance.c b/uefi-sct/SctPkg/TestCas= e/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestC= onformance.c index d997b651..946cb274 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBo= xTest/SimpleTextInputExBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/Black +++ BoxTest/SimpleTextInputExBBTestConformance.c @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 ( ); } }- - if ( EFI_INVALID_PARAMETER !=3D= Status) {++ if (Status =3D=3D EFI_UNSUPPORTED) {+ AssertionType =3D EF= I_TEST_ASSERTION_WARNING;+ } else if (Status !=3D EFI_INVALID_PARAMETER) {= AssertionType =3D EFI_TEST_ASSERTION_FAILED; } else { AssertionT= ype =3D EFI_TEST_ASSERTION_PASSED;--=20 2.20.1