From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: eric.jin@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Sun, 15 Sep 2019 19:30:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2019 19:30:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,510,1559545200"; d="scan'208";a="201507713" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 15 Sep 2019 19:30:36 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Sep 2019 19:30:36 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Sep 2019 19:30:36 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Mon, 16 Sep 2019 10:30:33 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "xypron.glpk@gmx.de" CC: Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: UninstallMultipleProtocols, checkpoint 7-9 Thread-Topic: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: UninstallMultipleProtocols, checkpoint 7-9 Thread-Index: AQHVaaAfktoWGrVhrEap5v/WVnHu26ctmiXA Date: Mon, 16 Sep 2019 02:30:33 +0000 Message-ID: References: <20190912192702.26999-1-xypron.glpk@gmx.de> In-Reply-To: <20190912192702.26999-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Jin -----Original Message----- From: devel@edk2.groups.io On Behalf Of Heinrich Sch= uchardt Sent: Friday, September 13, 2019 3:27 AM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuc= hardt Subject: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: UninstallMul= tipleProtocols, checkpoint 7-9 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1869 BS.UninstallMultipleProtocolInterfaces - InterfaceTestCheckpoint7 - 9 expec= t UninstallMultipleProtocols() to return EFI_ACCESS_DENIED but the UEFI spe= c has: "If any errors are generated while the protocol interfaces are being uninst= alled, then the protocols uninstalled prior to the error will be reinstalle= d with the boot service EFI_BOOT_SERVICES.InstallProtocolInterface() and the status code EFI_INVALI= D_PARAMETER is returned." So the SCT should check for EFI_INVALID_PARAMETER and not for EFI_ACCESS_DE= NIED. Correct the assertions. InterfaceCheckpoint6 has already been corrected with commit 30c4031acbdb ("uefi-sct/SctPkg: assertion for UninstallMultipleProtocols") Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/ProtocolHandlerBBTestFunction_2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandler= Services/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c b/uefi-sct/SctPkg/T= estCase/UEFI/EFI/BootServices/ProtocolHandlerServices/BlackBoxTest/Protocol= HandlerBBTestFunction_2.c index fe6146b2..104e93b5 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandlerService= s/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandlerServ +++ ices/BlackBoxTest/ProtocolHandlerBBTestFunction_2.c @@ -13108,7 +13108,7 @@ BBTestUninstallMultipleProtocolInterfacesInterfaceT= estCheckPoint7 ( // // Step 1: check return status //- if (EFI_ACCESS_DENIED= =3D=3D Status) {+ if (EFI_INVALID_PARAMETER =3D=3D Status) { Asse= rtionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType = =3D EFI_TEST_ASSERTION_FAILED;@@ -13453,7 +13453,7 @@ BBTestUninstallMultip= leProtocolInterfacesInterfaceTestCheckPoint8 ( // // Step 1: check return status //- if (EFI_ACCESS_DENIED= =3D=3D Status) {+ if (EFI_INVALID_PARAMETER =3D=3D Status) { Asse= rtionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType = =3D EFI_TEST_ASSERTION_FAILED;@@ -13807,7 +13807,7 @@ BBTestUninstallMultip= leProtocolInterfacesInterfaceTestCheckPoint9 ( // // Step 1: check return status //- if (EFI_ACCESS_DENIED= =3D=3D Status) {+ if (EFI_INVALID_PARAMETER =3D=3D Status) { Asse= rtionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType = =3D EFI_TEST_ASSERTION_FAILED;--=20 2.23.0 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47199): https://edk2.groups.io/g/devel/message/47199 Mute This Topic: https://groups.io/mt/34118784/1787343 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [eric.jin@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D