From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: eric.jin@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 18 Sep 2019 23:17:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 23:17:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="187993461" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 18 Sep 2019 23:17:31 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 23:17:29 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 23:17:13 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.146]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 14:17:12 +0800 From: "Eric Jin" To: Tom Zhao , "devel@edk2.groups.io" CC: Supreeth Venkatesh , "Liu, XianhuiX" Subject: Re: [PATCH v2 1/1] uefi-sct/SctPkg AdapterInfo SetInformation may return unsupported Thread-Topic: [PATCH v2 1/1] uefi-sct/SctPkg AdapterInfo SetInformation may return unsupported Thread-Index: AQHVbf3ao8GfBA+Qv0OxU9hv2LHja6cyh2DQ Date: Thu, 19 Sep 2019 06:17:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable EFI_UNSUPPORTED The InformationType is not known. The description is described as above in UEFI Spec. In this case, the test gets the InformationType from EFI_ADAPTER_GET_INFO()= , so the SetInformationfunction return EFI_UNSUPPORTED doesn't make sense. = The reason is not covered by spec at least. How about to do some basic check in device or return EFI_DEVICE_ERROR.=20 And the test could add EFI_DEVICE_ERROR into acceptable return code. -----Original Message----- From: Tom Zhao =20 Sent: Wednesday, September 18, 2019 4:48 PM To: devel@edk2.groups.io Cc: Jin, Eric ; Supreeth Venkatesh Subject: [PATCH v2 1/1] uefi-sct/SctPkg AdapterInfo SetInformation may retu= rn unsupported If AdapterInfo.SetInformation() is unsupported, it will return EFI_UNSUPPOR= TED. Do not fail the test in this case. Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: Tom Zhao --- Notes: v2: - Change commit message to be closer to similar issues. uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapte= rInfoBBTestConformance.c | 4 ++-- uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapte= rInfoBBTestFunction.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapt= erInfoBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapt= erInfoBBTestConformance.c index fb42398e4a97..3dc048db5333 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapt= erInfoBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapt= erInfoBBTestConformance.c @@ -556,8 +556,8 @@ BBTestSetInformationConformanceTestCheckpoint2 ( NULL, InformationBlockSize ); - - if ( Status !=3D EFI_INVALID_PARAMETER && Status !=3D EFI_WRITE_PROTECTED) { + + if ( Status !=3D EFI_INVALID_PARAMETER && Status !=3D EFI_WRITE_PROTECTED && Status !=3D EFI_UNSUPPORTED) { AssertionType =3D EFI_TEST_ASSERTION_FAILED; } else { AssertionType =3D EFI_TEST_ASSERTION_PASSED; diff --git a/uefi-sct= /SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTe= stFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapt= erInfoBBTestFunction.c index 334bb9edc493..4b054b0ef7d8 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapt= erInfoBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/Adapt= erInfoBBTestFunction.c @@ -372,11 +372,11 @@ BBTestSetInformationFunctionTestCheckpoint1 ( InformationBlockSize1 ); - if (Status =3D=3D EFI_SUCCESS || Status =3D=3D EFI_WRITE_PROTECTED) - AssertionType =3D EFI_TEST_ASSERTION_PASSED; + if (Status =3D=3D EFI_SUCCESS || Status =3D=3D EFI_WRITE_PROTECTED || Status =3D=3D EFI_UNSU= PPORTED) + AssertionType =3D EFI_TEST_ASSERTION_PASSED; else - AssertionType =3D EFI_TEST_ASSERTION_FAILED; - + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + StandardLib->RecordAssertion ( StandardLib, AssertionType, -- 2.21.0