From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: eric.jin@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Mon, 23 Sep 2019 01:03:14 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 01:03:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="272202554" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 23 Sep 2019 01:03:13 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 01:03:13 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 01:03:13 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 16:03:11 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "Liu, XianhuiX" CC: Oleksiy , Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination Thread-Topic: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination Thread-Index: AQHVbcol5SRezkFeyUuUmLCida+ssacz5h3AgAUI1sA= Date: Mon, 23 Sep 2019 08:03:11 +0000 Message-ID: References: <20190918023814.15056-1-xianhuix.liu@intel.com> <15C606D26BDCC3CD.32767@groups.io> In-Reply-To: <15C606D26BDCC3CD.32767@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed at 93a98df2609763cc162191bd5395617a621747fe -----Original Message----- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Friday, September 20, 2019 11:10 AM To: Liu, XianhuiX ; devel@edk2.groups.io Cc: Oleksiy ; Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid = attribute combination Reviewed-by: Eric Jin -----Original Message----- From: Liu, XianhuiX Sent: Wednesday, September 18, 2019 10:38 AM To: devel@edk2.groups.io Cc: Oleksiy ; Supreeth Venkatesh ; Jin, Eric Subject: [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combina= tion REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1942 avoid using EFI_VARIABLE_RUNTIME_ACCESS without EFI_VARIABLE_BOOTSERVICE_A= CCESS in AttrArray. Cc: Oleksiy Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu --- .../BlackBoxTest/AuthVariableServicesBBTestConformance.c | 6 += ----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableSer= vices/BlackBoxTest/AuthVariableServicesBBTestConformance.c b/uefi-sct/SctPk= g/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVaria= bleServicesBBTestConformance.c index a1d1c4c3..23b00e35 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/B= lackBoxTest/AuthVariableServicesBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices +++ /BlackBoxTest/AuthVariableServicesBBTestConformance.c @@ -1,7 +1,7 @@ /** @file =20 Copyright 2006 - 2012 Unified EFI, Inc.
- Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2010 - 2019, Intel Corporation. All rights=20 + reserved.
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the B= SD License @@ -160,19 +160,16 @@ AuthVariableDERConfTest ( // For 1 attribute. // EFI_VARIABLE_NON_VOLATILE, - EFI_VARIABLE_RUNTIME_ACCESS, EFI_VARIABLE_BOOTSERVICE_ACCESS, EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, =20 // // For 2 attributes. // - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS, EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRI= TE_ACCESS, =20 EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS, - EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_W= RITE_ACCESS, =20 EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICAT= ED_WRITE_ACCESS, =20 @@ -180,7 +177,6 @@ AuthVariableDERConfTest ( // For 3 attributes. // EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABL= E_BOOTSERVICE_ACCESS, - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABL= E_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VAR= IABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_V= ARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, =20 -- 2.14.1.windows.1