From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.jin@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Wed, 25 Sep 2019 22:38:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 22:38:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,550,1559545200"; d="scan'208";a="191579684" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 25 Sep 2019 22:38:52 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 22:38:52 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 22:38:52 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 13:38:50 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "supreeth.venkatesh@arm.com" Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience. Thread-Topic: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience. Thread-Index: AQHVc/w+chCHT7Gux0u8YRvCp1++U6c9cP0Q Date: Thu, 26 Sep 2019 05:38:49 +0000 Message-ID: References: <20190925235143.33855-1-supreeth.venkatesh@arm.com> In-Reply-To: <20190925235143.33855-1-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Jin -----Original Message----- From: devel@edk2.groups.io On Behalf Of Supreeth Ve= nkatesh Sent: Thursday, September 26, 2019 7:52 AM To: devel@edk2.groups.io Cc: Jin, Eric ; Supreeth Venkatesh Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add s= tatement to improve user experience. For users, who operate the machine remotely through serial console on some= platforms, the test prompt message shown "System will shut down (or cold r= eset) after 1 second..." is misleading, as the reset may not be automatic. This patch addresses the issue by adding a note "Note: On some platforms, = you may have to manually turn on the System again after few seconds...". This fixes bug 1623. (https://bugzilla.tianocore.org/show_bug.cgi?id=3D1623) Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c | 4 +++- .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntime= Services/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-sct/SctPkg= /TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRun= timeServicesBBTestFunction.c index 80e8297d..b4ebb806 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeService= s/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c @@ -371,7 +371,9 @@ BBTestResetSystemManualTest ( // And the stall a second is required to make sure the recovery data = has // been written into the storage device. // - SctPrint (L"System will shut down (or cold reset) after 1 second...")= ; + SctPrint (L"System may shut down (or cold reset) after 1 second..."); + SctPrint (L"Note: On some platforms, you may have to manually turn\ + =09 on the System again after few seconds..."); gtBS->Stall (1000000); =20 OldTpl =3D gtBS->RaiseTPL (TplArray[Index]); diff --git a/uefi-sct/Sc= tPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/Mis= cRuntimeServicesBBTestStress.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeS= ervices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c index 1ad732a0..ef0e1148 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeService= s/BlackBoxTest/MiscRuntimeServicesBBTestStress.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestStress.c @@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest ( // // Print out some information to avoid the user thought it is an er= ror // - SctPrint (L"System will shut down (or cold reset) after 1 second...= "); + SctPrint (L"System may shut down (or cold reset) after 1 second..."= ); + SctPrint (L"Note: On some platforms, you may have to manually turn\ + =09 on the System again after few seconds..."); gtBS->Stall (1000000); =20 OldTpl =3D gtBS->RaiseTPL (TplArray[Index]); @@ -404,4 +406,4 @@ Ma= nualStressTestStep2: } =20 return EFI_SUCCESS; -} \ No newline at end of file +} -- 2.17.1