From: "Eric Jin" <eric.jin@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"supreeth.venkatesh@arm.com" <supreeth.venkatesh@arm.com>
Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.
Date: Fri, 27 Sep 2019 03:12:49 +0000 [thread overview]
Message-ID: <DA72DC7456565B47808A57108259571F63819B6A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <15C7E669089EA5D2.20538@groups.io>
Hi Supreeth,
Sorry. I forget to check the patch format. Tab character is used in the patch.
Could you please to fix them? With that, please commit to repo. Thanks.
Best Regards
Eric
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eric Jin
> Sent: Thursday, September 26, 2019 1:39 PM
> To: devel@edk2.groups.io; supreeth.venkatesh@arm.com
> Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices:
> Add statement to improve user experience.
>
> Reviewed-by: Eric Jin <eric.jin@intel.com>
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Supreeth Venkatesh
> Sent: Thursday, September 26, 2019 7:52 AM
> To: devel@edk2.groups.io
> Cc: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>
> Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add
> statement to improve user experience.
>
> For users, who operate the machine remotely through serial console on
> some platforms, the test prompt message shown "System will shut down (or
> cold reset) after 1 second..." is misleading, as the reset may not be
> automatic.
>
> This patch addresses the issue by adding a note "Note: On some platforms,
> you may have to manually turn on the System again after few seconds...".
> This fixes bug 1623.
> (https://bugzilla.tianocore.org/show_bug.cgi?id=1623)
>
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> ---
> .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c | 4 +++-
> .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c | 6 ++++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestFunction.c
> index 80e8297d..b4ebb806 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestFunction.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi
> +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
> @@ -371,7 +371,9 @@ BBTestResetSystemManualTest (
> // And the stall a second is required to make sure the recovery data has
> // been written into the storage device.
> //
> - SctPrint (L"System will shut down (or cold reset) after 1 second...");
> + SctPrint (L"System may shut down (or cold reset) after 1 second...");
> + SctPrint (L"Note: On some platforms, you may have to manually turn\
> + on the System again after few seconds...");
Tab is used.
> gtBS->Stall (1000000);
>
> OldTpl = gtBS->RaiseTPL (TplArray[Index]); diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestStress.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestStress.c
> index 1ad732a0..ef0e1148 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestStress.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi
> +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
> @@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest (
> //
> // Print out some information to avoid the user thought it is an error
> //
> - SctPrint (L"System will shut down (or cold reset) after 1 second...");
> + SctPrint (L"System may shut down (or cold reset) after 1 second...");
> + SctPrint (L"Note: On some platforms, you may have to manually turn\
> + on the System again after few seconds...");
Tab is used.
> gtBS->Stall (1000000);
>
> OldTpl = gtBS->RaiseTPL (TplArray[Index]); @@ -404,4 +406,4 @@
> ManualStressTestStep2:
> }
>
> return EFI_SUCCESS;
> -}
> \ No newline at end of file
> +}
> --
> 2.17.1
>
>
>
>
>
>
prev parent reply other threads:[~2019-09-27 3:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 23:51 [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience Supreeth Venkatesh
2019-09-25 23:51 ` [edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the shell script Supreeth Venkatesh
2019-09-26 5:36 ` [edk2-devel] " Eric Jin
2019-09-26 5:38 ` [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience Eric Jin
[not found] ` <15C7E669089EA5D2.20538@groups.io>
2019-09-27 3:12 ` Eric Jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA72DC7456565B47808A57108259571F63819B6A@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox