From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: eric.jin@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 26 Sep 2019 20:12:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 20:12:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,553,1559545200"; d="scan'208";a="214693518" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 26 Sep 2019 20:12:52 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 20:12:52 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 20:12:51 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Fri, 27 Sep 2019 11:12:50 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "supreeth.venkatesh@arm.com" Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience. Thread-Topic: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience. Thread-Index: AQHVc/w+chCHT7Gux0u8YRvCp1++U6c9cP0QgAFpFlA= Date: Fri, 27 Sep 2019 03:12:49 +0000 Message-ID: References: <20190925235143.33855-1-supreeth.venkatesh@arm.com> <15C7E669089EA5D2.20538@groups.io> In-Reply-To: <15C7E669089EA5D2.20538@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTdjMzIwNGYtZmFkNC00Y2VhLTg3YmUtOGE5MzNlNjQxOWI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2UrVm1Xd29WRWhETE5INEl6RVk1RG5QV0x4d1RybDBzbjBSV3VLeXhva2VrNDB0QlE0Z01BdElzV1lEcmdoWCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Supreeth, Sorry. I forget to check the patch format. Tab character is used in the pa= tch. Could you please to fix them? With that, please commit to repo. Thanks. Best Regards Eric > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Eric Jin > Sent: Thursday, September 26, 2019 1:39 PM > To: devel@edk2.groups.io; supreeth.venkatesh@arm.com > Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: > Add statement to improve user experience. >=20 > Reviewed-by: Eric Jin >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Supreeth Venkatesh > Sent: Thursday, September 26, 2019 7:52 AM > To: devel@edk2.groups.io > Cc: Jin, Eric ; Supreeth Venkatesh > > Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add > statement to improve user experience. >=20 > For users, who operate the machine remotely through serial console on > some platforms, the test prompt message shown "System will shut down (or > cold reset) after 1 second..." is misleading, as the reset may not be > automatic. >=20 > This patch addresses the issue by adding a note "Note: On some platforms= , > you may have to manually turn on the System again after few seconds...". > This fixes bug 1623. > (https://bugzilla.tianocore.org/show_bug.cgi?id=3D1623) >=20 > Signed-off-by: Supreeth Venkatesh > --- > .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c | 4 +++- > .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c | 6 ++++-- > 2 files changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black > BoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black > BoxTest/MiscRuntimeServicesBBTestFunction.c > index 80e8297d..b4ebb806 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black > BoxTest/MiscRuntimeServicesBBTestFunction.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi > +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c > @@ -371,7 +371,9 @@ BBTestResetSystemManualTest ( > // And the stall a second is required to make sure the recovery dat= a has > // been written into the storage device. > // > - SctPrint (L"System will shut down (or cold reset) after 1 second...= "); > + SctPrint (L"System may shut down (or cold reset) after 1 second..."= ); > + SctPrint (L"Note: On some platforms, you may have to manually turn\ > + =09 on the System again after few seconds..."); Tab is used. > gtBS->Stall (1000000); >=20 > OldTpl =3D gtBS->RaiseTPL (TplArray[Index]); diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black > BoxTest/MiscRuntimeServicesBBTestStress.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black > BoxTest/MiscRuntimeServicesBBTestStress.c > index 1ad732a0..ef0e1148 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black > BoxTest/MiscRuntimeServicesBBTestStress.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi > +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestStress.c > @@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest ( > // > // Print out some information to avoid the user thought it is an = error > // > - SctPrint (L"System will shut down (or cold reset) after 1 second.= .."); > + SctPrint (L"System may shut down (or cold reset) after 1 second..= ."); > + SctPrint (L"Note: On some platforms, you may have to manually tur= n\ > + =09 on the System again after few seconds..."); Tab is used. > gtBS->Stall (1000000); >=20 > OldTpl =3D gtBS->RaiseTPL (TplArray[Index]); @@ -404,4 +406,4 @@ > ManualStressTestStep2: > } >=20 > return EFI_SUCCESS; > -} > \ No newline at end of file > +} > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20 >=20