From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.jin@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Sun, 29 Sep 2019 23:56:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2019 23:56:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,565,1559545200"; d="scan'208";a="390735526" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 29 Sep 2019 23:56:01 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 23:56:00 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 23:55:54 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.165]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0439.000; Mon, 30 Sep 2019 14:55:53 +0800 From: "Eric Jin" To: Heinrich Schuchardt , EDK II Development CC: Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-devel][edk2-test][PATCH 1/1] uefi-sct/SctPkg: SNP ReceiveFilters may be unsupported Thread-Topic: [edk2-devel][edk2-test][PATCH 1/1] uefi-sct/SctPkg: SNP ReceiveFilters may be unsupported Thread-Index: AdV3W+vPNziA54ZtS2q/BVX/sbzeTQ== Date: Mon, 30 Sep 2019 06:55:53 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add [edk2-test] in subject Reviewed-by: Eric Jin -----Original Message----- From: Heinrich Schuchardt =20 Sent: Tuesday, September 17, 2019 1:10 PM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuc= hardt Subject: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: SNP ReceiveFilters may b= e unsupported REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2197 If EFI_SIMPLE_NETWORK.ReceiveFilters() is not supported, it will return EFI= _UNSUPPORTED. In this case do not expect input parameters to be checked for= conformance. Signed-off-by: Heinrich Schuchardt --- .../SimpleNetworkBBTestConformance.c | 223 +++++++++++------- 1 file changed, 138 insertions(+), 85 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/Black= BoxTest/SimpleNetworkBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EF= I/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestConformance.c index 9bd21a76..09b47ee6 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest= /SimpleNetworkBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxT +++ est/SimpleNetworkBBTestConformance.c @@ -626,22 +626,31 @@ BBTestReceiveFilterConformanceTest ( // Call ReceiveFilters() function if network interface not start. // = Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE, 0, NUL= L);- if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State =3D= =3D EfiSimpleNetworkStopped)) {- AssertionType =3D EFI_TEST_ASSERTION_PA= SSED;+ if (Status =3D=3D EFI_UNSUPPORTED) {+ StandardLib->RecordMessage= (+ StandardLib,+ EFI_VERBOSE_LEVEL_QUIE= T,+ L"ReceiveFilters isn't supported, Status - %r\n",+ = Status+ ); } else {- AssertionType = =3D EFI_TEST_ASSERTION_FAILED;- }+ if ((Status =3D=3D EFI_NOT_STARTED) = && (SnpInterface->Mode->State =3D=3D EfiSimpleNetworkStopped)) {+ Asse= rtionType =3D EFI_TEST_ASSERTION_PASSED;+ } else {+ AssertionType = =3D EFI_TEST_ASSERTION_FAILED;+ } - StandardLib->RecordAssertion (- = StandardLib,- AssertionType,- = gSimpleNetworkBBTestConformanceAssertionGuid006,- L"EFI_SIM= PLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke ReceiveFilters() when network = interface not start.",- L"%a:%d:Status - %r",- = __FILE__,- (UINTN)__LINE__,- Status- = );+ StandardLib->RecordAssertion (+ Stan= dardLib,+ AssertionType,+ gSimpleNetwor= kBBTestConformanceAssertionGuid006,+ L"EFI_SIMPLE_NETWORK= _PROTOCOL.ReceiveFilters - Invoke ReceiveFilters() when network interface n= ot start.",+ L"%a:%d:Status - %r",+ __F= ILE__,+ (UINTN)__LINE__,+ Status+ = );+ } // // Assertion Point 5.6.2.2@@ -653,22 +662,31 @@= BBTestReceiveFilterConformanceTest ( } Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE,= 0, NULL);- if (Status =3D=3D EFI_DEVICE_ERROR) {- AssertionType =3D EF= I_TEST_ASSERTION_PASSED;+ if (Status =3D=3D EFI_UNSUPPORTED) {+ Standar= dLib->RecordMessage(+ StandardLib,+ EFI= _VERBOSE_LEVEL_QUIET,+ L"ReceiveFilters isn't supported, = Status - %r\n",+ Status+ ); } else {-= AssertionType =3D EFI_TEST_ASSERTION_FAILED;- }+ if (Status =3D=3D = EFI_DEVICE_ERROR) {+ AssertionType =3D EFI_TEST_ASSERTION_PASSED;+ = } else {+ AssertionType =3D EFI_TEST_ASSERTION_FAILED;+ } - Standa= rdLib->RecordAssertion (- StandardLib,- Ass= ertionType,- gSimpleNetworkBBTestConformanceAssertionGuid00= 7,- L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke R= eceiveFilters() when network interface not initialized.",- = L"%a:%d:Status - %r",- __FILE__,- (UINTN)__= LINE__,- Status- );+ StandardLib->Record= Assertion (+ StandardLib,+ AssertionTyp= e,+ gSimpleNetworkBBTestConformanceAssertionGuid007,+ = L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke Receiv= eFilters() when network interface not initialized.",+ L"%= a:%d:Status - %r",+ __FILE__,+ (UINTN)_= _LINE__,+ Status+ );+ } // // Ass= ertion Point 5.6.2.3@@ -683,22 +701,31 @@ BBTestReceiveFilterConformanceTes= t ( // Call ReceiveFilters with invalide Enable // Status =3D SnpInterf= ace->ReceiveFilters (SnpInterface, ~(SnpInterface->Mode->ReceiveFilterMask)= , 0, FALSE, 0, NULL);- if (Status =3D=3D EFI_INVALID_PARAMETER) {- Asse= rtionType =3D EFI_TEST_ASSERTION_PASSED;+ if (Status =3D=3D EFI_UNSUPPORTE= D) {+ StandardLib->RecordMessage(+ StandardLib,+ = EFI_VERBOSE_LEVEL_QUIET,+ L"ReceiveFilters i= sn't supported, Status - %r\n",+ Status+ = ); } else {- AssertionType =3D EFI_TEST_ASSERTION_FAILED;- }+ if= (Status =3D=3D EFI_INVALID_PARAMETER) {+ AssertionType =3D EFI_TEST_A= SSERTION_PASSED;+ } else {+ AssertionType =3D EFI_TEST_ASSERTION_FA= ILED;+ } - StandardLib->RecordAssertion (- StandardLib,= - AssertionType,- gSimpleNetworkBBTestConfo= rmanceAssertionGuid008,- L"EFI_SIMPLE_NETWORK_PROTOCOL.Rece= iveFilters - Invoke ReceiveFilters() with invalid Enable.",- = L"%a:%d:Status - %r",- __FILE__,- (UINTN)= __LINE__,- Status- ); + StandardLib->Re= cordAssertion (+ StandardLib,+ Assertio= nType,+ gSimpleNetworkBBTestConformanceAssertionGuid008,+= L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke Re= ceiveFilters() with invalid Enable.",+ L"%a:%d:Status - %= r",+ __FILE__,+ (UINTN)__LINE__,+ = Status+ );+ } // // Call ReceiveFilte= rs with invalide MCastFilterCnt@@ -713,59 +740,85 @@ BBTestReceiveFilterCon= formanceTest ( MAC.Addr[5] =3D 0x02; Status =3D SnpInterface->ReceiveFilters (Sn= pInterface, EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, SnpInterface->M= ode->MaxMCastFilterCount + 1, &MAC);- if (Status =3D=3D EFI_INVALID_PARA= METER) {- AssertionType =3D EFI_TEST_ASSERTION_PASSED;+ if (Status = =3D=3D EFI_UNSUPPORTED) {+ StandardLib->RecordMessage(+ = StandardLib,+ EFI_VERBOSE_LEVEL_QUIET,+ = L"ReceiveFilters isn't supported, Status - %r\n",+ = Status+ ); } else {- AssertionType =3D = EFI_TEST_ASSERTION_FAILED;+ if (Status =3D=3D EFI_INVALID_PARAMETER) {= + AssertionType =3D EFI_TEST_ASSERTION_PASSED;+ } else {+ = AssertionType =3D EFI_TEST_ASSERTION_FAILED;+ }++ StandardLib->= RecordAssertion (+ StandardLib,+ As= sertionType,+ gSimpleNetworkBBTestConformanceAssertionG= uid009,+ L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters -= Invoke ReceiveFilters() with invalid MCastFilterCnt is greater than Snp->M= ode->MaxMCastFilterCount.",+ L"%a:%d:Status - %r",+ = __FILE__,+ (UINTN)__LINE__,+ = Status+ ); } - StandardLib->RecordAss= ertion (- StandardLib,- AssertionType,-= gSimpleNetworkBBTestConformanceAssertionGuid009,- = L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke ReceiveFi= lters() with invalid MCastFilterCnt is greater than Snp->Mode->MaxMCastFilt= erCount.",- L"%a:%d:Status - %r",- __FI= LE__,- (UINTN)__LINE__,- Status- = );- Status =3D SnpInterface->ReceiveFilters (SnpInterface, = EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, 0, &MAC);- if (Status = =3D=3D EFI_INVALID_PARAMETER) {- AssertionType =3D EFI_TEST_ASSERTION_= PASSED;+ if (Status =3D=3D EFI_UNSUPPORTED) {+ StandardLib->RecordM= essage(+ StandardLib,+ EFI_VERBOSE_= LEVEL_QUIET,+ L"ReceiveFilters isn't supported, Status = - %r\n",+ Status+ ); } else {- = AssertionType =3D EFI_TEST_ASSERTION_FAILED;+ if (Status =3D=3D E= FI_INVALID_PARAMETER) {+ AssertionType =3D EFI_TEST_ASSERTION_PASSED= ;+ } else {+ AssertionType =3D EFI_TEST_ASSERTION_FAILED;+ = }++ StandardLib->RecordAssertion (+ StandardLib,+= AssertionType,+ gSimpleNetworkBBTe= stConformanceAssertionGuid043,+ L"EFI_SIMPLE_NETWORK_PR= OTOCOL.ReceiveFilters - Invoke ReceiveFilters() with invalid MCastFilterCnt= is 0.",+ L"%a:%d:Status - %r",+ __= FILE__,+ (UINTN)__LINE__,+ Status+ = ); } - StandardLib->RecordAssertion (- = StandardLib,- AssertionType,- = gSimpleNetworkBBTestConformanceAssertionGuid043,- L"EFI_S= IMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke ReceiveFilters() with invali= d MCastFilterCnt is 0.",- L"%a:%d:Status - %r",- = __FILE__,- (UINTN)__LINE__,- = Status- );- Status =3D SnpInterface->ReceiveFilters (= SnpInterface, EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, 1, NULL);- = if (Status =3D=3D EFI_INVALID_PARAMETER) {- AssertionType =3D EFI_TES= T_ASSERTION_PASSED;+ if (Status =3D=3D EFI_UNSUPPORTED) {+ Standard= Lib->RecordMessage(+ StandardLib,+ = EFI_VERBOSE_LEVEL_QUIET,+ L"ReceiveFilters isn't suppor= ted, Status - %r\n",+ Status+ ); = } else {- AssertionType =3D EFI_TEST_ASSERTION_FAILED;+ if (Sta= tus =3D=3D EFI_INVALID_PARAMETER) {+ AssertionType =3D EFI_TEST_ASSE= RTION_PASSED;+ } else {+ AssertionType =3D EFI_TEST_ASSERTION_F= AILED;+ }++ StandardLib->RecordAssertion (+ = StandardLib,+ AssertionType,+ = gSimpleNetworkBBTestConformanceAssertionGuid010,+ L"E= FI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke ReceiveFilters() with MC= astFilterCnt not match MCastFilter.",+ L"%a:%d:Status= - %r",+ __FILE__,+ (UINTN)__LI= NE__,+ Status+ ); }-- St= andardLib->RecordAssertion (- StandardLib,- = AssertionType,- gSimpleNetworkBBTestConformanceAsser= tionGuid010,- L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilter= s - Invoke ReceiveFilters() with MCastFilterCnt not match MCastFilter.",- = L"%a:%d:Status - %r",- __FILE__,- = (UINTN)__LINE__,- Status- )= ;- } //--=20 2.23.0