From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.1290.1570672998016750056 for ; Wed, 09 Oct 2019 19:03:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: eric.jin@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2019 19:03:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,278,1566889200"; d="scan'208";a="193856335" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 09 Oct 2019 19:03:17 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 9 Oct 2019 19:03:16 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 9 Oct 2019 19:03:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.165]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.33]) with mapi id 14.03.0439.000; Thu, 10 Oct 2019 10:03:14 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "Liu, XianhuiX" CC: Heinrich Schuchardt , Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SimpleTesxtInputEx change to IHV Thread-Topic: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SimpleTesxtInputEx change to IHV Thread-Index: AQHVfnjacLuZPXerCUKpa3HRSrHs2qdTIHaQ Date: Thu, 10 Oct 2019 02:03:13 +0000 Message-ID: References: <20191009080903.2800-1-xianhuix.liu@intel.com> In-Reply-To: <20191009080903.2800-1-xianhuix.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTE4YTgzMGItZDZlNi00MzQ3LTkyZjAtMzIwNzk0YjIwOTZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1Z2NmNmc1kxMDVKamVUY1hQbVlIdTVaUkpmNG5oYTVvTUtHaEt5aW5DdWpic3JRNlwvcjlBRjdHZStjckVZbkEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Xianhui, > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of xianhui > liu > Sent: Wednesday, October 9, 2019 4:09 PM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh > ; Jin, Eric ; Liu, > XianhuiX > Subject: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync > SimpleTesxtInputEx change to IHV Typo here: SimpleTesxtInputEx should be SimpleTextInputEx Best Regards Eric >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2169 > sync commit fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4 > on file EFI/Protocol/SimpleTextInputEx/BlackBoxTest > /SimpleTextInputExBBTestConformance.c to IHV >=20 > Cc: Heinrich Schuchardt > Cc: Supreeth Venkatesh > Cc: Eric Jin >=20 > Signed-off-by: xianhui liu > --- > .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 10 +++= +++- > --- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/Si > mpleTextInputExBBTestConformance.c b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/Si > mpleTextInputExBBTestConformance.c > index 3e230f9e..e1797219 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/Si > mpleTextInputExBBTestConformance.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/Black > +++ BoxTest/SimpleTextInputExBBTestConformance.c > @@ -1,7 +1,7 @@ > /** @file >=20 > Copyright 2006 - 2016 Unified EFI, Inc.
> - Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > + Copyright (c) 2010 - 2019, Intel Corporation. All rights > + reserved.
>=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of the= BSD > License @@ -153,7 +153,7 @@ BBTestSetStateConformanceTest ( > return Status; > } > BBTestSetStateConformanceTestCheckpoint2 ( StandardLib, > SimpleTextInputEx ); > - > + > Status =3D gtBS->FreePool (DevicePathStr); > if (EFI_ERROR(Status)) > return Status; > @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 ( > ); > } > } > - > - if ( EFI_INVALID_PARAMETER !=3D Status) { > + > + if (Status =3D=3D EFI_UNSUPPORTED) { > + AssertionType =3D EFI_TEST_ASSERTION_WARNING; } else if (Status != =3D > + EFI_INVALID_PARAMETER) { > AssertionType =3D EFI_TEST_ASSERTION_FAILED; > } else { > AssertionType =3D EFI_TEST_ASSERTION_PASSED; > -- > 2.14.1.windows.1 >=20 >=20 >=20