From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.5024.1570758731672545050 for ; Thu, 10 Oct 2019 18:52:11 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: eric.jin@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2019 18:52:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,282,1566889200"; d="scan'208";a="200646739" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 10 Oct 2019 18:52:11 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 10 Oct 2019 18:52:11 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 10 Oct 2019 18:52:10 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.165]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0439.000; Fri, 11 Oct 2019 09:52:08 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "Liu, XianhuiX" CC: Heinrich Schuchardt , Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV Thread-Topic: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV Thread-Index: AQHVfxBjnZyC+JG7ukG8iNrCB1Ls46dTJ4kggAGHH0A= Date: Fri, 11 Oct 2019 01:52:08 +0000 Message-ID: References: <20191010021313.12704-1-xianhuix.liu@intel.com> <15CC285599814FC1.26504@groups.io> In-Reply-To: <15CC285599814FC1.26504@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push at 6fd3e7e11930566df8c3ba8fe1c8160c9bc01607 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Thursday, October 10, 2019 10:32 AM To: devel@edk2.groups.io; Liu, XianhuiX Cc: Heinrich Schuchardt ; Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync Simp= leTextInputEx change to IHV Reviewed-by: Eric Jin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of xianhui= =20 > liu > Sent: Thursday, October 10, 2019 10:13 AM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh=20 > ; Jin, Eric ; Liu,=20 > XianhuiX > Subject: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync=20 > SimpleTextInputEx change to IHV >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2169 > sync commit fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4 > on file EFI/Protocol/SimpleTextInputEx/BlackBoxTest > /SimpleTextInputExBBTestConformance.c to IHV >=20 > Cc: Heinrich Schuchardt > Cc: Supreeth Venkatesh > Cc: Eric Jin >=20 > Signed-off-by: xianhui liu > --- > .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 10 +++= +++- > --- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/S > i mpleTextInputExBBTestConformance.c b/uefi-=20 > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/S > i > mpleTextInputExBBTestConformance.c > index 3e230f9e..e1797219 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/S > i > mpleTextInputExBBTestConformance.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/Black > +++ BoxTest/SimpleTextInputExBBTestConformance.c > @@ -1,7 +1,7 @@ > /** @file >=20 > Copyright 2006 - 2016 Unified EFI, Inc.
> - Copyright (c) 2010 - 2018, Intel Corporation. All rights=20 > reserved.
> + Copyright (c) 2010 - 2019, Intel Corporation. All rights=20 > + reserved.
>=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of=20 > the BSD License @@ -153,7 +153,7 @@ BBTestSetStateConformanceTest ( > return Status; > } > BBTestSetStateConformanceTestCheckpoint2 ( StandardLib,=20 > SimpleTextInputEx ); > - > + > Status =3D gtBS->FreePool (DevicePathStr); > if (EFI_ERROR(Status)) > return Status; > @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 ( > ); > } > } > - > - if ( EFI_INVALID_PARAMETER !=3D Status) { > + > + if (Status =3D=3D EFI_UNSUPPORTED) { > + AssertionType =3D EFI_TEST_ASSERTION_WARNING; } else if (Status != =3D > + EFI_INVALID_PARAMETER) { > AssertionType =3D EFI_TEST_ASSERTION_FAILED; > } else { > AssertionType =3D EFI_TEST_ASSERTION_PASSED; > -- > 2.14.1.windows.1 >=20 >=20 >=20