* [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV
@ 2019-10-10 2:13 xianhui liu
2019-10-10 2:31 ` [edk2-devel] " Eric Jin
[not found] ` <15CC285599814FC1.26504@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: xianhui liu @ 2019-10-10 2:13 UTC (permalink / raw)
To: devel; +Cc: Heinrich Schuchardt, Supreeth Venkatesh, Eric Jin, xianhui liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2169
sync commit fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4
on file EFI/Protocol/SimpleTextInputEx/BlackBoxTest
/SimpleTextInputExBBTestConformance.c to IHV
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Signed-off-by: xianhui liu <xianhuix.liu@intel.com>
---
.../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestConformance.c
index 3e230f9e..e1797219 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestConformance.c
@@ -1,7 +1,7 @@
/** @file
Copyright 2006 - 2016 Unified EFI, Inc.<BR>
- Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -153,7 +153,7 @@ BBTestSetStateConformanceTest (
return Status;
}
BBTestSetStateConformanceTestCheckpoint2 ( StandardLib, SimpleTextInputEx );
-
+
Status = gtBS->FreePool (DevicePathStr);
if (EFI_ERROR(Status))
return Status;
@@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 (
);
}
}
-
- if ( EFI_INVALID_PARAMETER != Status) {
+
+ if (Status == EFI_UNSUPPORTED) {
+ AssertionType = EFI_TEST_ASSERTION_WARNING;
+ } else if (Status != EFI_INVALID_PARAMETER) {
AssertionType = EFI_TEST_ASSERTION_FAILED;
} else {
AssertionType = EFI_TEST_ASSERTION_PASSED;
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV
2019-10-10 2:13 [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV xianhui liu
@ 2019-10-10 2:31 ` Eric Jin
[not found] ` <15CC285599814FC1.26504@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Eric Jin @ 2019-10-10 2:31 UTC (permalink / raw)
To: devel@edk2.groups.io, Liu, XianhuiX
Cc: Heinrich Schuchardt, Supreeth Venkatesh
Reviewed-by: Eric Jin <eric.jin@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of xianhui
> liu
> Sent: Thursday, October 10, 2019 10:13 AM
> To: devel@edk2.groups.io
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>; Jin, Eric <eric.jin@intel.com>; Liu,
> XianhuiX <xianhuix.liu@intel.com>
> Subject: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync
> SimpleTextInputEx change to IHV
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2169
> sync commit fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4
> on file EFI/Protocol/SimpleTextInputEx/BlackBoxTest
> /SimpleTextInputExBBTestConformance.c to IHV
>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Eric Jin <eric.jin@intel.com>
>
> Signed-off-by: xianhui liu <xianhuix.liu@intel.com>
> ---
> .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 10 ++++++-
> ---
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/Si
> mpleTextInputExBBTestConformance.c b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/Si
> mpleTextInputExBBTestConformance.c
> index 3e230f9e..e1797219 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/Si
> mpleTextInputExBBTestConformance.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/Black
> +++ BoxTest/SimpleTextInputExBBTestConformance.c
> @@ -1,7 +1,7 @@
> /** @file
>
> Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> - Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2010 - 2019, Intel Corporation. All rights
> + reserved.<BR>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License @@ -153,7 +153,7 @@ BBTestSetStateConformanceTest (
> return Status;
> }
> BBTestSetStateConformanceTestCheckpoint2 ( StandardLib,
> SimpleTextInputEx );
> -
> +
> Status = gtBS->FreePool (DevicePathStr);
> if (EFI_ERROR(Status))
> return Status;
> @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 (
> );
> }
> }
> -
> - if ( EFI_INVALID_PARAMETER != Status) {
> +
> + if (Status == EFI_UNSUPPORTED) {
> + AssertionType = EFI_TEST_ASSERTION_WARNING; } else if (Status !=
> + EFI_INVALID_PARAMETER) {
> AssertionType = EFI_TEST_ASSERTION_FAILED;
> } else {
> AssertionType = EFI_TEST_ASSERTION_PASSED;
> --
> 2.14.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <15CC285599814FC1.26504@groups.io>]
* Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV
[not found] ` <15CC285599814FC1.26504@groups.io>
@ 2019-10-11 1:52 ` Eric Jin
0 siblings, 0 replies; 3+ messages in thread
From: Eric Jin @ 2019-10-11 1:52 UTC (permalink / raw)
To: devel@edk2.groups.io, Liu, XianhuiX
Cc: Heinrich Schuchardt, Supreeth Venkatesh
Push at 6fd3e7e11930566df8c3ba8fe1c8160c9bc01607
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eric Jin
Sent: Thursday, October 10, 2019 10:32 AM
To: devel@edk2.groups.io; Liu, XianhuiX <xianhuix.liu@intel.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Subject: Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV
Reviewed-by: Eric Jin <eric.jin@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of xianhui
> liu
> Sent: Thursday, October 10, 2019 10:13 AM
> To: devel@edk2.groups.io
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>; Jin, Eric <eric.jin@intel.com>; Liu,
> XianhuiX <xianhuix.liu@intel.com>
> Subject: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync
> SimpleTextInputEx change to IHV
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2169
> sync commit fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4
> on file EFI/Protocol/SimpleTextInputEx/BlackBoxTest
> /SimpleTextInputExBBTestConformance.c to IHV
>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Eric Jin <eric.jin@intel.com>
>
> Signed-off-by: xianhui liu <xianhuix.liu@intel.com>
> ---
> .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 10 ++++++-
> ---
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/S
> i mpleTextInputExBBTestConformance.c b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/S
> i
> mpleTextInputExBBTestConformance.c
> index 3e230f9e..e1797219 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/S
> i
> mpleTextInputExBBTestConformance.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/Black
> +++ BoxTest/SimpleTextInputExBBTestConformance.c
> @@ -1,7 +1,7 @@
> /** @file
>
> Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> - Copyright (c) 2010 - 2018, Intel Corporation. All rights
> reserved.<BR>
> + Copyright (c) 2010 - 2019, Intel Corporation. All rights
> + reserved.<BR>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of
> the BSD License @@ -153,7 +153,7 @@ BBTestSetStateConformanceTest (
> return Status;
> }
> BBTestSetStateConformanceTestCheckpoint2 ( StandardLib,
> SimpleTextInputEx );
> -
> +
> Status = gtBS->FreePool (DevicePathStr);
> if (EFI_ERROR(Status))
> return Status;
> @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 (
> );
> }
> }
> -
> - if ( EFI_INVALID_PARAMETER != Status) {
> +
> + if (Status == EFI_UNSUPPORTED) {
> + AssertionType = EFI_TEST_ASSERTION_WARNING; } else if (Status !=
> + EFI_INVALID_PARAMETER) {
> AssertionType = EFI_TEST_ASSERTION_FAILED;
> } else {
> AssertionType = EFI_TEST_ASSERTION_PASSED;
> --
> 2.14.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-11 1:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-10 2:13 [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV xianhui liu
2019-10-10 2:31 ` [edk2-devel] " Eric Jin
[not found] ` <15CC285599814FC1.26504@groups.io>
2019-10-11 1:52 ` Eric Jin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox