From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.1235.1570805149953549537 for ; Fri, 11 Oct 2019 07:45:50 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: eric.jin@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 07:45:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,284,1566889200"; d="scan'208";a="206466316" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 11 Oct 2019 07:45:49 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 11 Oct 2019 07:45:46 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 11 Oct 2019 07:45:45 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.165]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.166]) with mapi id 14.03.0439.000; Fri, 11 Oct 2019 22:45:43 +0800 From: "Eric Jin" To: "Liu, XianhuiX" , "devel@edk2.groups.io" CC: Heinrich Schuchardt , Supreeth Venkatesh Subject: Re: [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters change to IHV Thread-Topic: [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters change to IHV Thread-Index: AQHVf9znoMENUctnZUawYqgRtLlI/6dVhU5A Date: Fri, 11 Oct 2019 14:45:43 +0000 Message-ID: References: <20191011023747.10472-1-xianhuix.liu@intel.com> In-Reply-To: <20191011023747.10472-1-xianhuix.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWQ2OGRjY2MtYzZhZi00OWY2LWI0YTYtZDc4MzQ0NjYyZjM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnROZUNHQlNcL2ozeUcrR0FXQUd0ZlZYakhsU0Nra2JTK0R6c1wvTmlZWlZ2YnJwdGdmRjhyU3Qwck9mWnl4Wm5hIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Jin > -----Original Message----- > From: Liu, XianhuiX > Sent: Friday, October 11, 2019 10:38 AM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh > ; Jin, Eric ; Liu, > XianhuiX > Subject: [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters chan= ge > to IHV >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2197 > sync commit 3d98de052fcd47f187190802e6201ac6aaabfda7 > on file EFI/Protocol/SimpleNetwork/BlackBoxTest > /SimpleNetworkBBTestConformance.c to IHV >=20 > Cc: Heinrich Schuchardt > Cc: Supreeth Venkatesh > Cc: Eric Jin >=20 > Signed-off-by: xianhui liu > --- > .../BlackBoxTest/SimpleNetworkBBTestConformance.c | 223 > +++++++++++++-------- > 1 file changed, 138 insertions(+), 85 deletions(-) >=20 > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest/Simpl > eNetworkBBTestConformance.c b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest/Simpl > eNetworkBBTestConformance.c > index c758f560..682076ea 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest/Simpl > eNetworkBBTestConformance.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxT > +++ est/SimpleNetworkBBTestConformance.c > @@ -626,22 +626,31 @@ BBTestReceiveFilterConformanceTest ( > // Call ReceiveFilters() function if network interface not start. > // > Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE, 0,= NULL); > - if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State =3D= =3D > EfiSimpleNetworkStopped)) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > - } > + if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State = =3D=3D > EfiSimpleNetworkStopped)) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid006, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() when network interface not start.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid006, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() when network interface not start.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > + } >=20 > // > // Assertion Point 5.6.2.2 > @@ -653,22 +662,31 @@ BBTestReceiveFilterConformanceTest ( > } >=20 > Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE, 0,= NULL); > - if (Status =3D=3D EFI_DEVICE_ERROR) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > - } > + if (Status =3D=3D EFI_DEVICE_ERROR) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid007, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() when network interface not initialized.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid007, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() when network interface not initialized.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > + } >=20 > // > // Assertion Point 5.6.2.3 > @@ -683,22 +701,31 @@ BBTestReceiveFilterConformanceTest ( > // Call ReceiveFilters with invalide Enable > // > Status =3D SnpInterface->ReceiveFilters (SnpInterface, ~(SnpInterface- > >Mode->ReceiveFilterMask), 0, FALSE, 0, NULL); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > - } > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid008, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() with invalid Enable.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid008, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() with invalid Enable.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > + } >=20 > // > // Call ReceiveFilters with invalide MCastFilterCnt @@ -713,59 +740,8= 5 @@ > BBTestReceiveFilterConformanceTest ( > MAC.Addr[5] =3D 0x02; >=20 > Status =3D SnpInterface->ReceiveFilters (SnpInterface, > EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, SnpInterface- > >Mode->MaxMCastFilterCount + 1, &MAC); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } > + > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid009, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invo= ke > ReceiveFilters() with invalid MCastFilterCnt is greater than Snp->Mode- > >MaxMCastFilterCount.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid009, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() with invalid MCastFilterCnt is greater than Snp->Mode- > >MaxMCastFilterCount.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > - > Status =3D SnpInterface->ReceiveFilters (SnpInterface, > EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, 0, &MAC); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } > + > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid043, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invo= ke > ReceiveFilters() with invalid MCastFilterCnt is 0.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid043, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() with invalid MCastFilterCnt is 0.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > - > Status =3D SnpInterface->ReceiveFilters (SnpInterface, > EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, 1, NULL); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } > + > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid010, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - In= voke > ReceiveFilters() with MCastFilterCnt not match MCastFilter.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > } > - > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid010, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() with MCastFilterCnt not match MCastFilter.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > - > } >=20 > // > -- > 2.14.1.windows.1