From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.2857.1570868351066826461 for ; Sat, 12 Oct 2019 01:19:11 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: eric.jin@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2019 01:19:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,287,1566889200"; d="scan'208";a="395996808" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 12 Oct 2019 01:19:10 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 12 Oct 2019 01:19:10 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 12 Oct 2019 01:19:09 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.165]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.119]) with mapi id 14.03.0439.000; Sat, 12 Oct 2019 16:19:08 +0800 From: "Eric Jin" To: "devel@edk2.groups.io" , "Liu, XianhuiX" CC: Heinrich Schuchardt , Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters change to IHV Thread-Topic: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters change to IHV Thread-Index: AQHVf9znoMENUctnZUawYqgRtLlI/6dVhU5AgAEmSLA= Date: Sat, 12 Oct 2019 08:19:07 +0000 Message-ID: References: <20191011023747.10472-1-xianhuix.liu@intel.com> <15CC9EF63907401C.5802@groups.io> In-Reply-To: <15CC9EF63907401C.5802@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push at 214d73061b9f82468db619784cfe0fd5ff5f808e -----Original Message----- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Friday, October 11, 2019 10:46 PM To: Liu, XianhuiX ; devel@edk2.groups.io Cc: Heinrich Schuchardt ; Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP Rec= eiveFilters change to IHV Reviewed-by: Eric Jin > -----Original Message----- > From: Liu, XianhuiX > Sent: Friday, October 11, 2019 10:38 AM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh=20 > ; Jin, Eric ; Liu,=20 > XianhuiX > Subject: [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters=20 > change to IHV >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2197 > sync commit 3d98de052fcd47f187190802e6201ac6aaabfda7 > on file EFI/Protocol/SimpleNetwork/BlackBoxTest > /SimpleNetworkBBTestConformance.c to IHV >=20 > Cc: Heinrich Schuchardt > Cc: Supreeth Venkatesh > Cc: Eric Jin >=20 > Signed-off-by: xianhui liu > --- > .../BlackBoxTest/SimpleNetworkBBTestConformance.c | 223 > +++++++++++++-------- > 1 file changed, 138 insertions(+), 85 deletions(-) >=20 > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest/Simpl > eNetworkBBTestConformance.c b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest/Simpl > eNetworkBBTestConformance.c > index c758f560..682076ea 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTest/Simpl > eNetworkBBTestConformance.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxT > +++ est/SimpleNetworkBBTestConformance.c > @@ -626,22 +626,31 @@ BBTestReceiveFilterConformanceTest ( > // Call ReceiveFilters() function if network interface not start. > // > Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE,= =20 > 0, NULL); > - if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State =3D= = =3D > EfiSimpleNetworkStopped)) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > - } > + if ((Status =3D=3D EFI_NOT_STARTED) && (SnpInterface->Mode->State = =3D=3D > EfiSimpleNetworkStopped)) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid006, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() when network interface not start.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid006, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters -=20 > + Invoke > ReceiveFilters() when network interface not start.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > + } >=20 > // > // Assertion Point 5.6.2.2 > @@ -653,22 +662,31 @@ BBTestReceiveFilterConformanceTest ( > } >=20 > Status =3D SnpInterface->ReceiveFilters (SnpInterface, 0, 0, FALSE,= =20 > 0, NULL); > - if (Status =3D=3D EFI_DEVICE_ERROR) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > - } > + if (Status =3D=3D EFI_DEVICE_ERROR) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid007, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() when network interface not initialized.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid007, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters -=20 > + Invoke > ReceiveFilters() when network interface not initialized.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > + } >=20 > // > // Assertion Point 5.6.2.3 > @@ -683,22 +701,31 @@ BBTestReceiveFilterConformanceTest ( > // Call ReceiveFilters with invalide Enable > // > Status =3D SnpInterface->ReceiveFilters (SnpInterface,=20 > ~(SnpInterface- > >Mode->ReceiveFilterMask), 0, FALSE, 0, NULL); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > - } > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid008, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invoke > ReceiveFilters() with invalid Enable.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid008, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters -=20 > + Invoke > ReceiveFilters() with invalid Enable.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > + } >=20 > // > // Call ReceiveFilters with invalide MCastFilterCnt @@ -713,59=20 > +740,85 @@ BBTestReceiveFilterConformanceTest ( > MAC.Addr[5] =3D 0x02; >=20 > Status =3D SnpInterface->ReceiveFilters (SnpInterface,=20 > EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, SnpInterface- > >Mode->MaxMCastFilterCount + 1, &MAC); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } > + > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid009, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters -=20 > + Invoke > ReceiveFilters() with invalid MCastFilterCnt is greater than=20 > Snp->Mode- > >MaxMCastFilterCount.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid009, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invok= e > ReceiveFilters() with invalid MCastFilterCnt is greater than=20 > Snp->Mode- > >MaxMCastFilterCount.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > - > Status =3D SnpInterface->ReceiveFilters (SnpInterface,=20 > EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, 0, &MAC); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } > + > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid043, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters -=20 > + Invoke > ReceiveFilters() with invalid MCastFilterCnt is 0.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > } >=20 > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid043, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invok= e > ReceiveFilters() with invalid MCastFilterCnt is 0.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > - > Status =3D SnpInterface->ReceiveFilters (SnpInterface,=20 > EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST, 0, FALSE, 1, NULL); > - if (Status =3D=3D EFI_INVALID_PARAMETER) { > - AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + if (Status =3D=3D EFI_UNSUPPORTED) { > + StandardLib->RecordMessage( > + StandardLib, > + EFI_VERBOSE_LEVEL_QUIET, > + L"ReceiveFilters isn't supported, Status - %r\n", > + Status > + ); > } else { > - AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + if (Status =3D=3D EFI_INVALID_PARAMETER) { > + AssertionType =3D EFI_TEST_ASSERTION_PASSED; > + } else { > + AssertionType =3D EFI_TEST_ASSERTION_FAILED; > + } > + > + StandardLib->RecordAssertion ( > + StandardLib, > + AssertionType, > + gSimpleNetworkBBTestConformanceAssertionGuid010, > + L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters -= =20 > + Invoke > ReceiveFilters() with MCastFilterCnt not match MCastFilter.", > + L"%a:%d:Status - %r", > + __FILE__, > + (UINTN)__LINE__, > + Status > + ); > } > - > - StandardLib->RecordAssertion ( > - StandardLib, > - AssertionType, > - gSimpleNetworkBBTestConformanceAssertionGuid010, > - L"EFI_SIMPLE_NETWORK_PROTOCOL.ReceiveFilters - Invok= e > ReceiveFilters() with MCastFilterCnt not match MCastFilter.", > - L"%a:%d:Status - %r", > - __FILE__, > - (UINTN)__LINE__, > - Status > - ); > - > } >=20 > // > -- > 2.14.1.windows.1