public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Andrew Fish <afish@apple.com>
To: Mike Kinney <michael.d.kinney@intel.com>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Ni, Ruiyu" <ruiyu.ni@intel.com>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package
Date: Wed, 22 Mar 2017 08:54:47 -0700	[thread overview]
Message-ID: <DAECC074-8166-4B48-BFAC-17E106F66034@apple.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F57D141326@ORSMSX113.amr.corp.intel.com>


> On Mar 22, 2017, at 8:39 AM, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
> 
> Jaben,
> 
> I like the added comment.
> 
> Maybe we should consider an INF spec enhancement to support a GUID C Name 
> for the FILE_GUID define, and the GUID C Names can be any GUID declared
> in a dependent packages from the [Packages] section of the INF.  This
> would eliminate the GUID value duplication for this use case.
> 

+1

Thanks,

Andrew Fish

> Mike
> 
>> -----Original Message-----
>> From: Carsey, Jaben
>> Sent: Wednesday, March 22, 2017 8:21 AM
>> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; leif.lindholm@linaro.org;
>> Kinney, Michael D <michael.d.kinney@intel.com>; lersek@redhat.com; Carsey, Jaben
>> <jaben.carsey@intel.com>
>> Subject: RE: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI
>> Shell app to package
>> 
>> Yes. that looks great.
>> 
>> For the changes to ShellPkg.
>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>> 
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>>> Ard Biesheuvel
>>> Sent: Wednesday, March 22, 2017 8:20 AM
>>> To: Carsey, Jaben <jaben.carsey@intel.com>
>>> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org;
>>> leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>;
>>> lersek@redhat.com
>>> Subject: Re: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for
>>> FILE_GUID of UEFI Shell app to package
>>> Importance: High
>>> 
>>> On 22 March 2017 at 15:13, Carsey, Jaben <jaben.carsey@intel.com> wrote:
>>>> Ard,
>>>> 
>>>> I am good with this change.
>>>> 
>>>> What do you think about a comment to the INF file so that if someone
>>> makes a change to the GUI there, they are informed that they need to
>>> change this location?  I worry as usually updating an INF GUID is permitted
>>> without any need to change another file...
>>>> 
>>> 
>>> Something like this perhaps?
>>> 
>>> --- a/ShellPkg/Application/Shell/Shell.inf
>>> +++ b/ShellPkg/Application/Shell/Shell.inf
>>> @@ -17,7 +17,7 @@
>>> [Defines]
>>>   INF_VERSION    = 0x00010006
>>>   BASE_NAME      = Shell
>>> -  FILE_GUID      = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1
>>> +  FILE_GUID      = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 #
>>> gUefiShellFileGuid
>>>   MODULE_TYPE    = UEFI_APPLICATION
>>>   VERSION_STRING = 1.0
>>>   ENTRY_POINT    = UefiMain
>>> 
>>> (Note that the same FILE_GUID occurs in ShellBinPkg as well, but
>>> people are unlikely that randomly change that one without regard to
>>> the source build)
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel



  parent reply	other threads:[~2017-03-22 15:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 14:04 [PATCH 0/4] Shell/Quark/ArmPkg: promote shell app FILE_GUID to proper GUID Ard Biesheuvel
2017-03-22 14:04 ` [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package Ard Biesheuvel
2017-03-22 15:13   ` Carsey, Jaben
2017-03-22 15:19     ` Ard Biesheuvel
2017-03-22 15:21       ` Carsey, Jaben
2017-03-22 15:39         ` Kinney, Michael D
2017-03-22 15:41           ` Carsey, Jaben
2017-03-22 15:54           ` Andrew Fish [this message]
2017-03-22 14:04 ` [PATCH 2/4] QuarkPlatformPkg/PlatformBootManagerLib: use new UefiShellFileGuid definition Ard Biesheuvel
2017-03-22 15:43   ` Kinney, Michael D
2017-03-22 14:04 ` [PATCH 3/4] ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID directly Ard Biesheuvel
2017-03-22 14:04 ` [PATCH 4/4] ArmVirtPkg/ArmVirtQemu: refer to Shell app via its declared GUID Ard Biesheuvel
2017-03-22 14:39   ` Laszlo Ersek
2017-03-22 15:38 ` [PATCH 0/4] Shell/Quark/ArmPkg: promote shell app FILE_GUID to proper GUID Ard Biesheuvel
2017-03-22 15:39   ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DAECC074-8166-4B48-BFAC-17E106F66034@apple.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox