From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in2.apple.com (mail-out2.apple.com [17.151.62.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA6A780297 for ; Wed, 22 Mar 2017 08:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1490198087; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=U6ogvWnlR4y2NGB88/4kTBVbp6TKS0Q0PLqM66nIPqI=; b=OeJktjSNQLz2wcfhGVEDq+u29461H8eSCNvcLxtWFSCpDj/dXKdO3cpRb7iFypBQ MZr9a8aCFS5nb9iPHxCxwXeC6MSXBB/bHogpFeiDYS8AZMA+VFZnqm37dvGv4NHf pdEl9kGeQwBSCQVpMq3i+uDTdOIS+dZU7Zj2sGSnssNlcrPgnHY/M3DZSpfCvU41 sJPSogObApfdJ7d2yAKUfRsIGbnZtIUzHZL7DP360zO/ozseWrY/dRLQ9uRH1A7k 60Q4/s2qI7MmoqzbFkuU3DaqFxz2f62/6qnN8V2PYn1J5ikOsOl+Gc5DvQMgEIf8 H4p0ugGcaBedGwmd46gMJw==; Received: from relay2.apple.com (relay2.apple.com [17.128.113.67]) by mail-in2.apple.com (Apple Secure Mail Relay) with SMTP id B5.94.29388.74E92D85; Wed, 22 Mar 2017 08:54:47 -0700 (PDT) X-AuditID: 11973e11-822329a0000072cc-c2-58d29e47a4ad Received: from nwk-mmpp-sz12.apple.com (nwk-mmpp-sz12.apple.com [17.128.115.204]) by relay2.apple.com (Apple SCV relay) with SMTP id 2A.07.06512.74E92D85; Wed, 22 Mar 2017 08:54:47 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.32.57] (unknown [17.153.32.57]) by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170210 64bit (built Feb 10 2017)) with ESMTPSA id <0ON80065247A6370@nwk-mmpp-sz12.apple.com>; Wed, 22 Mar 2017 08:54:47 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: Date: Wed, 22 Mar 2017 08:54:47 -0700 Cc: "Carsey, Jaben" , Ard Biesheuvel , "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "lersek@redhat.com" , "leif.lindholm@linaro.org" Message-id: References: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> <1490191448-22398-2-git-send-email-ard.biesheuvel@linaro.org> To: Mike Kinney X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsUi2FDorOs+71KEQUO3gsX/D7sZLfYcOsps sbHpD6vFp917WCyWHdvBYtHR8Y/J4mXPanYHdo/Fe14yedy5tofNo3v2PxaP9/uusgWwRHHZ pKTmZJalFunbJXBlvJ7/hbXgonhF3/dWxgbG9cJdjJwcEgImEn/ufGXvYuTiEBLYyyhx6Nkb li5GDrDEki3qEPFDjBLPGx4zgjTwCghK/Jh8D6yGWUBe4uB5WZAws4CWxPdHrSwQ9f1MEvcb ljODJIQFxCXendkEZWdLfF51DGwOm4CyxIr5H9hBbE6BMImdT5uYQGwWAVWJX83LWEEGMQtM Z5L4vvASG8RiG4l760+xQmxYxyzxc/oVNpArRAR0JLpXRkMcLSsx+5cXSImEwH02iTvLFzFN YBSeheTuWQh3z0Jy9wJG5lWMQrmJmTm6mXlGeokFBTmpesn5uZsYQfEx3U5wB+PxVVaHGAU4 GJV4eCNqLkUIsSaWFVfmHmKU5mBREue9d+VihJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQZG lePrNmk+sxac/jH5qoD1k0vXuu9Uzb6YtUG0qmhLwuJPvD1LVRbyn1t/u1B5I+/stC97qjbz q2mn3uZYueXYlRnKc1ecmWh0X2Kf9SOd7D/sTQc2LtCYFb3x4JVVv55f874gL/l42+lJ0gmH zrj9137p+3F14oySH2fmB7Ym7WvwcOxe6qAfw6bEUpyRaKjFXFScCAA5QzLmcAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsUi2FB8Rtd93qUIg0MTRSz+f9jNaLHn0FFm i41Nf1gtPu3ew2Kx7NgOFouOjn9MFi97VrM7sHss3vOSyePOtT1sHt2z/7F4vN93lS2AJYrL JiU1J7MstUjfLoEr4/X8L6wFF8Ur+r63MjYwrhfuYuTgkBAwkViyRb2LkYtDSOAQo8TzhseM XYycHLwCghI/Jt9jAalhFpCXOHheFiTMLKAl8f1RKwtEfT+TxP2G5cwgCWEBcYl3ZzZB2dkS n1cdA5vDJqAssWL+B3YQm1MgTGLn0yYmEJtFQFXiV/MyVpBBzALTmSS+L7zEBrHYRuLe+lOs EBvWMUv8nH6FDeQKEQEdie6V0RBHy0rM/uU1gVFgFpJTZyGcOgvJqQsYmVcxChSl5iRWGukl FhTkpOol5+duYgSHc6HzDsZjy6wOMQpwMCrx8G6ouxQhxJpYVlyZCwwLDmYlEd5nE4FCvCmJ lVWpRfnxRaU5qcWHGKuA7p/ILCWanA+MtbySeEMTEwMTY2MzY2NzE3OqCCuJ87bnX4gQEkhP LEnNTk0tSC2CWc7EwSnVwKh/gH3a4UfmV8TOMP9KOHUoN/9nrlFajIPYWWUmrYKDmS66c79t 65lsbfxc7CzzyfVFqvvNTRTWpC550fryzSk3pX9zahVT9YOiMqev4FJo2JX63qxzvYVg8bGb kqv26M587diaH83/fK9acs2hhItvnl0048x7dtt7xez3Si7xWr+EPs+OsVJiKc5INNRiLipO BAC1wnEpwgIAAA== Subject: Re: [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:54:48 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Mar 22, 2017, at 8:39 AM, Kinney, Michael D wrote: > > Jaben, > > I like the added comment. > > Maybe we should consider an INF spec enhancement to support a GUID C Name > for the FILE_GUID define, and the GUID C Names can be any GUID declared > in a dependent packages from the [Packages] section of the INF. This > would eliminate the GUID value duplication for this use case. > +1 Thanks, Andrew Fish > Mike > >> -----Original Message----- >> From: Carsey, Jaben >> Sent: Wednesday, March 22, 2017 8:21 AM >> To: Ard Biesheuvel >> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; leif.lindholm@linaro.org; >> Kinney, Michael D ; lersek@redhat.com; Carsey, Jaben >> >> Subject: RE: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI >> Shell app to package >> >> Yes. that looks great. >> >> For the changes to ShellPkg. >> Reviewed-by: Jaben Carsey >> >>> -----Original Message----- >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >>> Ard Biesheuvel >>> Sent: Wednesday, March 22, 2017 8:20 AM >>> To: Carsey, Jaben >>> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; >>> leif.lindholm@linaro.org; Kinney, Michael D ; >>> lersek@redhat.com >>> Subject: Re: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for >>> FILE_GUID of UEFI Shell app to package >>> Importance: High >>> >>> On 22 March 2017 at 15:13, Carsey, Jaben wrote: >>>> Ard, >>>> >>>> I am good with this change. >>>> >>>> What do you think about a comment to the INF file so that if someone >>> makes a change to the GUI there, they are informed that they need to >>> change this location? I worry as usually updating an INF GUID is permitted >>> without any need to change another file... >>>> >>> >>> Something like this perhaps? >>> >>> --- a/ShellPkg/Application/Shell/Shell.inf >>> +++ b/ShellPkg/Application/Shell/Shell.inf >>> @@ -17,7 +17,7 @@ >>> [Defines] >>> INF_VERSION = 0x00010006 >>> BASE_NAME = Shell >>> - FILE_GUID = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 >>> + FILE_GUID = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 # >>> gUefiShellFileGuid >>> MODULE_TYPE = UEFI_APPLICATION >>> VERSION_STRING = 1.0 >>> ENTRY_POINT = UefiMain >>> >>> (Note that the same FILE_GUID occurs in ShellBinPkg as well, but >>> people are unlikely that randomly change that one without regard to >>> the source build) >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel