Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

["Andrew Fish" <afish@apple.com>]

[-- Attachment #1: Type: text/plain, Size: 2546 bytes --]



> On Jun 2, 2020, at 8:33 PM, Andrew Fish via groups.io <afish=apple.com@groups.io> wrote:
> 
> 
> 
>> On May 29, 2020, at 7:02 AM, Leif Lindholm <leif@nuviainc.com> wrote:
>> 
>> The description of [Packages] sections stated that
>> "Packages must be listed in the order that may be required for specifying
>> include path statements for a compiler. For example, the
>> MdePkg/MdePkg.dec file must be listed before the
>> MdeModulePkg/MdeModulePkg.dec file."
>> 
>> Drop it.
>> 
>> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
>> ---
>> 
>> Surely this isn't something we take seriously?
>> If there is a measurable performance impact to the order of -I option
>> on the compiler command line, we should approach this programmatically.
>> 
> 
> I think the intent of this was to deal with duplicates include file names, and it was not really about build performance. 
> 

Whoops. Sorry I got a new Mac and for the 1st time in 12 years I did not migrate. So my scroll direction got reversed, and that reversed the order of mails in my email client and my brain has not adjusted yet. 

Thanks,

Andrew Fish

> Thanks,
> 
> Andrew Fish
> 
>> 3_edk_ii_inf_file_format/37_[packages]_sections.md | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>> 
>> diff --git a/3_edk_ii_inf_file_format/37_[packages]_sections.md b/3_edk_ii_inf_file_format/37_[packages]_sections.md
>> index 17a8d91..c09112b 100644
>> --- a/3_edk_ii_inf_file_format/37_[packages]_sections.md
>> +++ b/3_edk_ii_inf_file_format/37_[packages]_sections.md
>> @@ -42,11 +42,8 @@ Defines the `[Packages]` section tag that is used in EDK II module INF files.
>> Each entry in this section contains a directory name, forward slash character
>> and the name of the DEC file contained in the directory name.
>> 
>> -Packages must be listed in the order that may be required for specifying
>> -include path statements for a compiler. For example, the _MdePkg/MdePkg.dec_
>> -file must be listed before the `MdeModulePkg/MdeModulePkg.dec` file. If there
>> -are PCDs listed in the generated "As Built" INF, the packages that declare any
>> -PCDs must be listed in this section.
>> +If there are PCDs listed in the generated "As Built" INF, the packages that
>> +declare any PCDs must be listed in this section.
>> 
>> Each package filename must be listed only once per section. Package filenames
>> listed in architectural sections are not permitted to be listed in the common
>> -- 
>> 2.20.1
>> 
> 
> 
> 


[-- Attachment #2: Type: text/html, Size: 9704 bytes --]