From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nwk-aaemail-lapp02.apple.com (nwk-aaemail-lapp02.apple.com [17.151.62.67]) by mx.groups.io with SMTP id smtpd.web10.6487.1591155690098546438 for ; Tue, 02 Jun 2020 20:41:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=G483EgIo; spf=pass (domain: apple.com, ip: 17.151.62.67, mailfrom: afish@apple.com) Received: from pps.filterd (nwk-aaemail-lapp02.apple.com [127.0.0.1]) by nwk-aaemail-lapp02.apple.com (8.16.0.42/8.16.0.42) with SMTP id 0533afru025914; Tue, 2 Jun 2020 20:41:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=u1Z7GtrsX0V2gA8Yvgh0xLXyEXVn6tp+CW9GaLfCoPc=; b=G483EgIo4NP/k4/V1czsbcPkoSJPQdieR3bQE3lpFPQ9tlZPRFkKW7s4Zk6/l4jlpuuN wPP6NfKCGHF3KIrNVUpC8xozPvu5kXxD4e9t+jgbbxerTGrO7xR96UFQ3KEJJsWpJtvc ndWvjOv3H96LIhiGHD63Nl0MbkyvDEjLQ5b4TQhrKPCURGcIJudVvKL4Y35PHOEixGmk UmCFBiSArWEMc1G+KC5wJiB4fJtl/I8k51PeZlrxITdpRKixlZOC4keu1BZzilwlcDVK QGnTRog4dAATfEBvlNQFMgZTQEe647Wtf8EOqqA2Qc77YqInq3+LYupR82KqUth3ebQF Pw== Received: from rn-mailsvcp-mta-lapp04.rno.apple.com (rn-mailsvcp-mta-lapp04.rno.apple.com [10.225.203.152]) by nwk-aaemail-lapp02.apple.com with ESMTP id 31bm2gtp0v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 02 Jun 2020 20:41:28 -0700 Received: from rn-mailsvcp-mmp-lapp01.rno.apple.com (rn-mailsvcp-mmp-lapp01.rno.apple.com [17.179.253.14]) by rn-mailsvcp-mta-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QBB00X23ZL4GQ90@rn-mailsvcp-mta-lapp04.rno.apple.com>; Tue, 02 Jun 2020 20:41:28 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp01.rno.apple.com by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QBB00Q00ZG4NL00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Tue, 02 Jun 2020 20:41:28 -0700 (PDT) X-Va-A: X-Va-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-Va-E-CD: b36d2f685145b9007bdf8ce3213a14d4 X-Va-R-CD: b1ad5c8b25fd9ccdf0b71a2bfb629627 X-Va-CD: 0 X-Va-ID: 3664b442-72f3-4a74-a644-0cb4cedd0f15 X-V-A: X-V-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-V-E-CD: b36d2f685145b9007bdf8ce3213a14d4 X-V-R-CD: b1ad5c8b25fd9ccdf0b71a2bfb629627 X-V-CD: 0 X-V-ID: c58e57d5-66d3-42bb-be98-7eca79baf9b2 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-02_15:2020-06-02,2020-06-02 signatures=0 Received: from [17.235.27.245] (unknown [17.235.27.245]) by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QBB00SU0ZKZ7M00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Tue, 02 Jun 2020 20:41:27 -0700 (PDT) From: "Andrew Fish" Message-id: MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering Date: Tue, 02 Jun 2020 20:41:23 -0700 In-reply-to: <1614EB3F428C08F5.21938@groups.io> Cc: Leif Lindholm , Mike Kinney , Laszlo Ersek , Pankaj Bansal To: edk2-devel-groups-io , Andrew Fish References: <20200529140251.23933-1-leif@nuviainc.com> <1614EB3F428C08F5.21938@groups.io> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-02_15:2020-06-02,2020-06-02 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_A699DF5B-A4D5-4DE3-AEF0-8FFCDF7AB051" --Apple-Mail=_A699DF5B-A4D5-4DE3-AEF0-8FFCDF7AB051 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jun 2, 2020, at 8:33 PM, Andrew Fish via groups.io wrote: >=20 >=20 >=20 >> On May 29, 2020, at 7:02 AM, Leif Lindholm wrote: >>=20 >> The description of [Packages] sections stated that >> "Packages must be listed in the order that may be required for specifyi= ng >> include path statements for a compiler. For example, the >> MdePkg/MdePkg.dec file must be listed before the >> MdeModulePkg/MdeModulePkg.dec file." >>=20 >> Drop it. >>=20 >> Signed-off-by: Leif Lindholm >> --- >>=20 >> Surely this isn't something we take seriously? >> If there is a measurable performance impact to the order of -I option >> on the compiler command line, we should approach this programmatically. >>=20 >=20 > I think the intent of this was to deal with duplicates include file name= s, and it was not really about build performance.=20 >=20 Whoops. Sorry I got a new Mac and for the 1st time in 12 years I did not m= igrate. So my scroll direction got reversed, and that reversed the order of= mails in my email client and my brain has not adjusted yet.=20 Thanks, Andrew Fish > Thanks, >=20 > Andrew Fish >=20 >> 3_edk_ii_inf_file_format/37_[packages]_sections.md | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >>=20 >> diff --git a/3_edk_ii_inf_file_format/37_[packages]_sections.md b/3_edk= _ii_inf_file_format/37_[packages]_sections.md >> index 17a8d91..c09112b 100644 >> --- a/3_edk_ii_inf_file_format/37_[packages]_sections.md >> +++ b/3_edk_ii_inf_file_format/37_[packages]_sections.md >> @@ -42,11 +42,8 @@ Defines the `[Packages]` section tag that is used in= EDK II module INF files. >> Each entry in this section contains a directory name, forward slash cha= racter >> and the name of the DEC file contained in the directory name. >>=20 >> -Packages must be listed in the order that may be required for specifyi= ng >> -include path statements for a compiler. For example, the _MdePkg/MdePk= g.dec_ >> -file must be listed before the `MdeModulePkg/MdeModulePkg.dec` file. I= f there >> -are PCDs listed in the generated "As Built" INF, the packages that dec= lare any >> -PCDs must be listed in this section. >> +If there are PCDs listed in the generated "As Built" INF, the packages= that >> +declare any PCDs must be listed in this section. >>=20 >> Each package filename must be listed only once per section. Package fil= enames >> listed in architectural sections are not permitted to be listed in the = common >> --=20 >> 2.20.1 >>=20 >=20 >=20 >=20 --Apple-Mail=_A699DF5B-A4D5-4DE3-AEF0-8FFCDF7AB051 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On Jun 2,= 2020, at 8:33 PM, Andrew Fish via = groups.io <afish=3Dapple.com@groups.io> wrote:



On May 29, 2020, at 7:= 02 AM, Leif Lindholm <le= if@nuviainc.com> wrote:

The description= of [Packages] sections stated that
"Packages must be listed = in the order that may be required for specifying
include path= statements for a compiler. For example, the
MdePkg/MdePkg.de= c file must be listed before the
MdeModulePkg/MdeModulePkg.de= c file."

Drop it.

Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---

Surely this isn't something we take seriously?
If ther= e is a measurable performance impact to the order of -I option
on the compiler command line, we should approach this programmatically.

I think the intent of this was to deal with duplicates includ= e file names, and it was not really about build performance. 


Whoops. Sorry I got a new Mac and for the 1st time in = 12 years I did not migrate. So my scroll direction got reversed, and that r= eversed the order of mails in my email client and my brain has not adjusted= yet. 

Thanks,

Andrew Fish

Thanks,

Andrew Fish

3_edk_ii_inf_file_format/37_[packages]_sections.= md | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-= )

diff --git a/3_edk_ii_inf_file_format/37_[pa= ckages]_sections.md b/3_edk_ii_inf_file_format/37_[packages]_sections.mdindex 17a8d91..c09112b 100644
--- a/3_edk_ii_inf_= file_format/37_[packages]_sections.md
+++ b/3_edk_ii_inf_file= _format/37_[packages]_sections.md
@@ -42,11 +42,8 @@ Defines = the `[Packages]` section tag that is used in EDK II module INF files.
Each entry in this section contains a directory name, forward slas= h character
and the name of the DEC file contained in the dir= ectory name.

-Packages must be listed in the o= rder that may be required for specifying
-include path statem= ents for a compiler. For example, the _MdePkg/MdePkg.dec_
-fi= le must be listed before the `MdeModulePkg/MdeModulePkg.dec` file. If there=
-are PCDs listed in the generated "As Built" INF, the packag= es that declare any
-PCDs must be listed in this section.
+If there are PCDs listed in the generated "As Built" INF, the p= ackages that
+declare any PCDs must be listed in this section= .

Each package filename must be listed only on= ce per section. Package filenames
listed in architectural sec= tions are not permitted to be listed in the common
-- 
2.20.1


<= br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 1= 2px; font-style: normal; font-variant-caps: normal; font-weight: normal; le= tter-spacing: normal; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0p= x; text-decoration: none;" class=3D"">

--Apple-Mail=_A699DF5B-A4D5-4DE3-AEF0-8FFCDF7AB051--