public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Vabhav Sharma <vabhav.sharma@nxp.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Udit Kumar <udit.kumar@nxp.com>, Varun Sethi <V.Sethi@nxp.com>
Subject: Re: [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host Bridge Driver
Date: Wed, 27 Dec 2017 13:02:41 +0000	[thread overview]
Message-ID: <DB4PR04MB2994FE906482FAEE2E68B1DF3070@DB4PR04MB299.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAKv+Gu_Oq91N1Vu8Bp76_tVkpMOFdhkADmF8i+pxNkBmE6mdng@mail.gmail.com>



>-----Original Message-----
>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>Sent: Friday, December 22, 2017 9:04 PM
>To: Vabhav Sharma <vabhav.sharma@nxp.com>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
><michael.d.kinney@intel.com>; edk2-devel@lists.01.org; Udit Kumar
><udit.kumar@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
>Subject: Re: [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host
>Bridge Driver
>
>On 21 December 2017 at 18:48, Vabhav <vabhav.sharma@nxp.com> wrote:
>> Following patches will add support of NXP PCI Host Bridge Driver in edk2-
>platforms directory 'edk2-platforms/Platform/NXP'
>>
>
>Why do you need a new PciHostBridgeDxe driver? Can't you use the one in
>MdeModulePkg instead?
Using  PciHostbridge dxe driver with changes for multiple(three)  host bridge instances with 1:1 mapping  for HostBridge:Root bridge(Hb:Rb), I will evaluate MdeModulePkg for
Multiple host bridge support
>
>> Updated Directory structure for added folders in 'edk2-
>platforms/Platform/NXP' will be:
>>
>> Platform/NXP/Drivers/PciHostBridgeDxe/
>> |-- PciHostBridgeDxe.c
>> |-- PciHostBridgeDxe.inf
>> `-- PciRootBridgeIo.c
>>
>> Platform/NXP/Library/PciHostBridgeLib/
>> |-- PciCntrl.c
>> |-- PciHostBridgeLib.inf
>> `-- PciRbLib.c
>>
>
>Please put these in Silicon/NXP, not Platform/NXP
Reference is taken from ARM/Hisilicon directory structure , We plan to put only chassis specific code in Silicon/NXP and Drivers, Library in Platform/NXP.
Please suggest if there is any specific reason for putting them in Silicon/NXP?
>
>> In Platform/NXP/Library
>> PciHostBridgeLib librady is added
>>
>> In Platform/NXP/Drivers:
>> PciHostBridgeDxe driver is added
>>
>> Please review and look forward for your support in upstreaming the patches in
>edk2-platforms.
>>
>> Vabhav (3):
>>   Platform/NXP : Add PCI Host Bridge Libary
>>   Platform/NXP : Add PCI Host Bridge Driver
>>   Compilation:Modify dsc,fdf files
>>
>>  .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c    |  967 ++++++++++++++++
>>  .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf  |   61 +
>>  .../NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c | 1193
>++++++++++++++++++++
>>  Platform/NXP/Include/PciCntrlLib.h                 |  323 ++++++
>>  Platform/NXP/Include/PciHostBridge.h               |  466 ++++++++
>>  Platform/NXP/Include/PciLib.h                      |  414 +++++++
>>  Platform/NXP/Include/PciRootBridge.h               |  674 +++++++++++
>>  Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc       |   31 +
>>  Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf       |    6 +
>>  Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c   |  628 +++++++++++
>>  .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |   49 +
>>  Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c   |  331 ++++++
>>  Silicon/NXP/Chassis/Chassis.c                      |   11 +
>>  Silicon/NXP/Chassis/Chassis2/SerDes.h              |   11 +
>>  Silicon/NXP/LS1043A/LS1043A.dsc                    |    1 +
>>  15 files changed, 5166 insertions(+)
>>  create mode 100644
>> Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c
>>  create mode 100644
>> Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf
>>  create mode 100644
>> Platform/NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c
>>  create mode 100644 Platform/NXP/Include/PciCntrlLib.h
>>  create mode 100644 Platform/NXP/Include/PciHostBridge.h
>>  create mode 100644 Platform/NXP/Include/PciLib.h  create mode 100644
>> Platform/NXP/Include/PciRootBridge.h
>>  create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c
>>  create mode 100644
>> Platform/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf
>>  create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c
>>
>> --
>> 1.9.1
>>

  reply	other threads:[~2017-12-27 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 18:48 [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host Bridge Driver Vabhav
2017-12-21 18:48 ` [PATCH edk2-platforms 1/3] Platform/NXP : Add PCI Host Bridge Libary Vabhav
2017-12-21 18:48 ` [PATCH edk2-platforms 2/3] Platform/NXP : Add PCI Host Bridge Driver Vabhav
2017-12-21 18:48 ` [PATCH edk2-platforms 3/3] Compilation:Modify dsc, fdf files Vabhav
2017-12-22 15:33 ` [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host Bridge Driver Ard Biesheuvel
2017-12-27 13:02   ` Vabhav Sharma [this message]
2017-12-27 13:05     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB4PR04MB2994FE906482FAEE2E68B1DF3070@DB4PR04MB299.eurprd04.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox