Re: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp

["Thomas Abraham" <thomas.abraham@arm.com>]

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of sahil via
> groups.io
> Sent: Thursday, November 16, 2023 11:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Sami Mujawar <Sami.Mujawar@arm.com>;
> Sahil Kaushal <Sahil.Kaushal@arm.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp:
> NOR flash Dxe Driver for N1Sdp
> 
> Add NOR flash DXE driver, this brings up NV storage on
> QSPI's flash device using FVB protocol.
> 
> Signed-off-by: sahil <sahil@arm.com>
> ---
>  Platform/ARM/N1Sdp/N1SdpPlatform.dec                         |    5 +-
>  Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.inf |   72 ++
>  Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiReg.h   |   33 +
>  Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/NorFlash.h         |  491
> +++++++++
>  Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.c   |  409
> ++++++++
>  Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/NorFlash.c         | 1100
> ++++++++++++++++++++
>  Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/NorFlashFvb.c      |  647
> ++++++++++++
>  7 files changed, 2756 insertions(+), 1 deletion(-)


Can this driver be moved to either the edk2-platform drivers/ or the Platform/Arm/Drivers directory?

Otherwise, looks okay.
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

[snip]


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112194): https://edk2.groups.io/g/devel/message/112194
Mute This Topic: https://groups.io/mt/102625036/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-