From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5E8F9AC1601 for ; Thu, 7 Dec 2023 14:46:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3/rBeRft42S3LvUqY6SGiWV9WRVB/07MtjshKbke0Gw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:nodisclaimer:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701960407; v=1; b=jX8Oguw0bZ1JPV8FdeOswF7pRoJEEIZwGcJoQmuXTr9TOgPUbSTNiOqWNU0Y4GyBjNI8dZhK gYF/N7EvybtPTIUQR2b8NrkZ/6kcxzexBtmFhCDztkvJfo/IapZNr0LGXKRS0VMUBnjdbBcP8yB TZqP7zEPwhnJHgpA/rMmiWhw= X-Received: by 127.0.0.2 with SMTP id DEnYYY7687511xqSxTN5TBWE; Thu, 07 Dec 2023 06:46:47 -0800 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.52]) by mx.groups.io with SMTP id smtpd.web11.85670.1701960405989763514 for ; Thu, 07 Dec 2023 06:46:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TMNwDaJgXd4+E55p4FVLRh4LaLLd6iT3NBQEhU5RNxVkeVlj2eB4o3FeX2Rh3/31FNbvTgxDn6BPG/YaBwC7vbna/USRhrKYKK1aKBUWwWF+IWhqLQgrMnE4qTOGf2KP84MXI5M/1eKnDW11C0QBZ5aZ5yaAoNfyOmVQSnonzhYKgRRFIn/7ODP+7/8X7ao4q4ku46ZAui6RdZEwpCS6jKgWOKj75p3GY9p3L/eGBhUxt9CijZgAE38OIweqttw0smfiMuTyR0E0jHpeIXjM936wuwiwzGfI93lyEYI4M3gzTp/QKRtk9C6JEcr1zKcy4e+jxCqYwRrpqiLkqfi3gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nUK9ADoEr0ersobN70KApwFcEufm5xxVPj+jb7WXcdo=; b=DHmb72UtF3NQ3Jya1CnCqEiv7xBFtPioxY6S7YDcMsYNs9NHAftgVwXNaB3lTBdQEDV3GNSjLSnLKLf0vHoCG+rXDRwU6r2DKjDZ3Nq2dVvAJUBViZb7NaUt02feI8ZFahoWwc6EruJTRmMInYDDZZQh3VDgAzSUzGpWfna3TCBAl1peH9XdFoPxC0+hWG79FAqJq+vcvcs596+wArZv+jINe8uMoFpgAEzln871NE7G9l0DHU7WMnfY+fkuXZbql2AUHhm3LzPNoImErDz1xfAe3xeVKMHKJ5VUAjEYtMNjeLTJCXbYpuZt/wQIerG0yyy8EKLlKr/+wqLZeSsrmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none X-Received: from DB4PR08MB7934.eurprd08.prod.outlook.com (2603:10a6:10:37a::11) by DU2PR08MB7375.eurprd08.prod.outlook.com (2603:10a6:10:2f3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.26; Thu, 7 Dec 2023 14:46:42 +0000 X-Received: from DB4PR08MB7934.eurprd08.prod.outlook.com ([fe80::51a9:3f29:6df3:c82]) by DB4PR08MB7934.eurprd08.prod.outlook.com ([fe80::51a9:3f29:6df3:c82%4]) with mapi id 15.20.7046.034; Thu, 7 Dec 2023 14:46:41 +0000 From: "Thomas Abraham" To: "devel@edk2.groups.io" , Sahil Kaushal CC: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Chandni Cherukuri , nd Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp Thread-Index: AQHaGILZYLFztMX/LU2WOhED+FTsp7CeBFtQ Date: Thu, 7 Dec 2023 14:46:41 +0000 Message-ID: References: <20231116114554.4055517-1-sahil@arm.com> <20231116114554.4055517-4-sahil@arm.com> In-Reply-To: <20231116114554.4055517-4-sahil@arm.com> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D2016FA0ABF47344825F381B76F62F31.0 x-checkrecipientchecked: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB4PR08MB7934:EE_|DU2PR08MB7375:EE_ x-ms-office365-filtering-correlation-id: 1a3b689e-5697-4992-c806-08dbf7335382 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LzJklwpm4IswHz9WkHzIPCO+mxhWl8tDGMlhjSeUX+EnEIWChegxfn2P8yAg3zqqRbQfrYLBX3rRp6VxwbdUceWCbvh6B385L+ClU5xq25cR1jeHWmJlYPQPNgsSBhwe5QxxhNDN6eB73rgNZBQ0lvcCU5aflrPOxZFQHr2zCGLTYmQy158L40pTcxCtUtEO/aR4xKHWKs7zqemsHKmODl0ep1aQuIXYHOxH7gPDM7lYCw5J1DT4rOruyk7gJcgSVWQP9pSqgP7wwOWoP0lMrc1LEiPvyzI+kzpQJZnFIA9Bds1TeGEFBwFO9Yhl09EK2/RCmbbQrQUOShL607tldNcXLe8HipL3iKNwc0qVkeI6d3AuJNVFIwxu3gwsxgkuBDBUOaOf7/MpzuWTOUoMl03T3Ebj74ngEQmGzgJcMidfMIjAaajumLlHvsS2v13MqdgBdv1G4FD+oE8rnXvSRV8nWX9X2z/yb/u6NRbQ1pHPnVH+S5lD5a1/ZK96rtANLCajmC6vyoV7dQkpjVX8h70zNvBtDK7IdjhHEe11q/dCeHMZpdEn93Fmu/AUpsPMSHW+2yD/AEjxQR3SAJbVrk/M09J0ylD4Gaj+w8g21hZLHDiFmrt/85qoRQdifwdjdFndpARTkHyXl5I9YXLyFg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q3SdzC6Bxjqy7jfqyxLsNGu0flov8PGZuc6PU/v22GJk76A1BFhW1GfdKmCe?= =?us-ascii?Q?yT0w3PnA98nwzbvzT4ugRvjWyKdDb2axr3DuscY/EyadRH7oIPErJOowH3C2?= =?us-ascii?Q?AA6n8Ib2fjmIjK0bIal8lRlZV4RTakBaf4CL1Sl46PGtlw7GqRa1GbD7y9Qn?= =?us-ascii?Q?mRRb+lD+NRzAdoICX44PRjZpP5NzT78s6oScISpmreTOVavIYtDS+X94vF57?= =?us-ascii?Q?U45pfl01YdrYzp+P73L/H5wQMWv1wHNRk/CFsZJYIAd87nzJev65Z7J/K5xY?= =?us-ascii?Q?OOhwfTUPCP2UE2BGylg8TaTHjeCXK9zivS4iFdrnMLWrLyjyxggQlzco7RdH?= =?us-ascii?Q?AKGPTikJ59gQLUFCvdG2xlX2LKvXUs9/2dWTCpAtFY6RBP2sBqscTNvxqzEd?= =?us-ascii?Q?ujOJQIbskP33PZcSJd9cOrRWRImGKAoO85gJZwQLeDQ5RW/Y7UuQ90Gpf4fa?= =?us-ascii?Q?APAzefeSarNd+xbiJS7eNERt1HrGwXog1qlmwDrVNoA+Cf+UMCCTDiql+29g?= =?us-ascii?Q?IJp3/fFkvB9k83b3+lawX8jCOrK2AXZcqSXNTVcWgS7rHPpChcw0pHHS+YyQ?= =?us-ascii?Q?1zPfBiZaTUlkZhwH2UaltK6tFl1ummfCscOebtqJYoXqTk24QZFjvilxZUUh?= =?us-ascii?Q?pLdYQAdda+M5WPgtE6LNClHL/X0RT8iVjR2XNYTEK00mYwirZpXEzZZmhOLP?= =?us-ascii?Q?sISVXt0SV9mszXedBFhdBJPbIciAM7qJEmSaHSPHtt6ufxddcoJGPi/c9/ZO?= =?us-ascii?Q?4NALH+k1n1tnOlDT2Tx8O0j6Oz1oEA/eke23TW2BHHbewmv/7kdvtzqAb3k3?= =?us-ascii?Q?BjTVSHgG3Qlp4nKRu5nFW68We3R2ISApV0qDTv5dR3EKLG9DuoPwNLQCESL3?= =?us-ascii?Q?knrGMJjPydukhqzzDDjjG12GkoRGww6toUbOCo1gOd0pDDwP/JLS8/y153kc?= =?us-ascii?Q?u1I1yQV8R1n84VMYys2uCXJ1c7EBj/phlz/FEc2m2xn9vt23bRp69o7+qc0f?= =?us-ascii?Q?ONnvX1ijOZisU138SUCenJB6j63Swm9DInmVAABNlV4YvtgFyQcoVsVv2qN5?= =?us-ascii?Q?ZgNqp1ENm8Nfm2nCpemKn2nfpOX2YA1+y53GGNv0wjZjEMHSUDfl91HPqqVp?= =?us-ascii?Q?PAPFIKGJG7Kvzq5Nzmw/+fQQzdCkvwbpzoMw8KGKRXtzd41ZVP+jOO1plWpv?= =?us-ascii?Q?nIHs/xxC4j5Kv/N9Zp+QIvZ8HdPHxgXU2yruUpsrd2EmGb35XA+QcaZnjNdm?= =?us-ascii?Q?Nx1J8hlie7BYxr+nZ/PeH6kER0Ht+permSnxUBDIKsmQLg2W5WnCJ54IaWd8?= =?us-ascii?Q?plai1B8EI2/VvoVSFbX7HwU4aQxcGLfqeME1A3+/4S5Eq4iNjmf6Ib2YTtfT?= =?us-ascii?Q?/u0/2mjJK9MIzGEb7XBFPxuH3YEz9rtFscd1V7ME9li69oQZki4UqlE+KDH1?= =?us-ascii?Q?39ZosKIVq7NeSBK2RIdKQ7dslneTViqXCI6vUji7/+a7D5qswbwW8U7nmPib?= =?us-ascii?Q?uMTK1MAPtjhkgwVu/mizopPEW+yB+cbPvBiPLqqhd1Ei32876uU0VUQHO6ez?= =?us-ascii?Q?nSMdXNZCJH1py6kt3jF+6hsUFHS+IaKnsvA29hmgdg4PuFY+M/KG6dnysJv3?= =?us-ascii?Q?KJ9K+LBHU70FnYLWc8ErdQ4PWFZMAEl/8X+nEWquDqfg?= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB4PR08MB7934.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a3b689e-5697-4992-c806-08dbf7335382 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 14:46:41.9167 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jjfpfFTgCukzhIFLPS0j69RO34kcchF7WC/y6icu3nEr5ByUnM+49sSh0ziE49wwuUtef/00nXepR7LACcL5aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7375 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.abraham@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tEkQ2FbVjlw8YzaWutkAOrB6x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jX8Oguw0; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of sahil via > groups.io > Sent: Thursday, November 16, 2023 11:46 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; > Sahil Kaushal > Subject: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: > NOR flash Dxe Driver for N1Sdp >=20 > Add NOR flash DXE driver, this brings up NV storage on > QSPI's flash device using FVB protocol. >=20 > Signed-off-by: sahil > --- > Platform/ARM/N1Sdp/N1SdpPlatform.dec | 5 +- > Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.inf | 72 ++ > Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiReg.h | 33 + > Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/NorFlash.h | 491 > +++++++++ > Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.c | 409 > ++++++++ > Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/NorFlash.c | 1100 > ++++++++++++++++++++ > Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/NorFlashFvb.c | 647 > ++++++++++++ > 7 files changed, 2756 insertions(+), 1 deletion(-) Can this driver be moved to either the edk2-platform drivers/ or the Platfo= rm/Arm/Drivers directory? Otherwise, looks okay. Reviewed-by: Thomas Abraham [snip] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112194): https://edk2.groups.io/g/devel/message/112194 Mute This Topic: https://groups.io/mt/102625036/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-