From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DCB37AC1338 for ; Thu, 7 Dec 2023 10:59:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EYgQW4FxtyV1ePtRQXvwCpNVi/17YL24SuIyIBRHNDQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:nodisclaimer:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701946767; v=1; b=pmzCFS2YvVEokCscy4cARxXULekDGAD8rlLUTGVn/YM7Z7udUMj9W8lKbrZ3gKsy+RjBXaLF lDAOpFQCBolRBeokNOlca0Gmedfq0zCt/FfgFzzuL6+xeRPm4fBOPaln27T6U2uUgqGT7QrOIUa RXwtLDGFBaAfUOG82z3laP0M= X-Received: by 127.0.0.2 with SMTP id Yl1tYY7687511x5GZELzAUNG; Thu, 07 Dec 2023 02:59:27 -0800 X-Received: from EUR02-VI1-obe.outbound.protection.outlook.com (EUR02-VI1-obe.outbound.protection.outlook.com [40.107.241.86]) by mx.groups.io with SMTP id smtpd.web11.80963.1701946766567228969 for ; Thu, 07 Dec 2023 02:59:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6yWHDlhKimcZFrYeqGmYhzIrD7Yme5s4LH170Dib43myCI+xRH6PbELzZkG4yg8gMkskEEIZNv+ZXhWefsRtzyIUF5oAUzK2bJShFtE6i5pHdqOnwXRc17Geqs49DPz+9utLLT32tNcRaMXNn5EtFdlTyOw+7nmcqe0he4eoSlVsy75i+V2/tFp5kxjJFM4P8POGpsjfGU1t5h2b77qeDBFelwFrn/ruhpgkyAHQxsEfc94/Tn2+cWWtEEw16s4K/8ARAcDIEbYImgUxLYSvHGagBh4k2ked445Wrx9mU+E6/vXIRGxlSjh6lunEX/hEe6Mqzg4pDvIkDtMOwYkdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lA9A2m8qgZU733UrRXsfQZRWYUxIHGjSuVVCVzi+Oh8=; b=faVGUNx7wlF+yLLbzhJN4EFqV4HsZ4aCXtzYnEdwGLnfQLv0M5YuoXoGzDnXLDxd2igUXC7/Bdv1aIUQKfpcj/vqkE+VyIdYcSGXV+osVDYwlhSSqZpcUvT6fKz82lKNR6C2q5JquxIqe77rMi+MW+Kz9y84N6LD04y2XT4KtyNko0y3lkszmNPl2SQqUPLirgBY3878HiSM/HWyMfKoz5mTJQ8AkURCUOVfIrhFEGSPanvaVLv5XzvERkMN3L++Brh8qRu5UIqDJow4bFhJ19W58XjzVKlC4x8KcqbWkMPK8JdS+G6PRq6pTBt8N9UqI5p4ZcJ9ejoVn8pcjYJMwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none X-Received: from DB4PR08MB7934.eurprd08.prod.outlook.com (2603:10a6:10:37a::11) by GV1PR08MB10402.eurprd08.prod.outlook.com (2603:10a6:150:15d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.32; Thu, 7 Dec 2023 10:59:21 +0000 X-Received: from DB4PR08MB7934.eurprd08.prod.outlook.com ([fe80::51a9:3f29:6df3:c82]) by DB4PR08MB7934.eurprd08.prod.outlook.com ([fe80::51a9:3f29:6df3:c82%4]) with mapi id 15.20.7046.034; Thu, 7 Dec 2023 10:59:20 +0000 From: "Thomas Abraham" To: "devel@edk2.groups.io" , Sahil Kaushal CC: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Chandni Cherukuri Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/5] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/5] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region Thread-Index: AQHaGIKM04Z9ezgNlkSruWTo3u+9trCdx5oA Date: Thu, 7 Dec 2023 10:59:20 +0000 Message-ID: References: <20231116114554.4055517-1-sahil@arm.com> <20231116114554.4055517-2-sahil@arm.com> In-Reply-To: <20231116114554.4055517-2-sahil@arm.com> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3B63AE843911C747A54CAF2309833EEA.0 x-checkrecipientchecked: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB4PR08MB7934:EE_|GV1PR08MB10402:EE_ x-ms-office365-filtering-correlation-id: ec6aa559-942d-44bd-5629-08dbf71390a4 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: FZIJZfqLW5B+COxmRPnO7ZQlETDX15uikHrlSon3Jevg31zLdVtRsca7dAPvZX5ALuK0vCm0qV3DSNk5xd0h8gdYJ/15NzixbYjhGV1z6WzJFwKh/bweqBks6oePdmG829VIt8H1Hw2HuKEmow9kTTi23+yLdbJ2FjUNFHvg8Oi2V3esdUG60bv/93eVNE9sYOV1oA+x6i1jihyhFek68qnA3ejGbZ/svX+O/6eQD+u0Kd9/gkNbg35Z1tbUqNC2+IHKU704q7kstYY7zsPCQ1qG+/Vn/BqK5KLCyWW/Ctsa7Fhu72K1KQg6gktz9yo9JOywoejbfLxoYv30SLdwfuB/ui3G4Ez0YEksYfIKATxpXXTZgK9yLbULsvhXBcIJMLwLP7pzX+Xnoo58Tjbq3mXRO5kmk5rMFdXhTw5ZRxdkF/qown4QDWqE/pUj+wkEDs08Zl1JLCWmiq29VOaplHmXlxbJXUm20a/EvIRYDdYxo6fx+4s2YSlEoDsKSYJP73iZHaTuR8R/jWfD723a+CnrwmbapP2gWEZUdppuld8brF9OOProoAZxM4c1p06HThory3CcquE5k9LimWZNWUnQ1PwGsJeaA+5mzWI//aDn5lwpo5GYYtgZOO3h1DPg x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H9j+EC03VluIKzinIX8FfjQE+7yEUftBTXmcVlZyrGEJyF+nTQKwtwM5fS6Z?= =?us-ascii?Q?e45iVPbl9rpBiK6W//eQHSPtGwzQPsb+PztWxHXZxrUZEUe/5T7j7ISufSPE?= =?us-ascii?Q?SzCidaD4+aPYRV+JTA81StJaepFMgu5J8U5fNO4K18oorZZTIxmNeGt7EsZg?= =?us-ascii?Q?HNgWjbxefgh1KnX/7fn6WcaQzMA/24rJQpVEBmkvD4fp6glRa2SKXFZbK485?= =?us-ascii?Q?Um9kKFMnqWaOcpvKKQs4pvbb41yI50QE8HDETgPVfnUDyjZz7CMfG459NBTc?= =?us-ascii?Q?Dqq/9/nFXEgh6tjOztRADLC+j1j8VMmGYy2POh+c/53d2HgXz79xS8dkMSQf?= =?us-ascii?Q?Lgc7f4hR3JjkrknQ2T3xyENV2f3oWOab4LEjwgYlKclIfPwgrMXvVmjK2Hyo?= =?us-ascii?Q?LJvyaJcRKEjCCFU5YKhhkOPHzwow9Az6rPDRrUjUMd9bAF84y21VIf59CF3N?= =?us-ascii?Q?ysXyzBTjBnFkidVqONX4SI05bXefynEW/XJvcjA+DjNwobIUu1/rMt3wSolv?= =?us-ascii?Q?6mFQmEK22gnVw6n5s6we1fnz1wChGbeuERj1Qzy5iK/eEknGLJUeHwd7Oad+?= =?us-ascii?Q?HyrLWx75+6EGuQUKqbP1HBISCET4J6ldNFtjar0V3WQHmjpaN5APzZ34FyZ+?= =?us-ascii?Q?ozD25znTFftQupMry2fVpwRNO6BMxdrq1+aTM5gezUfGGtF/ApvD9BbpOyNV?= =?us-ascii?Q?R1lKT/tNL8OyT9ftyCmxc0EjSJZunK0iQLvjgeemU9SIdy5s6C5jXbVNr6Yp?= =?us-ascii?Q?Wsc2xlDi+j9to9vJ1wiIf3UeddJz2TamLG75PRr6RKxXGlQPhWshmalbVKVX?= =?us-ascii?Q?9iEoxNTlfyKfzAz8ZMGh0WrH66soLetbuene1+bG8HOPNzLp1uh++fgpspkc?= =?us-ascii?Q?VRn3Kg7HsqItXQUDZg0MPCH+CcxRaqEeUrpRmu3EG2j0QVcyP4eYqhXTZAC6?= =?us-ascii?Q?T0cxgOGYLCtNipdO4NcMe60xjV0jwI22YKOrXfopr8JXUykFS0GnXZ1A+fB8?= =?us-ascii?Q?idebSQR+oUaDBaSfpLGbv7R5VWLkgv+gLwKjl+vw7jUTfv7hrmIg5hGwBns8?= =?us-ascii?Q?S+YGOR0AFf1cGqj23HLdEU0DVVkf9YZMIvks48FHuR3JmjBYfrouy69Xsb93?= =?us-ascii?Q?8GGX2u/dPvYpZCw6kYSZDqwUzjMJusfvp1oqcQgrcq6JFvYr0qUPwSBEa/KA?= =?us-ascii?Q?doDbzA58y7diKhBN7LM0OjNoW4yEjbtXDsfULwSC5P80JBmJ4nr6toGshT8U?= =?us-ascii?Q?2K9gt+hSvf1s8OzIHE4tcJfzvH5mqM+FJoH67orL0J9y/2COaRgZKuYgrHnZ?= =?us-ascii?Q?QNIX3Cwp0ezDlgLjwNmC0ptMhwRC20tBjumt8lWC6l4xsdg6BFmBcho5DhDN?= =?us-ascii?Q?Xqj6sp97e4R81dcnQuaAgBAxDpVoFSpMhQEvzvDSwqEP1nxYlQeBI09gvL9C?= =?us-ascii?Q?SQBAhEk/qvIiAuff9WqDt+jLH23v6CQAsJkzLEZTT69CqXn1RKmk9mYXnCYu?= =?us-ascii?Q?PFJJ8v6vWdeHbmpWne38D8ftA9h2Dd3p2WpEHfC+ibAx2FPW+wO/FbshXTlq?= =?us-ascii?Q?UEkXo6aObTY1uJCiXcofTFSTPAAV0aRfCUkLrFUSTLw+DrDPneWwBcNyM9E+?= =?us-ascii?Q?1PpRDE8p3WRH1YrVq0J6X6mfmbbeiVPAEty5b+GV0Yxt?= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB4PR08MB7934.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec6aa559-942d-44bd-5629-08dbf71390a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 10:59:20.6123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KvMvHKq7tdq23wRPm1C67Yl9RzLDdKAeSVGZvseG6obcY2X1qSlgLwcQRLuf87JI0u2bBC2C6SyU4VQfxzeuTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10402 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.abraham@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lYpv7Wu4s51EwQbKOwS3Pn3xx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pmzCFS2Y; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of sahil via > groups.io > Sent: Thursday, November 16, 2023 11:46 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; > Sahil Kaushal > Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/5] > Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region > > Enable SCP QSPI flash region access by adding it in the PlatformLibMem > > Signed-off-by: sahil > --- > Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h | 6 ++++= +- > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 10 > ++++++++-- > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > b/Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > index 097160c7e2d1..92b8c9c45775 100644 > --- a/Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > +++ b/Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > @@ -1,6 +1,6 @@ > /** @file > > * > > -* Copyright (c) 2018 - 2020, ARM Limited. All rights reserved. > > +* Copyright (c) 2018 - 2023, ARM Limited. All rights reserved. > > * > > * SPDX-License-Identifier: BSD-2-Clause-Patent > > * > > @@ -41,6 +41,10 @@ > #define NEOVERSEN1SOC_EXP_PERIPH_BASE0 0x1C000000 > > #define NEOVERSEN1SOC_EXP_PERIPH_BASE0_SZ 0x1300000 > > > > +// SCP QSPI flash device > > +#define NEOVERSEN1SOC_SCP_QSPI_AHB_BASE 0x18000000 > > +#define NEOVERSEN1SOC_SCP_QSPI_AHB_SZ 0x2000000 > > + > > // Base address to a structure of type NEOVERSEN1SOC_PLAT_INFO which is > > // pre-populated by a earlier boot stage > > #define NEOVERSEN1SOC_PLAT_INFO_STRUCT_BASE > (NEOVERSEN1SOC_NON_SECURE_SRAM_BASE + \ > > diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem= .c > b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > index 9e8a1efc557d..eb099953fe29 100644 > --- a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > +++ b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > @@ -1,6 +1,6 @@ > /** @file > > > > - Copyright (c) 2018 - 2021, ARM Limited. All rights reserved.
> > + Copyright (c) 2018 - 2023, ARM Limited. All rights reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -13,7 +13,7 @@ > #include > > > > // The total number of descriptors, including the final "end-of-table" d= escriptor. > > -#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 19 > > +#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 20 > > > > /** > > Returns the Virtual Memory Map of the platform. > > @@ -184,6 +184,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length =3D > NEOVERSEN1SOC_EXP_PERIPH_BASE0_SZ; > > VirtualMemoryTable[Index].Attributes =3D > ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > > > + // SCP QSPI flash device > > + VirtualMemoryTable[++Index].PhysicalBase =3D > NEOVERSEN1SOC_SCP_QSPI_AHB_BASE; > > + VirtualMemoryTable[Index].VirtualBase =3D > NEOVERSEN1SOC_SCP_QSPI_AHB_BASE; > > + VirtualMemoryTable[Index].Length =3D > NEOVERSEN1SOC_SCP_QSPI_AHB_SZ; > > + VirtualMemoryTable[Index].Attributes =3D > ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > + > > if (PlatInfo->MultichipMode =3D=3D 1) { > > //Remote DDR (2GB) > > VirtualMemoryTable[++Index].PhysicalBase =3D PcdGet64 > (PcdExtMemorySpace) + > Reviewed-by: Thomas Abraham IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112181): https://edk2.groups.io/g/devel/message/112181 Mute This Topic: https://groups.io/mt/102625033/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-