From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.62; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0062.outbound.protection.outlook.com [104.47.0.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B6D221A10961 for ; Wed, 13 Dec 2017 03:21:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Rh+0LVANilJkBkbtyQBtGZbibTzucP+QmbmEdnMCRx8=; b=YIgU5oPuKlxVn4EX/T/sx35Bun4iD0114YNMpEzr8LFyXPONJEPb/iQoYn7Q8sTCZOBeQI9St09T+H0FMOYnqr1e+u49nE+HaCjoeKU/kNZRxsrA9T5Yg3ewOOgmeUxTBYwaXMNrDFzWTitej/iVL/05PYmX8ZcG3yCHYSPVu9g= Received: from DB5PR04MB0998.eurprd04.prod.outlook.com (10.161.199.12) by DB5PR04MB0997.eurprd04.prod.outlook.com (10.161.199.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Wed, 13 Dec 2017 11:26:04 +0000 Received: from DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::1d9f:72df:a04f:ddb6]) by DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::1d9f:72df:a04f:ddb6%17]) with mapi id 15.20.0260.006; Wed, 13 Dec 2017 11:26:04 +0000 From: Meenakshi Aggarwal To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [edk2 PATCH v3 2/2] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. Thread-Index: AQHTX8PpUcCJS+4DdECHmjTSvuLzg6NBP2zg Date: Wed, 13 Dec 2017 11:26:04 +0000 Message-ID: References: <20171117164805.13119-1-supreeth.venkatesh@arm.com> <20171117164805.13119-3-supreeth.venkatesh@arm.com> In-Reply-To: <20171117164805.13119-3-supreeth.venkatesh@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meenakshi.aggarwal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR04MB0997; 6:/f3lNfSscA+1PIJA2IbuTHRanEyE8fTLm1PqFyOVhxwFftTrBaZ39dnfr4uS/CLQasv/bu+6dt4vOMDXGrAfWg5ebNK2vFXu/+JIhnJTo1/sEyPzia1SrBlHUnfJXj9FRpAitlTJfR3+uDpA1cLsBUjWOyc8CXhEqkS+OuNrM8z2ghJNjX0PtWTBRHOa9byM4DyPYsE/5MJMH/ZVkwSNyuVl4O/nMEf03n369IhZStLCCaAT1N5LM5qdbBB0K1kIDckQfdRtK6cakJSGUdkFld96BauoinuWx68lYRrCxXUcNhOJH0/XK7xq9qFge7WgX9ws9xuFs/5E1JORMEEUTQMsSlKrZTp8ohQlHFHHHFM=; 5:Iy0pQfYtnKGgAx/cDGdkY8sM7MLzZJdimwmT9tPIDawOL3i6+hFyyZ3Zc1nkJBWQSB1nFkBlTYIj/LAUzGwlR+cveDjqd4VzWafRb8DX+w9/8oiF8nBDsfeAnv/gioC37sNNem7AUSttFZSx0NtUnb3OqimBGHcRoT2YdhIMy7o=; 24:VZKkQFayApfA5P3/maz5Ydxam69juv9hI/UkT0pemHcpd+WOUUOXgfzOV8OTy8YFUI9SACFBK3Bd+JNU5hahWTC16vNOg5CxHZHeFEWx0nI=; 7:wF2hDx0FWAZF5ZvoytjvYFA6ZIGG3c4NN6LdKdvh6ytTydJRVVGOf+I6I25QfPyZCmWRsoQNM33q2jWzIncdvdy4QssPxNwSm46AgpS8FbMrs2Cjx0LE/qI/iRaYfoXUUDq76Lu6anOBJO8H+OpRQsJt+4tjbK18dwb539+E4vYVIkz9EDuD27DrYdExj5egqkm2uMf36z9LWNW7TWQPN3BC1sLlyOMH8/A2gD5z9Y9Settj7QDLZ5sH5NESaolO x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 82c428d9-fdc9-4189-a61a-08d5421c4be1 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:DB5PR04MB0997; x-ms-traffictypediagnostic: DB5PR04MB0997: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(189930954265078)(162533806227266)(45079756050767)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231023)(10201501046)(6055026)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011); SRVR:DB5PR04MB0997; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB5PR04MB0997; x-forefront-prvs: 052017CAF1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(366004)(376002)(189003)(199004)(13464003)(2501003)(6306002)(7736002)(316002)(7696005)(25786009)(110136005)(74316002)(53546011)(97736004)(2950100002)(54906003)(6246003)(99286004)(478600001)(2900100001)(53936002)(6436002)(966005)(3660700001)(3280700002)(106356001)(55016002)(4326008)(102836003)(86362001)(45080400002)(53946003)(8936002)(105586002)(6116002)(2906002)(9686003)(81156014)(305945005)(5250100002)(76176011)(66066001)(33656002)(59450400001)(81166006)(229853002)(3846002)(14454004)(16799955002)(575784001)(68736007)(6506007)(5660300001)(8676002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB0997; H:DB5PR04MB0998.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82c428d9-fdc9-4189-a61a-08d5421c4be1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2017 11:26:04.0827 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB0997 Subject: Re: [edk2 PATCH v3 2/2] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 11:21:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Supreeth, Few comments inline. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Friday, November 17, 2017 10:18 PM > To: edk2-devel@lists.01.org > Cc: leif.lindholm@linaro.org; ard.biesheuvel@linaro.org > Subject: [edk2] [edk2 PATCH v3 2/2] ArmPkg/Drivers: Add > EFI_MM_COMMUNICATION_PROTOCOL DXE driver. >=20 > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides > a > means of communicating between drivers outside of MM and MMI > handlers inside of MM. >=20 > This patch implements the EFI_MM_COMMUNICATION_PROTOCOL DXE > runtime > driver for AARCH64 platforms. It uses SMCs allocated from the standard > SMC range defined in > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Finfo > center.arm.com%2Fhelp%2Ftopic%2Fcom.arm.doc.den0060a%2FDEN0060A_ > ARM_MM_Interface_Specification.pdf&data=3D02%7C01%7Cmeenakshi.aggar > wal%40nxp.com%7C27ae12fc41414e501f8208d52ddb09f3%7C686ea1d3bc2b4 > c6fa92cd99c5c301635%7C0%7C1%7C636465341155830632&sdata=3DpYKl2uUUF > VCS4M87y%2BRK8TE852QqcusN0Fm208IkjtU%3D&reserved=3D0 > to communicate with the standalone MM environment in the secure world. >=20 > This patch also adds the MM Communication driver (.inf) file to define en= try > point for this driver and other compile related information the driver > needs. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > --- > .../Drivers/MmCommunicationDxe/MmCommunication.c | 339 > +++++++++++++++++++++ > .../Drivers/MmCommunicationDxe/MmCommunication.inf | 50 +++ > 2 files changed, 389 insertions(+) > create mode 100644 > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > create mode 100644 > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf >=20 > diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > new file mode 100644 > index 0000000000..e801c1c601 > --- /dev/null > +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > @@ -0,0 +1,339 @@ > +/** @file > + > + Copyright (c) 2016-2017, ARM Limited. All rights reserved. > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the = BSD > License > + which accompanies this distribution. The full text of the license may= be > found at > + > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fope > nsource.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C27ae12 > fc41414e501f8208d52ddb09f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C636465341155830632&sdata=3DGPd9o7ovyTU10etIxP%2BBYNsYUKq > m37tPcc%2BQDKtext4%3D&reserved=3D0 > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include > + > +// > +// Address, Length of the pre-allocated buffer for communication with th= e > secure > +// world. > +// > +STATIC ARM_MEMORY_REGION_DESCRIPTOR mNsCommBuffMemRegion; > + > +// Notification event when virtual address map is set. > +STATIC EFI_EVENT mSetVirtualAddressMapEvent; > + > +// > +// Handle to install the MM Communication Protocol > +// > +STATIC EFI_HANDLE mMmCommunicateHandle; > + > +/** > + Communicates with a registered handler. > + > + This function provides an interface to send and receive messages to th= e > + Standalone MM environment on behalf of UEFI services. This function i= s > part > + of the MM Communication Protocol that may be called in physical mode > prior to > + SetVirtualAddressMap() and in virtual mode after SetVirtualAddressMap(= ). > + > + @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL > + instance. > + @param[in, out] CommBuffer A pointer to the buffer to convey > + into MMRAM. > + @param[in, out] CommSize The size of the data buffer being > + passed in. This is optional. > + > + @retval EFI_SUCCESS The message was successfully poste= d. > + @retval EFI_INVALID_PARAMETER The CommBuffer was NULL. > + @retval EFI_BAD_BUFFER_SIZE The buffer size is incorrect for t= he MM > + implementation. If this error is > + returned, the MessageLength field = in > + the CommBuffer header or the integ= er > + pointed by CommSize are updated to= reflect > + the maximum payload size the > + implementation can accommodate. > + @retval EFI_ACCESS_DENIED The CommunicateBuffer parameter > + or CommSize parameter, if not omit= ted, > + are in address range that cannot b= e > + accessed by the MM environment > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +MmCommunicationCommunicate ( > + IN CONST EFI_MM_COMMUNICATION_PROTOCOL *This, > + IN OUT VOID *CommBuffer, > + IN OUT UINTN *CommSize OPTIONAL > + ) > +{ > + EFI_MM_COMMUNICATE_HEADER *CommunicateHeader; > + ARM_SMC_ARGS CommunicateSmcArgs; > + EFI_STATUS Status; > + UINTN BufferSize; > + > + CommunicateHeader =3D CommBuffer; > + Status =3D EFI_ACCESS_DENIED; > + BufferSize =3D 0; > + > + ZeroMem (&CommunicateSmcArgs, sizeof (ARM_SMC_ARGS)); > + > + // > + // Check parameters > + // > + if (CommBuffer =3D=3D NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > + // If the length of the CommBuffer is 0 then return the expected lengt= h. > + if (CommSize) { > + if (*CommSize =3D=3D 0) { > + *CommSize =3D mNsCommBuffMemRegion.Length; > + return EFI_BAD_BUFFER_SIZE; > + } > + // > + // CommSize must hold HeaderGuid and MessageLength > + // > + if (*CommSize < sizeof (EFI_MM_COMMUNICATE_HEADER)) { > + return EFI_INVALID_PARAMETER; > + } > + BufferSize =3D *CommSize; > + } else { > + BufferSize =3D CommunicateHeader->MessageLength + > + sizeof (CommunicateHeader->HeaderGuid) + > + sizeof (CommunicateHeader->MessageLength); > + } > + > + // > + // If the buffer size is 0 or greater than what can be tolerated by th= e MM > + // environment then return the expected size. > + // > + if ((BufferSize =3D=3D 0) || > + (BufferSize > mNsCommBuffMemRegion.Length)) { > + CommunicateHeader->MessageLength =3D > mNsCommBuffMemRegion.Length - > + sizeof (CommunicateHeader->Header= Guid) - > + sizeof (CommunicateHeader->Messag= eLength); > + return EFI_BAD_BUFFER_SIZE; > + } > + > + // SMC Function ID > + CommunicateSmcArgs.Arg0 =3D > ARM_SMC_ID_MM_COMMUNICATE_AARCH64; > + > + // Reserved for Future. Must be Zero. > + CommunicateSmcArgs.Arg1 =3D 0; > + > + if (mNsCommBuffMemRegion.VirtualBase) { > + CopyMem ((VOID *)mNsCommBuffMemRegion.VirtualBase, > CommBuffer, BufferSize); > + } else { > + return EFI_ACCESS_DENIED; > + } > + > + // For the SMC64 version, this parameter is a 64-bit Physical Address = (PA) > + // or Intermediate Physical Address (IPA). > + // For the SMC32 version, this parameter is a 32-bit PA or IPA. > + CommunicateSmcArgs.Arg2 =3D > (UINTN)mNsCommBuffMemRegion.PhysicalBase; > + > + // comm_size_address is a PA or an IPA that holds the size of the > + // communication buffer being passed in. This parameter is optional > + // and can be omitted by passing a zero. > + // ARM does not recommend using it since this might require the > + // implementation to create a separate memory mapping for the > parameter. > + // ARM recommends storing the buffer size in the buffer itself. > + CommunicateSmcArgs.Arg3 =3D 0; > + > + // Call the Standalone MM environment. > + ArmCallSmc (&CommunicateSmcArgs); > + > + switch (CommunicateSmcArgs.Arg0) { > + case ARM_SMC_MM_RET_SUCCESS: > + // On exit, the size of data being returned is inferred from > + // CommSize or MessageLength + Header. > + CopyMem (CommBuffer, > + (const VOID *)mNsCommBuffMemRegion.VirtualBase, > + BufferSize); > + Status =3D EFI_SUCCESS; > + break; > + > + case ARM_SMC_MM_RET_NOT_SUPPORTED: > + case ARM_SMC_MM_RET_INVALID_PARAMS: > + Status =3D EFI_INVALID_PARAMETER; > + break; > + > + case ARM_SMC_MM_RET_DENIED: > + Status =3D EFI_ACCESS_DENIED; > + break; > + > + case ARM_SMC_MM_RET_NO_MEMORY: > + // Unexpected error since the CommSize was checked for zero length > + // prior to issuing the SMC > + default: > + Status =3D EFI_ACCESS_DENIED; > + ASSERT (0); > + } > + > + return Status; > +} > + > +// > +// MM Communication Protocol instance > +// > +EFI_MM_COMMUNICATION_PROTOCOL mMmCommunication =3D { > + MmCommunicationCommunicate > +}; > + > +/** > + Notification callback on SetVirtualAddressMap event. > + > + This function notifies the MM communication protocol interface on > + SetVirtualAddressMap event and converts pointers used in this driver > + from physical to virtual address. > + > + @param Event SetVirtualAddressMap event. > + @param Context A context when the SetVirtualAddressMap trigger= ed. > + > + @retval EFI_SUCCESS The function executed successfully. > + @retval Other Some error occurred when executing this functio= n. > + > +**/ > +STATIC > +VOID > +EFIAPI > +NotifySetVirtualAddressMap ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ) > +{ > + EFI_STATUS Status; > + > + Status =3D gRT->ConvertPointer (EFI_OPTIONAL_PTR, > + (VOID **)&mNsCommBuffMemRegion.VirtualBa= se > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "NotifySetVirtualAddressMap():" > + " Unable to convert MM runtime pointer. Status:0x%r\n", Stat= us)); > + } > + > +} > + > +/** > + The Entry Point for MM Communication > + > + This function installs the MM communication protocol interface and fin= ds > out > + what type of buffer management will be required prior to invoking the > + communication SMC. > + > + @param ImageHandle The firmware allocated handle for the EFI image= . > + @param SystemTable A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The entry point is executed successfully. > + @retval Other Some error occurred when executing this entry p= oint. > + > +**/ > +EFI_STATUS > +EFIAPI > +MmCommunicationInitialize ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + > + mNsCommBuffMemRegion.PhysicalBase =3D PcdGet64 (PcdMmBufferBase); > + // During boot , Virtual and Physical are same > + mNsCommBuffMemRegion.VirtualBase =3D > mNsCommBuffMemRegion.PhysicalBase; > + mNsCommBuffMemRegion.Length =3D PcdGet64 (PcdMmBufferSize); > + > + if (mNsCommBuffMemRegion.PhysicalBase =3D=3D 0) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Invalid MM Buffer Base Address.\n")); > + goto ReturnErrorStatus; > + } > + [Meenakshi Aggarwal] VirtualBase address assignment should be done after ch= ecking PhysicalBase. > + if (mNsCommBuffMemRegion.Length =3D=3D 0) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Maximum Buffer Size is zero.\n")); > + goto ReturnErrorStatus; > + } > + > + Status =3D gDS->AddMemorySpace (EfiGcdMemoryTypeSystemMemory, > + mNsCommBuffMemRegion.PhysicalBase, > + mNsCommBuffMemRegion.Length, > + EFI_MEMORY_WB | > + EFI_MEMORY_XP | > + EFI_MEMORY_RUNTIME); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Failed to add MM-NS Buffer Memory Space\n")); > + goto ReturnErrorStatus; [Meenakshi Aggarwal] no need of goto statement here, we can directly return= error as no cleanup is being performed under goto statement. > + } > + > + Status =3D gDS- > >SetMemorySpaceAttributes(mNsCommBuffMemRegion.PhysicalBase, [Meenakshi Aggarwal] space before opening bracket please > + mNsCommBuffMemRegion.Length, > + EFI_MEMORY_WB | EFI_MEMORY_XP); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Failed to set MM-NS Buffer Memory attributes\n")); > + goto CleanAddedMemorySpace; > + } > + > + Status =3D gBS->AllocatePages (AllocateAddress, > + EfiRuntimeServicesData, > + EFI_SIZE_TO_PAGES (mNsCommBuffMemRegion.L= ength), > + &mNsCommBuffMemRegion.PhysicalBase); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Failed to allocate MM-NS Buffer Memory Space\n")); > + goto CleanAddedMemorySpace; > + } > + > + // Install the communication protocol > + Status =3D gBS->InstallProtocolInterface (&mMmCommunicateHandle, > + &gEfiMmCommunicationProtocolGu= id, > + EFI_NATIVE_INTERFACE, > + &mMmCommunication); > + if (EFI_ERROR(Status)) { [Meenakshi Aggarwal] Space after EFI_ERROR please > + DEBUG ((DEBUG_ERROR, "MmCommunicationInitialize: " > + "Failed to install MM communication protocol\n")); > + goto CleanAllocatedPages; > + } > + > + // Register notification callback when virtual address is associated > + // with the physical address. > + // Create a Set Virtual Address Map event. > + // > + Status =3D gBS->CreateEvent (EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE, // > Type > + TPL_NOTIFY, // Noti= fyTpl > + NotifySetVirtualAddressMap, // Noti= fyFunction > + NULL, // Noti= fyContext > + &mSetVirtualAddressMapEvent // Even= t > + ); > + if (Status =3D=3D EFI_SUCCESS) { > + return Status; > + } > + > + gBS->UninstallProtocolInterface(mMmCommunicateHandle, > + &gEfiMmCommunicationProtocolGuid, > + &mMmCommunication); > + > +CleanAllocatedPages: > + gBS->FreePages (mNsCommBuffMemRegion.PhysicalBase, > + EFI_SIZE_TO_PAGES (mNsCommBuffMemRegion.Length)); > + > +CleanAddedMemorySpace: > + gDS->RemoveMemorySpace (mNsCommBuffMemRegion.PhysicalBase, > + mNsCommBuffMemRegion.Length); > + > +ReturnErrorStatus: > + return EFI_INVALID_PARAMETER; > +} > diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > new file mode 100644 > index 0000000000..d39ee5fdd7 > --- /dev/null > +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > @@ -0,0 +1,50 @@ > +#/** @file > +# > +# DXE MM Communicate driver > +# > +# Copyright (c) 2016 - 2017, ARM Limited. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the > BSD License > +# which accompanies this distribution. The full text of the license ma= y be > found at > +# > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fope > nsource.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C27ae12 > fc41414e501f8208d52ddb09f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C636465341155830632&sdata=3DGPd9o7ovyTU10etIxP%2BBYNsYUKq > m37tPcc%2BQDKtext4%3D&reserved=3D0 > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION =3D 0x0001001A > + BASE_NAME =3D ArmMmCommunication > + FILE_GUID =3D 09EE81D3-F15E-43F4-85B4-CB9873DA5D6= B > + MODULE_TYPE =3D DXE_RUNTIME_DRIVER > + VERSION_STRING =3D 1.0 > + > + ENTRY_POINT =3D MmCommunicationInitialize > + > +[Sources.Common] > + MmCommunication.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + ArmLib > + ArmSmcLib > + BaseMemoryLib > + DebugLib > + DxeServicesTableLib > + HobLib > + UefiDriverEntryPoint > + > +[Protocols] > + gEfiMmCommunicationProtocolGuid ## PRODUCES > + > +[Pcd.common] > + gArmTokenSpaceGuid.PcdMmBufferBase > + gArmTokenSpaceGuid.PcdMmBufferSize > + > +[Depex] > + TRUE > -- > 2.14.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist > s.01.org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C27ae12fc4141 > 4e501f8208d52ddb09f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% > 7C636465341155830632&sdata=3DpWv6hx1oHdtDyEnKx1HpyBnpmn7XikuwA85 > 8yu7148E%3D&reserved=3D0