From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.76; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0076.outbound.protection.outlook.com [104.47.0.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D74FB2268478C for ; Thu, 19 Apr 2018 03:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pkQEUnfMwwQ3bcfOKKcJdK6tENkJNcmAZG522QZZiRY=; b=mg2WvnWWkXHAu1eM4p8hKXiS5Come/rLreGZZG6ry+WZsKALfHaexLrtcfXHzrYCimDkMGmbu3ymqwwLM6psgs0aLdVmJViM9sYqk3kBawkgoayQigJnVQE7n58W+BM40R/c5pvjFZWMKmkswoWNMjdpd50gZlBnlCO9bPNHkTs= Received: from DB5PR04MB0998.eurprd04.prod.outlook.com (10.161.199.12) by DB5PR04MB1158.eurprd04.prod.outlook.com (10.162.155.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Thu, 19 Apr 2018 10:14:55 +0000 Received: from DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::18ce:390:67ab:40af]) by DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::18ce:390:67ab:40af%15]) with mapi id 15.20.0696.011; Thu, 19 Apr 2018 10:14:55 +0000 From: Meenakshi Aggarwal To: Leif Lindholm CC: "ard.biesheuvel@linaro.org" , "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi Thread-Topic: [PATCH edk2-platforms 17/39] LS1043 : Enable NOR driver for LS1043aRDB package. Thread-Index: AQHTpwOnbYBmsWOkykWZQx9OEMehfaQIOtsAgAAFKvA= Date: Thu, 19 Apr 2018 10:14:54 +0000 Message-ID: References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-18-git-send-email-meenakshi.aggarwal@nxp.com> <20180419095443.osycgsgn6nbpyi3k@bivouac.eciton.net> In-Reply-To: <20180419095443.osycgsgn6nbpyi3k@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR04MB1158; 7:8lN07xlNhgBPFVkHU+VqLlO/rQnJwYj58OqOpzBV29W33mIEGzhFoOBvB0AaUhfQSgX+9c+scOEWUNeQ7mur1FuLvvE4vjF+zNtjWRgCN/t6BD2HLa8SoV1VR3AQ2OKEaKpeYaqbruKIFlQ1mdY+NqTfnS6DXs/fN+s3FEl9UucjoFQKfmCVmaJQjqPHnUGoVmKHCVEXyx6xvS4eJDZXK4eAQY6hzyOBumlhiwY/FUQWId/kiss3g90zOMb9n7bJ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB5PR04MB1158; x-ms-traffictypediagnostic: DB5PR04MB1158: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231232)(944501327)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:DB5PR04MB1158; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB1158; x-forefront-prvs: 0647963F84 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(396003)(376002)(39380400002)(39860400002)(13464003)(6246003)(26005)(86362001)(575784001)(66066001)(186003)(5660300001)(4326008)(3660700001)(6116002)(3846002)(7736002)(476003)(305945005)(6436002)(2906002)(316002)(11346002)(446003)(3280700002)(54906003)(33656002)(5250100002)(53936002)(74316002)(9686003)(55016002)(76176011)(44832011)(59450400001)(2900100001)(7696005)(6916009)(81166006)(229853002)(8936002)(25786009)(8676002)(478600001)(55236004)(102836004)(6506007)(53546011)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1158; H:DB5PR04MB0998.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: FJl6kLGLQuCQRdk1Rw4pa6Q9Vy1xRxBHIwjQn7VFuN4Bx4yPOkBgcUsLl9PmsjEmq3/GLyVUwJy8nRrIHn1I4Y54rs7IDwHP/ixB+PJm4RguiPWS0NBBYEt8SY8omNvRV3Nb0+2HIDcTDF+OBDcwNTX3uf5IFfroDzH0aEUlciyvCOxNhNpVuR/sWvBlQER6 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 28ece2ca-9e90-47d8-f57e-08d5a5de65dc X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28ece2ca-9e90-47d8-f57e-08d5a5de65dc X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2018 10:14:54.3720 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1158 Subject: Re: [PATCH edk2-platforms 17/39] LS1043 : Enable NOR driver for LS1043aRDB package. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 10:14:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Yes, it needs changes corresponding to commit 6281a2ed3bb3ffe57ed54cabd9a31= dcf13b415f8. > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, April 19, 2018 3:25 PM > To: Meenakshi Aggarwal > Cc: ard.biesheuvel@linaro.org; edk2-devel@lists.01.org; Udit Kumar > ; Varun Sethi > Subject: Re: [PATCH edk2-platforms 17/39] LS1043 : Enable NOR driver for > LS1043aRDB package. >=20 > On Fri, Feb 16, 2018 at 02:20:13PM +0530, Meenakshi wrote: > > From: Meenakshi Aggarwal > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Meenakshi Aggarwal >=20 > Will this one require any changes to build (and work correctly) > against current edk2? >=20 > If not: > Reviewed-by: Leif Lindholm >=20 > / > Leif >=20 > > --- > > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 16 > +++++++++++++++- > > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 9 ++++++++- > > 2 files changed, 23 insertions(+), 2 deletions(-) > > > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > index df4d917..7708e0a 100644 > > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > @@ -41,6 +41,7 @@ > > IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > > BoardLib|Platform/NXP/LS1043aRdbPkg/Library/BoardLib/BoardLib.inf > > FpgaLib|Platform/NXP/LS1043aRdbPkg/Library/FpgaLib/FpgaLib.inf > > + NorFlashLib|Silicon/NXP/Library/NorFlashLib/NorFlashLib.inf > > > > [PcdsFixedAtBuild.common] > > > > @@ -70,6 +71,13 @@ > > gDs1307RtcLibTokenSpaceGuid.PcdI2cSlaveAddress|0x68 > > gDs1307RtcLibTokenSpaceGuid.PcdI2cBusFrequency|100000 > > > > + # > > + # NV Storage PCDs. > > + # > > + gArmTokenSpaceGuid.PcdVFPEnabled|1 > > + gNxpQoriqLsTokenSpaceGuid.PcdFlashDeviceBase64|0x060000000 > > + > gNxpQoriqLsTokenSpaceGuid.PcdFlashReservedRegionBase64|0x60300000 > > + > > > ########################################################## > ###################### > > # > > # Components Section - list of all EDK II Modules needed by this Platf= orm > > @@ -79,9 +87,15 @@ > > # > > # Architectural Protocols > > # > > - > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntime > Dxe.inf > > + > > + > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf{ > > + > > + NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > > + } > > + > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.in > f > > > > Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf > > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > > + Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > > > ## > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > index fa6510c..6b5b63f 100644 > > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > @@ -55,6 +55,7 @@ > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > FV =3D FVMAIN_COMPACT > > > > !include ../FVRules.fdf.inc > > +!include VarStore.fdf.inc > > > ########################################################## > ###################### > > # > > # FV Section > > @@ -103,7 +104,8 @@ READ_LOCK_STATUS =3D TRUE > > INF > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > INF > EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter > .inf > > - INF > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntime > Dxe.inf > > + INF > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > > + INF > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.in > f > > INF > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntime > Dxe.inf > > > > INF Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > > @@ -123,6 +125,11 @@ READ_LOCK_STATUS =3D TRUE > > INF EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf > > > > # > > + # NOR Driver > > + # > > + INF Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > + > > + # > > # Network modules > > # > > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > > -- > > 1.9.1 > >