From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Carsey, Jaben" <jaben.carsey@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Ye, Ting" <ting.ye@intel.com>
Subject: Re: [PATCH v2] TFTP : tftp fix for full volume case
Date: Tue, 10 Oct 2017 13:54:23 +0000 [thread overview]
Message-ID: <DB5PR04MB099813B203876C2FACD4186D8E750@DB5PR04MB0998.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA8BD5A@SHSMSX104.ccr.corp.intel.com>
Hi,
Kindly apply this patch on edk2 if all reviews are done.
Thanks & Regards,
Meenakshi
> -----Original Message-----
> From: Ni, Ruiyu [mailto:ruiyu.ni@intel.com]
> Sent: Tuesday, October 10, 2017 10:52 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; Fu, Siyuan <siyuan.fu@intel.com>; edk2-
> devel@lists.01.org; Ye, Ting <ting.ye@intel.com>
> Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>
> Thanks/Ray
>
> > -----Original Message-----
> > From: Carsey, Jaben
> > Sent: Monday, October 9, 2017 10:13 PM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Fu, Siyuan
> > <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni, Ruiyu
> > <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>
> > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> >
> > I am fine. Ray?
> >
> > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > > Of Meenakshi Aggarwal
> > > Sent: Sunday, October 08, 2017 11:28 PM
> > > To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni,
> > > Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> > > Ye, Ting <ting.ye@intel.com>
> > > Subject: Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case
> > > Importance: High
> > >
> > > Hi Team,
> > >
> > >
> > > Any further comments on this patch?
> > >
> > > Or is it ready to merge in edk2?
> > >
> > >
> > > Thanks,
> > > Meenakshi
> > >
> > > > -----Original Message-----
> > > > From: Meenakshi Aggarwal
> > > > Sent: Wednesday, September 27, 2017 9:01 AM
> > > > To: 'Fu, Siyuan' <siyuan.fu@intel.com>; edk2-devel@lists.01.org;
> > > > Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > > > <jaben.carsey@intel.com>; Ye, Ting <ting.ye@intel.com>
> > > > Cc: Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma
> > > > <vabhav.sharma@nxp.com>
> > > > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> > > >
> > > > Hi,
> > > >
> > > > Thanks for the review Siyuan.
> > > >
> > > >
> > > > Ting,
> > > >
> > > > Any comment from your side?
> > > >
> > > > Thanks,
> > > > Meenakshi
> > > >
> > > > > -----Original Message-----
> > > > > From: Fu, Siyuan [mailto:siyuan.fu@intel.com]
> > > > > Sent: Tuesday, September 26, 2017 6:12 AM
> > > > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > > > > devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey,
> > > > > Jaben <jaben.carsey@intel.com>
> > > > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Ye,
> > > > > Ting <ting.ye@intel.com>; Udit Kumar <udit.kumar@nxp.com>;
> > > > > Vabhav
> > > Sharma
> > > > > <vabhav.sharma@nxp.com>
> > > > > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> > > > >
> > > > > Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> > > > >
> > > > > -----Original Message-----
> > > > > From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> > > > > Sent: Monday, September 25, 2017 11:06 PM
> > > > > To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>;
> > > > > Carsey, Jaben <jaben.carsey@intel.com>
> > > > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Fu,
> > > > > Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>;
> > > > > Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Udit Kumar
> > > > > <udit.kumar@nxp.com>; Vabhav Sharma
> <vabhav.sharma@nxp.com>
> > > > > Subject: [PATCH v2] TFTP : tftp fix for full volume case
> > > > >
> > > > > Issue :
> > > > > When storage media is full, tftp was resulting in ASSERT
> > > > > MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages
> was
> > > > zero.
> > > > >
> > > > > Reason:
> > > > > While doing tftp, function call ShellWriteFile was modifying
> > > > > FileSize
> > > variable.
> > > > > In case of full disk it was coming out to be Zero.
> > > > >
> > > > > Fix:
> > > > > Storage the original filesize in local variable, and use this
> > > > > variable while freeing the pages.
> > > > >
> > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > > Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
> > > > > Signed-off-by: Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>
> > > > > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > > > Signed-off-by: Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>
> > > > > ---
> > > > > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
> > > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > index 5c50797..fbde3bf 100755
> > > > > --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > @@ -284,6 +284,7 @@ ShellCommandRunTftp (
> > > > > EFI_HANDLE Mtftp4ChildHandle;
> > > > > EFI_MTFTP4_PROTOCOL *Mtftp4;
> > > > > UINTN FileSize;
> > > > > + UINTN DataSize;
> > > > > VOID *Data;
> > > > > SHELL_FILE_HANDLE FileHandle;
> > > > > UINT16 BlockSize;
> > > > > @@ -294,6 +295,7 @@ ShellCommandRunTftp (
> > > > > AsciiRemoteFilePath = NULL;
> > > > > Handles = NULL;
> > > > > FileSize = 0;
> > > > > + DataSize = 0;
> > > > > BlockSize = MTFTP_DEFAULT_BLKSIZE;
> > > > >
> > > > > //
> > > > > @@ -537,6 +539,7 @@ ShellCommandRunTftp (
> > > > > goto NextHandle;
> > > > > }
> > > > >
> > > > > + DataSize = FileSize;
> > > > > Status = ShellWriteFile (FileHandle, &FileSize, Data);
> > > > > if (!EFI_ERROR (Status)) {
> > > > > ShellStatus = SHELL_SUCCESS; @@ -551,7 +554,7 @@
> > > > > ShellCommandRunTftp (
> > > > > NextHandle:
> > > > >
> > > > > if (Data != NULL) {
> > > > > - gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > > > EFI_SIZE_TO_PAGES (FileSize));
> > > > > + gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > > > + EFI_SIZE_TO_PAGES (DataSize));
> > > > > }
> > > > >
> > > > > CloseProtocolAndDestroyServiceChild (
> > > > > --
> > > > > 1.9.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-10-10 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 14:37 [PATCH] TFTP : tftp fix for full volume case Meenakshi Aggarwal
2017-09-25 9:00 ` Ni, Ruiyu
2017-09-25 15:06 ` [PATCH v2] " Meenakshi Aggarwal
2017-09-26 0:42 ` Fu, Siyuan
2017-09-27 3:31 ` Meenakshi Aggarwal
2017-10-09 6:28 ` Meenakshi Aggarwal
2017-10-09 14:13 ` Carsey, Jaben
2017-10-10 5:22 ` Ni, Ruiyu
2017-10-10 13:54 ` Meenakshi Aggarwal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR04MB099813B203876C2FACD4186D8E750@DB5PR04MB0998.eurprd04.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox