Re: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro.

[Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>]

Hi Leif,

Yes, I agree to contribute under TianoCore Contribution Agreement 1.1

Thanks,
Meenakshi

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Thursday, September 07, 2017 8:07 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: jun.nie@linaro.org; haojian.zhuang@linaro.org; edk2-devel@lists.01.org
> Subject: Re: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro.
> 
> On Thu, Sep 07, 2017 at 07:47:52PM +0530, Meenakshi Aggarwal wrote:
> > We want to print name of the function resulted in error, but
> > __FUNCTION__ macro was missing.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> 
> Like for 2/2, you appear to have left out edk2-devel@lists.01.org in this
> submission (added).
> 
> Like for 2/2, happy to push this if you can confirm you are contributing under
> TianoCore Contribution Agreement 1.1.
> 
> /
>     Leif
> 
> > ---
> >  EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 14 +++++++-----
> --
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> > b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> > index 7f74c54..27e4444 100644
> > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> > @@ -388,12 +388,12 @@ InitializeSdMmcDevice (
> >
> >    Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg);
> >    if (EFI_ERROR (Status)) {
> > -    DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n",
> Status));
> > +    DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = %r\n",
> > + __FUNCTION__, Status));
> >      return Status;
> >    }
> >    Status = MmcHost->ReceiveResponse (MmcHost,
> MMC_RESPONSE_TYPE_R1, Response);
> >    if (EFI_ERROR (Status)) {
> > -    DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n",
> Status));
> > +    DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = %r\n",
> > + __FUNCTION__, Status));
> >      return Status;
> >    }
> >    if ((Response[0] & MMC_STATUS_APP_CMD) == 0) { @@ -445,12 +445,12
> > @@ InitializeSdMmcDevice (
> >      CmdArg |= 1 << (0 * 4);
> >      Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, CmdArg);
> >      if (EFI_ERROR (Status)) {
> > -      DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n",
> Status));
> > +      DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status = %r\n",
> > + __FUNCTION__, Status));
> >         return Status;
> >      } else {
> >        Status = MmcHost->ReadBlockData (MmcHost, 0, 64, Buffer);
> >        if (EFI_ERROR (Status)) {
> > -        DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): ReadBlockData Error and
> Status = %r\n", Status));
> > +        DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): ReadBlockData Error
> and
> > + Status = %r\n", __FUNCTION__, Status));
> >          return Status;
> >        }
> >      }
> > @@ -459,20 +459,20 @@ InitializeSdMmcDevice (
> >      CmdArg = MmcHostInstance->CardInfo.RCA << 16;
> >      Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg);
> >      if (EFI_ERROR (Status)) {
> > -      DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n",
> Status));
> > +      DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status =
> %r\n",
> > + __FUNCTION__, Status));
> >        return Status;
> >      }
> >      /* Width: 4 */
> >      Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, 2);
> >      if (EFI_ERROR (Status)) {
> > -      DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n",
> Status));
> > +      DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status = %r\n",
> > + __FUNCTION__, Status));
> >        return Status;
> >      }
> >    }
> >    if (MMC_HOST_HAS_SETIOS(MmcHost)) {
> >      Status = MmcHost->SetIos (MmcHost, 26 * 1000 * 1000, 4,
> EMMCBACKWARD);
> >      if (EFI_ERROR (Status)) {
> > -      DEBUG ((EFI_D_ERROR, "%a(SetIos): Error and Status = %r\n", Status));
> > +      DEBUG ((DEBUG_ERROR, "%a (SetIos): Error and Status = %r\n",
> > + __FUNCTION__, Status));
> >        return Status;
> >      }
> >    }
> > --
> > 1.9.1
> >