From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10056.outbound.protection.outlook.com [40.107.1.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B22E421CEB102 for ; Thu, 7 Sep 2017 08:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vStkJ2qyktKIOSBXFkztkKyo9UEctH2rPSPZNiVZmM4=; b=xdiV9mC5tZTliLTOIdttc1NfwRRmhu6RnGjdWiaiTdgU72hGxxvgGG/rMV8hwnpWO6Rcub2MCtTrC+RNxd/kASmZWF17DFnq5a0ai0x51ZR8lGF9KiDbh0BeljHbI769j0XlGaQG1W9j1X9FIpfsMOWXdGI52iPNOJKN0xPtRJs= Received: from DB5PR04MB0998.eurprd04.prod.outlook.com (10.161.199.12) by DB5PR04MB2168.eurprd04.prod.outlook.com (10.166.172.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Thu, 7 Sep 2017 15:19:34 +0000 Received: from DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::b598:82e9:1137:1d56]) by DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::b598:82e9:1137:1d56%17]) with mapi id 15.20.0013.018; Thu, 7 Sep 2017 15:19:34 +0000 From: Meenakshi Aggarwal To: Leif Lindholm CC: "jun.nie@linaro.org" , "haojian.zhuang@linaro.org" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro. Thread-Index: AQHTJ7NrVDTImc2mRECXCQW1RVMha6KpfggAgAAL8nA= Date: Thu, 7 Sep 2017 15:19:34 +0000 Message-ID: References: <1504793873-13078-1-git-send-email-meenakshi.aggarwal@nxp.com> <20170907143640.skmrf57m62iq5sti@bivouac.eciton.net> In-Reply-To: <20170907143640.skmrf57m62iq5sti@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meenakshi.aggarwal@nxp.com; x-originating-ip: [180.188.246.193] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR04MB2168; 6:gf75vl4dzixyBE/8vx9k/v+1KXHRGCQgD85i06BezkAhEne9VqQr9XmMcV413sLGt25gwc4nGk7l1VqbbIL8pvrEVydjsHHqFYfI8vhYu43tE3jHWMZddgvNvUGWio7ftaUFm9qyafryizdhfw/j+PLrlBO7ftHVDHq0GGSW5FA0JoxRwVzfe7HWM3oxHeNiegYo5mGFc11vRLvjnRK5PrHfrULhB1N8ON86EFJ2vhZhPxE6N9eE8/dCg0L2JJH11eSWSswI+zSqOHB8OaVlhkaadL5UDU7lzSMzTB6ZF6NDsdilaTwDPFxNx+yZIpl36Sz2eA31UbmI+ygCjZddFA==; 5:WixVtYkZruWIJvfJS6H1dLEjWy6B1e5cFxmFokvMzianT3/ZNdKrS7+wFIqelTRYFBJ0h1P7DcH9ultemXxZwhzFz77viz3FqvC1cHmfzAA3Po82iVjwvlFUVD5XcbyMdBUf8h9D2/A1kgEr2z/1mA==; 24:81IE60P39UOgvyN3+oVmX17EhZN7cxlZDnX1sBNDMdcl2mLNgjlzw5NNpFXOIrNZMytw1v1gRpAZ+W4Vf7bPJ1i7Z1MzJ2jhVf7WlYv6mqw=; 7:0FiSlgnT/dPleeD9mpmwgTM+XGPNFf1nrE28h0oF+MvaCLo3L9WB9j+9KSrbw3Wy9hqDVElcC/fNhyi4kID9lvHYYugh+nVMtJBlqTMi4XL7m017MorQFKZFUmkJ8BHwDhqZngyWN8O9cOJxd3rF23vb+kYy9q7E4Xor11D/2w7GNoZemXN2XihZKdsQKWjuSqC9hkRdIXxn/k0i9GIMnQcgrFpC5fre1TF4b1neB1w= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 8c3a68fb-6dc1-45f0-acc2-08d4f603d8d1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB5PR04MB2168; x-ms-traffictypediagnostic: DB5PR04MB2168: x-exchange-antispam-report-test: UriScan:(185117386973197)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB5PR04MB2168; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB5PR04MB2168; x-forefront-prvs: 04238CD941 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(13464003)(199003)(24454002)(377454003)(189002)(189998001)(3280700002)(110136004)(3660700001)(74316002)(6506006)(5250100002)(86362001)(2906002)(478600001)(6116002)(3846002)(102836003)(5660300001)(2900100001)(66066001)(7696004)(6916009)(81166006)(25786009)(7736002)(305945005)(8936002)(97736004)(2950100002)(53936002)(53546010)(54356999)(50986999)(76176999)(8676002)(101416001)(81156014)(33656002)(14454004)(6436002)(6246003)(4326008)(54906002)(229853002)(105586002)(9686003)(68736007)(106356001)(99286003)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB2168; H:DB5PR04MB0998.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2017 15:19:34.8412 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB2168 Subject: Re: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 15:16:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Yes, I agree to contribute under TianoCore Contribution Agreement 1.1 Thanks, Meenakshi > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, September 07, 2017 8:07 PM > To: Meenakshi Aggarwal > Cc: jun.nie@linaro.org; haojian.zhuang@linaro.org; edk2-devel@lists.01.or= g > Subject: Re: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro. >=20 > On Thu, Sep 07, 2017 at 07:47:52PM +0530, Meenakshi Aggarwal wrote: > > We want to print name of the function resulted in error, but > > __FUNCTION__ macro was missing. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Meenakshi Aggarwal >=20 > Like for 2/2, you appear to have left out edk2-devel@lists.01.org in this > submission (added). >=20 > Like for 2/2, happy to push this if you can confirm you are contributing = under > TianoCore Contribution Agreement 1.1. >=20 > / > Leif >=20 > > --- > > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 14 +++++++----- > -- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > index 7f74c54..27e4444 100644 > > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > @@ -388,12 +388,12 @@ InitializeSdMmcDevice ( > > > > Status =3D MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status =3D %r\n", > Status)); > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status =3D %r\n", > > + __FUNCTION__, Status)); > > return Status; > > } > > Status =3D MmcHost->ReceiveResponse (MmcHost, > MMC_RESPONSE_TYPE_R1, Response); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status =3D %r\n", > Status)); > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status =3D %r\n", > > + __FUNCTION__, Status)); > > return Status; > > } > > if ((Response[0] & MMC_STATUS_APP_CMD) =3D=3D 0) { @@ -445,12 +445,1= 2 > > @@ InitializeSdMmcDevice ( > > CmdArg |=3D 1 << (0 * 4); > > Status =3D MmcHost->SendCommand (MmcHost, MMC_CMD6, CmdArg); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status =3D %r\n", > Status)); > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status =3D %r\n", > > + __FUNCTION__, Status)); > > return Status; > > } else { > > Status =3D MmcHost->ReadBlockData (MmcHost, 0, 64, Buffer); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): ReadBlockData Error and > Status =3D %r\n", Status)); > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): ReadBlockData Error > and > > + Status =3D %r\n", __FUNCTION__, Status)); > > return Status; > > } > > } > > @@ -459,20 +459,20 @@ InitializeSdMmcDevice ( > > CmdArg =3D MmcHostInstance->CardInfo.RCA << 16; > > Status =3D MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status =3D %r\n", > Status)); > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status =3D > %r\n", > > + __FUNCTION__, Status)); > > return Status; > > } > > /* Width: 4 */ > > Status =3D MmcHost->SendCommand (MmcHost, MMC_CMD6, 2); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status =3D %r\n", > Status)); > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status =3D %r\n", > > + __FUNCTION__, Status)); > > return Status; > > } > > } > > if (MMC_HOST_HAS_SETIOS(MmcHost)) { > > Status =3D MmcHost->SetIos (MmcHost, 26 * 1000 * 1000, 4, > EMMCBACKWARD); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "%a(SetIos): Error and Status =3D %r\n", St= atus)); > > + DEBUG ((DEBUG_ERROR, "%a (SetIos): Error and Status =3D %r\n", > > + __FUNCTION__, Status)); > > return Status; > > } > > } > > -- > > 1.9.1 > >