Re: [PATCH] RFC : Ping : Fix for loss of first ping packet

Re: [PATCH] RFC : Ping : Fix for loss of first ping packet

[Meenakshi Aggarwal]

Hi,

Any comment?

Thanks & Regards,
Meenakshi

> -----Original Message-----
> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> Sent: Tuesday, February 13, 2018 8:52 PM
> To: ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org
> Cc: Udit Kumar <udit.kumar@nxp.com>; Varun Sethi <V.Sethi@nxp.com>;
> Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Subject: [PATCH] RFC : Ping : Fix for loss of first ping packet
> 
> Issue:
> Reply for first ping packet was getting dropped.
> 
> Cause:
> Sometimes reply message comes even before trasmit
> function returns, hence missing 1st reply
> 
> Fix:
> Prepare the TxList before calling Transmit function.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> index bec9535..46ba701 100644
> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>    }
> 
>    ASSERT(Private->ProtocolPointers.Transmit != NULL);
> +
> +  InsertTailList (&Private->TxList, &TxInfo->Link);
> +
>    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> >Token);
> 
>    if (EFI_ERROR (Status)) {
> +    RemoveEntryList (&TxInfo->Link);
>      PingDestroyTxInfo (TxInfo, Private->IpChoice);
>      return Status;
>    }
> 
> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>    Private->TxCount++;
> 
>    return EFI_SUCCESS;
> --
> 1.9.1

Re: [PATCH] RFC : Ping : Fix for loss of first ping packet

[Laszlo Ersek]

Hi Meenakshi,

On 02/15/18 13:08, Meenakshi Aggarwal wrote:
> Hi,
> 
> Any comment?

I don't see your original patch email on the list, either in my personal
folder, or in the archive at
<https://lists.01.org/pipermail/edk2-devel/2018-February/thread.html>.
Can you resend?

Also, I suggest a subject line like:

  [RFC] ShellPkg/Ping: fix loss of first packet

In other words, "RFC" should only be in the bracketed part (= the
subject prefix). You can change the [PATCH] prefix into [RFC] by adding

  --subject-prefix=RFC

to the git-format-patch command line.

Thanks
Laszlo

>> -----Original Message-----
>> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
>> Sent: Tuesday, February 13, 2018 8:52 PM
>> To: ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org
>> Cc: Udit Kumar <udit.kumar@nxp.com>; Varun Sethi <V.Sethi@nxp.com>;
>> Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>> Subject: [PATCH] RFC : Ping : Fix for loss of first ping packet
>>
>> Issue:
>> Reply for first ping packet was getting dropped.
>>
>> Cause:
>> Sometimes reply message comes even before trasmit
>> function returns, hence missing 1st reply
>>
>> Fix:
>> Prepare the TxList before calling Transmit function.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>> ---
>>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> index bec9535..46ba701 100644
>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>>    }
>>
>>    ASSERT(Private->ProtocolPointers.Transmit != NULL);
>> +
>> +  InsertTailList (&Private->TxList, &TxInfo->Link);
>> +
>>    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
>>> Token);
>>
>>    if (EFI_ERROR (Status)) {
>> +    RemoveEntryList (&TxInfo->Link);
>>      PingDestroyTxInfo (TxInfo, Private->IpChoice);
>>      return Status;
>>    }
>>
>> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>>    Private->TxCount++;
>>
>>    return EFI_SUCCESS;
>> --
>> 1.9.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 

Re: [PATCH] RFC : Ping : Fix for loss of first ping packet

[Meenakshi Aggarwal]

Hi,

I have shared patch with correction in subject.

Please see if it is visible to you now.


Thanks,
Meenakshi

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, February 15, 2018 5:59 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>;
> ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] RFC : Ping : Fix for loss of first ping packet
> 
> Hi Meenakshi,
> 
> On 02/15/18 13:08, Meenakshi Aggarwal wrote:
> > Hi,
> >
> > Any comment?
> 
> I don't see your original patch email on the list, either in my personal
> folder, or in the archive at
> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
> ts.01.org%2Fpipermail%2Fedk2-devel%2F2018-
> February%2Fthread.html&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.co
> m%7Cd55e68d82714417526e008d5746faad4%7Cbd8a2a2207224ec7b35f1c4f0
> 497e341%7C0%7C0%7C636542945322839311&sdata=OyrBgmxscmLtSjkhrcglD
> A%2BYAPH77IbycKEql759m1s%3D&reserved=0>.
> Can you resend?
> 
> Also, I suggest a subject line like:
> 
>   [RFC] ShellPkg/Ping: fix loss of first packet
> 
> In other words, "RFC" should only be in the bracketed part (= the
> subject prefix). You can change the [PATCH] prefix into [RFC] by adding
> 
>   --subject-prefix=RFC
> 
> to the git-format-patch command line.
> 
> Thanks
> Laszlo
> 
> >> -----Original Message-----
> >> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> >> Sent: Tuesday, February 13, 2018 8:52 PM
> >> To: ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org
> >> Cc: Udit Kumar <udit.kumar@nxp.com>; Varun Sethi
> <V.Sethi@nxp.com>;
> >> Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >> Subject: [PATCH] RFC : Ping : Fix for loss of first ping packet
> >>
> >> Issue:
> >> Reply for first ping packet was getting dropped.
> >>
> >> Cause:
> >> Sometimes reply message comes even before trasmit
> >> function returns, hence missing 1st reply
> >>
> >> Fix:
> >> Prepare the TxList before calling Transmit function.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >> ---
> >>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >> index bec9535..46ba701 100644
> >> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >> @@ -784,14 +784,17 @@ PingSendEchoRequest (
> >>    }
> >>
> >>    ASSERT(Private->ProtocolPointers.Transmit != NULL);
> >> +
> >> +  InsertTailList (&Private->TxList, &TxInfo->Link);
> >> +
> >>    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
> TxInfo-
> >>> Token);
> >>
> >>    if (EFI_ERROR (Status)) {
> >> +    RemoveEntryList (&TxInfo->Link);
> >>      PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >>      return Status;
> >>    }
> >>
> >> -  InsertTailList (&Private->TxList, &TxInfo->Link);
> >>    Private->TxCount++;
> >>
> >>    return EFI_SUCCESS;
> >> --
> >> 1.9.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7Cd55e68d8271
> 4417526e008d5746faad4%7Cbd8a2a2207224ec7b35f1c4f0497e341%7C0%7C0
> %7C636542945322839311&sdata=zCc8J582i3pSgXHDKvF3SJTJ7Z0mPAq1VenJ6
> WeoNqQ%3D&reserved=0
> >

Re: [PATCH] RFC : Ping : Fix for loss of first ping packet

[Laszlo Ersek]

On 02/16/18 06:45, Meenakshi Aggarwal wrote:
> Hi,
> 
> I have shared patch with correction in subject.
> 
> Please see if it is visible to you now.

Yes, the new patch seems well-formed and it is on the list. I'll let the
ShellPkg maintainers review it. Thanks!

Laszlo

>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Thursday, February 15, 2018 5:59 PM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>;
>> ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org
>> Subject: Re: [edk2] [PATCH] RFC : Ping : Fix for loss of first ping packet
>>
>> Hi Meenakshi,
>>
>> On 02/15/18 13:08, Meenakshi Aggarwal wrote:
>>> Hi,
>>>
>>> Any comment?
>>
>> I don't see your original patch email on the list, either in my personal
>> folder, or in the archive at
>> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
>> ts.01.org%2Fpipermail%2Fedk2-devel%2F2018-
>> February%2Fthread.html&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.co
>> m%7Cd55e68d82714417526e008d5746faad4%7Cbd8a2a2207224ec7b35f1c4f0
>> 497e341%7C0%7C0%7C636542945322839311&sdata=OyrBgmxscmLtSjkhrcglD
>> A%2BYAPH77IbycKEql759m1s%3D&reserved=0>.
>> Can you resend?
>>
>> Also, I suggest a subject line like:
>>
>>   [RFC] ShellPkg/Ping: fix loss of first packet
>>
>> In other words, "RFC" should only be in the bracketed part (= the
>> subject prefix). You can change the [PATCH] prefix into [RFC] by adding
>>
>>   --subject-prefix=RFC
>>
>> to the git-format-patch command line.
>>
>> Thanks
>> Laszlo
>>
>>>> -----Original Message-----
>>>> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
>>>> Sent: Tuesday, February 13, 2018 8:52 PM
>>>> To: ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org
>>>> Cc: Udit Kumar <udit.kumar@nxp.com>; Varun Sethi
>> <V.Sethi@nxp.com>;
>>>> Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>> Subject: [PATCH] RFC : Ping : Fix for loss of first ping packet
>>>>
>>>> Issue:
>>>> Reply for first ping packet was getting dropped.
>>>>
>>>> Cause:
>>>> Sometimes reply message comes even before trasmit
>>>> function returns, hence missing 1st reply
>>>>
>>>> Fix:
>>>> Prepare the TxList before calling Transmit function.
>>>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>> ---
>>>>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>> index bec9535..46ba701 100644
>>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>>>>    }
>>>>
>>>>    ASSERT(Private->ProtocolPointers.Transmit != NULL);
>>>> +
>>>> +  InsertTailList (&Private->TxList, &TxInfo->Link);
>>>> +
>>>>    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
>> TxInfo-
>>>>> Token);
>>>>
>>>>    if (EFI_ERROR (Status)) {
>>>> +    RemoveEntryList (&TxInfo->Link);
>>>>      PingDestroyTxInfo (TxInfo, Private->IpChoice);
>>>>      return Status;
>>>>    }
>>>>
>>>> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>>>>    Private->TxCount++;
>>>>
>>>>    return EFI_SUCCESS;
>>>> --
>>>> 1.9.1
>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
>> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
>> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7Cd55e68d8271
>> 4417526e008d5746faad4%7Cbd8a2a2207224ec7b35f1c4f0497e341%7C0%7C0
>> %7C636542945322839311&sdata=zCc8J582i3pSgXHDKvF3SJTJ7Z0mPAq1VenJ6
>> WeoNqQ%3D&reserved=0
>>>
>