From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: Void lookup limit of 2 exceeded) identity=mailfrom; client-ip=2a01:111:f400:fe1e::61d; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on061d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::61d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D5C6322637DF5 for ; Thu, 19 Apr 2018 05:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Tq0NmpKKRH3N+lovco63uhURQvuS+WZ90bVbQWZ5Q38=; b=TR2Av2mFuLpSfEsWUymvXw+JMyD8y6HDy7G8PKSF2pXpvMP4AtC6s89mjn5bs4isAJm6vfm81mY3/Rc8QFgMKOiUa2awf90uoE3jfX76x3TJsu8oUIZSZhI8LfkACuskFCtOUNkIkGsW4mSMCmBhoRKYL95ccf40rX+raV2q3vI= Received: from DB5PR04MB0998.eurprd04.prod.outlook.com (10.161.199.12) by DB5PR04MB1253.eurprd04.prod.outlook.com (10.162.156.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Thu, 19 Apr 2018 12:33:51 +0000 Received: from DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::18ce:390:67ab:40af]) by DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::18ce:390:67ab:40af%15]) with mapi id 15.20.0696.011; Thu, 19 Apr 2018 12:33:51 +0000 From: Meenakshi Aggarwal To: Leif Lindholm CC: "ard.biesheuvel@linaro.org" , "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi , Vabhav Sharma Thread-Topic: [PATCH edk2-platforms 19/39] Silicon/NXP:Add support for PCF2129 Real Time Clock Library Thread-Index: AQHT18bdIGQBfHfcgEKKRtqHPkENNKQIBK7Q Date: Thu, 19 Apr 2018 12:33:50 +0000 Message-ID: References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-20-git-send-email-meenakshi.aggarwal@nxp.com> <20180419101156.6biaqkoduoczfjgp@bivouac.eciton.net> In-Reply-To: <20180419101156.6biaqkoduoczfjgp@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR04MB1253; 7:bVo5L2PuwHIJlR2gM0VwT5TP4bBQrJU48q5e+vozCz6MYoy4J1fS5UUKZ9W3yLLlVjo8+RZk9ALOfUlqyoNykOaciUAi4qhICOmPpMWYOqdFmx+NAF6OsN5fawxsOcT/BiLHPAQwacKTUoI+OVA4a1OPHSMphJsI/KInt+aBEXetrwuXY/vkoCg5+o55oQaqkqT53752yvWUo058gp/LytNOJgUwor17MoTw+kYfQ12399C3hAtWHwi9OZcbjFXe x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB5PR04MB1253; x-ms-traffictypediagnostic: DB5PR04MB1253: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(185117386973197)(788757137089)(162533806227266)(45079756050767); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231232)(944501327)(52105095)(10201501046)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DB5PR04MB1253; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB1253; x-forefront-prvs: 0647963F84 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39380400002)(376002)(346002)(39860400002)(13464003)(5250100002)(5660300001)(6506007)(54906003)(59450400001)(6116002)(3846002)(6436002)(33656002)(316002)(3660700001)(74316002)(305945005)(53546011)(2906002)(3280700002)(102836004)(8936002)(66066001)(55236004)(7696005)(81166006)(26005)(7736002)(8676002)(6916009)(16799955002)(76176011)(53936002)(45080400002)(476003)(6306002)(446003)(53946003)(966005)(4326008)(478600001)(86362001)(186003)(2900100001)(44832011)(55016002)(11346002)(9686003)(229853002)(25786009)(6246003)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1253; H:DB5PR04MB0998.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: 2+m6vHvaai3QBxy1hQoLEZ/NHOuPQK8DHm8R3BHCeLug4Yox6w+/I3sR6yhwnBBR31fwdkKrkTT1nJxH/dYYW+4vzHed79FT9AvXVAQqktZ1skfLcCB4B+IxyFGQATpAh+uSyegiY3I4Cq2wq2Kvoo1cnCI9BRjSF542x1bSYdanfJocr0i/tLVdmzfEc0G7 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 481677fb-78f1-4caa-540b-08d5a5f1ce9a X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 481677fb-78f1-4caa-540b-08d5a5f1ce9a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2018 12:33:51.0183 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1253 Subject: Re: [PATCH edk2-platforms 19/39] Silicon/NXP:Add support for PCF2129 Real Time Clock Library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 12:33:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, April 19, 2018 3:42 PM > To: Meenakshi Aggarwal > Cc: ard.biesheuvel@linaro.org; edk2-devel@lists.01.org; Udit Kumar > ; Varun Sethi ; Vabhav Sharma > > Subject: Re: [PATCH edk2-platforms 19/39] Silicon/NXP:Add support for > PCF2129 Real Time Clock Library >=20 > On Fri, Feb 16, 2018 at 02:20:15PM +0530, Meenakshi wrote: > > From: Vabhav > > > > Library to provide functions for NXP pcf2129 real time clock library > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Vabhav > > --- > > Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129Rtc.h | 43 +++ > > Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.c | 330 > +++++++++++++++++++++ > > .../NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.inf | 47 +++ > > 3 files changed, 420 insertions(+) > > create mode 100644 Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129Rtc.h > > create mode 100644 Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.c > > create mode 100644 Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.inf > > > > diff --git a/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129Rtc.h > b/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129Rtc.h > > new file mode 100644 > > index 0000000..735f697 > > --- /dev/null > > +++ b/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129Rtc.h > > @@ -0,0 +1,43 @@ > > +/** Pcf2129Rtc.h > > +* > > +* Copyright 2017 NXP > > +* > > +* This program and the accompanying materials > > +* are licensed and made available under the terms and conditions of t= he > BSD License > > +* which accompanies this distribution. The full text of the license = may be > found at > > +* > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fope > nsource.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7Cac3a81 > 31870a4f555cbc08d5a5ddfdc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C636597295251146941&sdata=3DWheF7lR6B7iBUJBG2TGfGzJoiVhO%2F > I1VZywt3l%2FeXug%3D&reserved=3D0 > > +* > > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > > +* > > +**/ > > + > > +#ifndef __PCF2129RTC_H__ > > +#define __PCF2129RTC_H__ > > + > > +/* > > + * RTC register addresses > > + */ > > +#define PCF2129_CTRL1_REG_ADDR 0x00 // Control Register 1 > > +#define PCF2129_CTRL2_REG_ADDR 0x01 // Control Register 2 > > +#define PCF2129_CTRL3_REG_ADDR 0x02 // Control Register 3 > > +#define PCF2129_SEC_REG_ADDR 0x03 > > +#define PCF2129_MIN_REG_ADDR 0x04 > > +#define PCF2129_HR_REG_ADDR 0x05 > > +#define PCF2129_DAY_REG_ADDR 0x06 > > +#define PCF2129_WEEKDAY_REG_ADDR 0x07 > > +#define PCF2129_MON_REG_ADDR 0x08 > > +#define PCF2129_YR_REG_ADDR 0x09 > > + > > +#define PCF2129_CTRL3_BIT_BLF BIT2 /* Battery Low Flag*/ > > + > > +// Define EPOCH (1998-JANUARY-01) in the Julian Date representation > > +#define EPOCH_JULIAN_DATE 2450815 > > + > > +typedef struct { > > + UINTN OperationCount; > > + EFI_I2C_OPERATION SetAddressOp; > > + EFI_I2C_OPERATION GetSetDateTimeOp; > > +} RTC_I2C_REQUEST; > > + > > +#endif // __PCF2129RTC_H__ > > diff --git a/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.c > b/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.c > > new file mode 100644 > > index 0000000..2e21014 > > --- /dev/null > > +++ b/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.c > > @@ -0,0 +1,330 @@ > > +/** @PCF2129RtcLib.c > > + Implement EFI RealTimeClock with runtime services via RTC Lib for > PCF2129 RTC. > > + > > + Based on RTC implementation available in > > + EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c > > + > > + Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> > + Copyright 2017 NXP > > + > > + This program and the accompanying materials > > + are licensed and made available under the terms and conditions of th= e > BSD License > > + which accompanies this distribution. The full text of the license m= ay be > found at > > + > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fope > nsource.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7Cac3a81 > 31870a4f555cbc08d5a5ddfdc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C636597295251146941&sdata=3DWheF7lR6B7iBUJBG2TGfGzJoiVhO%2F > I1VZywt3l%2FeXug%3D&reserved=3D0 > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > > + > > +**/ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "Pcf2129Rtc.h" > > + > > +STATIC EFI_I2C_MASTER_PROTOCOL *mI2cMaster; > > + > > +/** > > + returns Day of the week [0-6] 0=3DSunday > > + Don't try to provide a Year that's before 1998, please ! >=20 > (You should probably add an assert for that, in that case.) >=20 OK > > + **/ > > +UINTN > > +EfiTimeToWday ( >=20 > This looks like a completely generic function. Could it be submitted > to edk2 EmbeddedPkg/Library/TimeBaseLib? >=20 Will send > > + IN EFI_TIME *Time > > + ) > > +{ > > + UINTN MonthDiff; > > + UINTN Year; > > + UINTN Month; > > + UINTN JulianDate; // Absolute Julian Date representation of the > supplied Time > > + UINTN EpochDays; // Number of days elapsed since > EPOCH_JULIAN_DAY > > + > > + MonthDiff =3D (14 - Time->Month) / 12 ; > > + Year =3D Time->Year + 4800 - MonthDiff; > > + Month =3D Time->Month + (12*MonthDiff) - 3; > > + > > + JulianDate =3D Time->Day + ((153*Month + 2)/5) + (365*Year) + (Year/= 4) - > (Year/100) + (Year/400) - 32045; > > + > > + ASSERT (JulianDate >=3D EPOCH_JULIAN_DATE); > > + EpochDays =3D JulianDate - EPOCH_JULIAN_DATE; > > + > > + // 4=3D1/1/1998 was a Thursday >=20 > Extra space in indentation. Will correct, thanks for catching. >=20 > > + > > + return (EpochDays + 4) % 7; > > +} > > + > > +/** > > + Write RTC register. > > + > > + @param RtcRegAddr Register offset of RTC to write. > > + @param Val Value to be written > > + > > +**/ > > + > > +STATIC > > +VOID > > +RtcWrite ( > > + IN UINT8 RtcRegAddr, > > + IN UINT8 Val > > + ) > > +{ > > + RTC_I2C_REQUEST Req; > > + EFI_STATUS Status; > > + > > + Req.OperationCount =3D 2; > > + > > + Req.SetAddressOp.Flags =3D 0; > > + Req.SetAddressOp.LengthInBytes =3D 0; > > + Req.SetAddressOp.Buffer =3D &RtcRegAddr; > > + > > + Req.GetSetDateTimeOp.Flags =3D 0; > > + Req.GetSetDateTimeOp.LengthInBytes =3D sizeof (Val); > > + Req.GetSetDateTimeOp.Buffer =3D &Val; > > + > > + Status =3D mI2cMaster->StartRequest (mI2cMaster, FixedPcdGet8 > (PcdI2cSlaveAddress), > > + (VOID *)&Req, > > + NULL, NULL); > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "RTC write error at Addr:0x%x\n", > RtcRegAddr)); > > + } > > + > > +} > > + > > +/** > > + Returns the current time and date information, and the time-keeping > capabilities > > + of the hardware platform. > > + > > + @param Time A pointer to storage to receive a snap= shot of the > current time. > > + @param Capabilities An optional pointer to a buffer to rec= eive the > real time clock > > + device's capabilities. > > + > > + @retval EFI_SUCCESS The operation completed successfully. > > + @retval EFI_INVALID_PARAMETER Time is NULL. > > + @retval EFI_DEVICE_ERROR The time could not be retrieved due to > hardware error. > > + > > +**/ > > + > > +EFI_STATUS > > +EFIAPI > > +LibGetTime ( > > + OUT EFI_TIME *Time, > > + OUT EFI_TIME_CAPABILITIES *Capabilities > > + ) > > +{ > > + EFI_STATUS Status; > > + UINT8 Buffer[10]; > > + RTC_I2C_REQUEST Req; > > + UINT8 RtcRegAddr; > > + > > + Status =3D EFI_SUCCESS; > > + RtcRegAddr =3D PCF2129_CTRL1_REG_ADDR; > > + Buffer[0] =3D 0; > > + > > + if (mI2cMaster =3D=3D NULL) { > > + return EFI_DEVICE_ERROR; > > + } > > + > > + RtcWrite (PCF2129_CTRL1_REG_ADDR, Buffer[0]); > > + > > + if (Time =3D=3D NULL) { > > + return EFI_INVALID_PARAMETER; > > + } > > + > > + Req.OperationCount =3D 2; > > + > > + Req.SetAddressOp.Flags =3D 0; > > + Req.SetAddressOp.LengthInBytes =3D 0; > > + Req.SetAddressOp.Buffer =3D &RtcRegAddr; > > + > > + Req.GetSetDateTimeOp.Flags =3D I2C_FLAG_READ; > > + Req.GetSetDateTimeOp.LengthInBytes =3D sizeof (Buffer); > > + Req.GetSetDateTimeOp.Buffer =3D Buffer; > > + > > + Status =3D mI2cMaster->StartRequest (mI2cMaster, FixedPcdGet8 > (PcdI2cSlaveAddress), > > + (VOID *)&Req, > > + NULL, NULL); > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "RTC read error at Addr:0x%x\n", > RtcRegAddr)); > > + } > > + > > + if (Buffer[PCF2129_CTRL3_REG_ADDR] & PCF2129_CTRL3_BIT_BLF) { > > + DEBUG((DEBUG_INFO, "### Warning: RTC battery status low, > check/replace RTC battery.\n")); > > + } > > + > > + Time->Nanosecond =3D 0; > > + Time->Second =3D BcdToDecimal8 (Buffer[PCF2129_SEC_REG_ADDR] & > 0x7F); > > + Time->Minute =3D BcdToDecimal8 (Buffer[PCF2129_MIN_REG_ADDR] & > 0x7F); > > + Time->Hour =3D BcdToDecimal8 (Buffer[PCF2129_HR_REG_ADDR] & 0x3F); > > + Time->Day =3D BcdToDecimal8 (Buffer[PCF2129_DAY_REG_ADDR] & 0x3F); > > + Time->Month =3D BcdToDecimal8 (Buffer[PCF2129_MON_REG_ADDR] & > 0x1F); >=20 > Ideally, I would like to see #defines for these masks. >=20 Will define macro > > + Time->Year =3D BcdToDecimal8 (Buffer[PCF2129_YR_REG_ADDR]) + ( > BcdToDecimal8 (Buffer[PCF2129_YR_REG_ADDR]) >=3D 98 ? 1900 : 2000); >=20 > That is a very long line. > It could be shortened substantially by using a temporary variable for > BcdToDecimal8 (Buffer[PCF2129_YR_REG_ADDR]). >=20 Sure > > + > > + return Status; > > +} > > + > > +/** > > + Sets the current local time and date information. > > + > > + @param Time A pointer to the current time. > > + > > + @retval EFI_SUCCESS The operation completed successfully. > > + @retval EFI_INVALID_PARAMETER A time field is out of range. > > + @retval EFI_DEVICE_ERROR The time could not be set due due to > hardware error. > > + > > +**/ > > + > > +EFI_STATUS > > +EFIAPI > > +LibSetTime ( > > + IN EFI_TIME *Time > > + ) > > +{ > > + UINT8 Buffer[8]; > > + UINT8 Index; > > + EFI_STATUS Status; > > + RTC_I2C_REQUEST Req; > > + UINT8 RtcRegAddr; > > + > > + Index =3D 0; > > + Status =3D EFI_SUCCESS; > > + RtcRegAddr =3D PCF2129_CTRL1_REG_ADDR; > > + > > + if (mI2cMaster =3D=3D NULL) { > > + return EFI_DEVICE_ERROR; > > + } > > + > > + // start register address > > + Buffer[Index++] =3D PCF2129_SEC_REG_ADDR; > > + > > + // hours, minutes and seconds > > + Buffer[Index++] =3D DecimalToBcd8 (Time->Second); > > + Buffer[Index++] =3D DecimalToBcd8 (Time->Minute); > > + Buffer[Index++] =3D DecimalToBcd8 (Time->Hour); > > + Buffer[Index++] =3D DecimalToBcd8 (Time->Day); > > + Buffer[Index++] =3D EfiTimeToWday (Time) & 0x07; >=20 > Why mask at the call site? >=20 In GetTime function, data is been read from RTC device so we need to mask t= he unnecessary bits=20 [as described in RTC registers] while In SetTime, we are receiving the appropriate buffer so no need to mask the = data. > / > Leif >=20 > > + Buffer[Index++] =3D DecimalToBcd8 (Time->Month); > > + Buffer[Index++] =3D DecimalToBcd8 (Time->Year % 100); > > + > > + Req.OperationCount =3D 2; > > + Req.SetAddressOp.Flags =3D 0; > > + Req.SetAddressOp.LengthInBytes =3D 0; > > + Req.SetAddressOp.Buffer =3D &RtcRegAddr; > > + > > + Req.GetSetDateTimeOp.Flags =3D 0; > > + Req.GetSetDateTimeOp.LengthInBytes =3D sizeof (Buffer); > > + Req.GetSetDateTimeOp.Buffer =3D Buffer; > > + > > + Status =3D mI2cMaster->StartRequest (mI2cMaster, FixedPcdGet8 > (PcdI2cSlaveAddress), > > + (VOID *)&Req, > > + NULL, NULL); > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "RTC write error at Addr:0x%x\n", > RtcRegAddr)); > > + return Status; > > + } > > + > > + return Status; > > +} > > + > > + > > +/** > > + Returns the current wakeup alarm clock setting. > > + > > + @param Enabled Indicates if the alarm is currently en= abled or > disabled. > > + @param Pending Indicates if the alarm signal is pendi= ng and > requires acknowledgement. > > + @param Time The current alarm setting. > > + > > + @retval EFI_SUCCESS The alarm settings were returned. > > + @retval EFI_INVALID_PARAMETER Any parameter is NULL. > > + @retval EFI_DEVICE_ERROR The wakeup time could not be retrieved > due to a hardware error. > > + @retval EFI_UNSUPPORTED A wakeup timer is not supported on thi= s > platform. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +LibGetWakeupTime ( > > + OUT BOOLEAN *Enabled, > > + OUT BOOLEAN *Pending, > > + OUT EFI_TIME *Time > > + ) > > +{ > > + // Not a required feature > > + return EFI_UNSUPPORTED; > > +} > > + > > + > > +/** > > + Sets the system wakeup alarm clock time. > > + > > + @param Enabled Enable or disable the wakeup alarm. > > + @param Time If Enable is TRUE, the time to set the= wakeup > alarm for. > > + > > + @retval EFI_SUCCESS If Enable is TRUE, then the wakeup ala= rm was > enabled. If > > + Enable is FALSE, then the wakeup alarm= was disabled. > > + @retval EFI_INVALID_PARAMETER A time field is out of range. > > + @retval EFI_DEVICE_ERROR The wakeup time could not be set due t= o > a hardware error. > > + @retval EFI_UNSUPPORTED A wakeup timer is not supported on thi= s > platform. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +LibSetWakeupTime ( > > + IN BOOLEAN Enabled, > > + OUT EFI_TIME *Time > > + ) > > +{ > > + // Not a required feature > > + return EFI_UNSUPPORTED; > > +} > > + > > +/** > > + This is the declaration of an EFI image entry point. This can be the= entry > point to an application > > + written to this specification, an EFI boot service driver, or an EFI= runtime > driver. > > + > > + @param ImageHandle Handle that identifies the loaded imag= e. > > + @param SystemTable System Table for this image. > > + > > + @retval EFI_SUCCESS The operation completed successfully. > > + @retval EFI_DEVICE_ERROR The operation could not be started. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +LibRtcInitialize ( > > + IN EFI_HANDLE ImageHandle, > > + IN EFI_SYSTEM_TABLE *SystemTable > > + ) > > +{ > > + > > + EFI_STATUS Status; > > + EFI_I2C_MASTER_PROTOCOL *I2cMaster; > > + UINTN BusFrequency; > > + > > + Status =3D gBS->LocateProtocol (&gEfiI2cMasterProtocolGuid, NULL, (V= OID > **)&I2cMaster); > > + > > + ASSERT_EFI_ERROR (Status); > > + > > + Status =3D I2cMaster->Reset (I2cMaster); > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "%a: I2CMaster->Reset () failed - %r\n", > > + __FUNCTION__, Status)); > > + return Status; > > + } > > + > > + BusFrequency =3D FixedPcdGet32 (PcdI2cSpeed); > > + Status =3D I2cMaster->SetBusFrequency (I2cMaster, &BusFrequency); > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "%a: I2CMaster->SetBusFrequency () failed - > %r\n", > > + __FUNCTION__, Status)); > > + return Status; > > + } > > + > > + mI2cMaster =3D I2cMaster; > > + > > + return EFI_SUCCESS; > > +} > > diff --git a/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.inf > b/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.inf > > new file mode 100644 > > index 0000000..873bcea > > --- /dev/null > > +++ b/Silicon/NXP/Library/Pcf2129RtcLib/Pcf2129RtcLib.inf > > @@ -0,0 +1,47 @@ > > +#/** @Pcf2129RtcLib.inf > > +# > > +# Copyright 2017 NXP > > +# > > +# This program and the accompanying materials > > +# are licensed and made available under the terms and conditions of t= he > BSD License > > +# which accompanies this distribution. The full text of the license m= ay be > found at > > +# > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fope > nsource.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7Cac3a81 > 31870a4f555cbc08d5a5ddfdc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C636597295251146941&sdata=3DWheF7lR6B7iBUJBG2TGfGzJoiVhO%2F > I1VZywt3l%2FeXug%3D&reserved=3D0 > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > > +# > > +# > > +#**/ > > + > > +[Defines] > > + INF_VERSION =3D 0x0001001A > > + BASE_NAME =3D Pcf2129RtcLib > > + FILE_GUID =3D B661E02D-A90B-42AB-A5F9-CF841AAA4= 3D9 > > + MODULE_TYPE =3D BASE > > + VERSION_STRING =3D 1.0 > > + LIBRARY_CLASS =3D RealTimeClockLib > > + > > + > > +[Sources.common] > > + Pcf2129RtcLib.c > > + > > +[Packages] > > + EmbeddedPkg/EmbeddedPkg.dec > > + MdePkg/MdePkg.dec > > + Silicon/NXP/NxpQoriqLs.dec > > + > > +[LibraryClasses] > > + DebugLib > > + UefiBootServicesTableLib > > + UefiLib > > + > > +[Protocols] > > + gEfiDriverBindingProtocolGuid ## CONSUMES > > + gEfiI2cMasterProtocolGuid ## CONSUMES > > + > > +[Pcd] > > + gNxpQoriqLsTokenSpaceGuid.PcdI2cBus > > + gNxpQoriqLsTokenSpaceGuid.PcdI2cSpeed > > + gNxpQoriqLsTokenSpaceGuid.PcdI2cSlaveAddress > > + > > +[Depex] > > + gEfiI2cMasterProtocolGuid > > -- > > 1.9.1 > >