ArmLib : GIC Pcds in "ArmPkg/Library/ArmLib/ArmBaseLib.inf"

ArmLib : GIC Pcds in "ArmPkg/Library/ArmLib/ArmBaseLib.inf"

[Meenakshi Aggarwal]

Hi,


I need to modify GicDistributorBase and GicInterruptInterfaceBase Pcds on run time, so I need these to be dynamic.
But on doing same I am facing errors, because these Pcds are included under [FixedPcd] section in ArmBaseLib.inf and I am using ArmLib.


[FixedPcd]
  gArmTokenSpaceGuid.PcdGicDistributorBase
  gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase


Is there any particular reason behind including these Pcds in ArmBaseLib.inf, as ArmLib is not using these Pcds anywhere.

I removed these Pcds from ArmBaseLib.inf and I didn't face any issue, neither in compilation nor in execution.


Please tell me the relevance of including these Pcds in ArmBaseLib.inf.



Thanks & Regards,
Meenakshi

Re: ArmLib : GIC Pcds in "ArmPkg/Library/ArmLib/ArmBaseLib.inf"

[Ard Biesheuvel]

On 15 December 2016 at 04:46, Meenakshi Aggarwal
<meenakshi.aggarwal@nxp.com> wrote:
> Hi,
>
>
> I need to modify GicDistributorBase and GicInterruptInterfaceBase Pcds on run time, so I need these to be dynamic.
> But on doing same I am facing errors, because these Pcds are included under [FixedPcd] section in ArmBaseLib.inf and I am using ArmLib.
>
>
> [FixedPcd]
>   gArmTokenSpaceGuid.PcdGicDistributorBase
>   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase
>
>
> Is there any particular reason behind including these Pcds in ArmBaseLib.inf, as ArmLib is not using these Pcds anywhere.
>
> I removed these Pcds from ArmBaseLib.inf and I didn't face any issue, neither in compilation nor in execution.
>
>
> Please tell me the relevance of including these Pcds in ArmBaseLib.inf.
>

If they are not used in ArmLib, they should be dropped from the .INF

Thanks,
Ard,

Re: ArmLib : GIC Pcds in "ArmPkg/Library/ArmLib/ArmBaseLib.inf"

[Meenakshi Aggarwal]

Hi Ard,


Thanks for your reply.


Apologies for this mail before finding out which patch has introduced this change.

These Pcds were added by us only for GIC initialization, not available in linaro edk2.


Sorry for shooting this mail.


Thanks a lot for your reply.


Regards,
Meenakshi

-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] 
Sent: Thursday, December 15, 2016 1:16 PM
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>; Leif Lindholm <Leif.Lindholm@arm.com>
Subject: Re: ArmLib : GIC Pcds in "ArmPkg/Library/ArmLib/ArmBaseLib.inf"

On 15 December 2016 at 04:46, Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> wrote:
> Hi,
>
>
> I need to modify GicDistributorBase and GicInterruptInterfaceBase Pcds on run time, so I need these to be dynamic.
> But on doing same I am facing errors, because these Pcds are included under [FixedPcd] section in ArmBaseLib.inf and I am using ArmLib.
>
>
> [FixedPcd]
>   gArmTokenSpaceGuid.PcdGicDistributorBase
>   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase
>
>
> Is there any particular reason behind including these Pcds in ArmBaseLib.inf, as ArmLib is not using these Pcds anywhere.
>
> I removed these Pcds from ArmBaseLib.inf and I didn't face any issue, neither in compilation nor in execution.
>
>
> Please tell me the relevance of including these Pcds in ArmBaseLib.inf.
>

If they are not used in ArmLib, they should be dropped from the .INF

Thanks,
Ard,