* [RFC] ShellPkg/Ping: fix loss of first packet
@ 2018-02-16 8:45 Meenakshi
2018-02-16 15:20 ` Carsey, Jaben
0 siblings, 1 reply; 9+ messages in thread
From: Meenakshi @ 2018-02-16 8:45 UTC (permalink / raw)
To: ruiyu.ni, jaben.carsey, edk2-devel, lersek
From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Issue:
Reply for first ping packet was getting dropped.
Cause:
Sometimes reply message comes even before trasmit
function returns, hence missing 1st reply
Fix:
Prepare the TxList before calling Transmit function.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
index bec9535..46ba701 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
@@ -784,14 +784,17 @@ PingSendEchoRequest (
}
ASSERT(Private->ProtocolPointers.Transmit != NULL);
+
+ InsertTailList (&Private->TxList, &TxInfo->Link);
+
Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo->Token);
if (EFI_ERROR (Status)) {
+ RemoveEntryList (&TxInfo->Link);
PingDestroyTxInfo (TxInfo, Private->IpChoice);
return Status;
}
- InsertTailList (&Private->TxList, &TxInfo->Link);
Private->TxCount++;
return EFI_SUCCESS;
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-16 8:45 [RFC] ShellPkg/Ping: fix loss of first packet Meenakshi
@ 2018-02-16 15:20 ` Carsey, Jaben
2018-02-20 6:18 ` Meenakshi Aggarwal
0 siblings, 1 reply; 9+ messages in thread
From: Carsey, Jaben @ 2018-02-16 15:20 UTC (permalink / raw)
To: Meenakshi, Ni, Ruiyu, edk2-devel@lists.01.org, lersek@redhat.com
Seems good to me. I will let Ray review also.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi
> Sent: Friday, February 16, 2018 12:45 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> Importance: High
>
> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>
> Issue:
> Reply for first ping packet was getting dropped.
>
> Cause:
> Sometimes reply message comes even before trasmit
> function returns, hence missing 1st reply
>
> Fix:
> Prepare the TxList before calling Transmit function.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> index bec9535..46ba701 100644
> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> @@ -784,14 +784,17 @@ PingSendEchoRequest (
> }
>
> ASSERT(Private->ProtocolPointers.Transmit != NULL);
> +
> + InsertTailList (&Private->TxList, &TxInfo->Link);
> +
> Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> >Token);
>
> if (EFI_ERROR (Status)) {
> + RemoveEntryList (&TxInfo->Link);
> PingDestroyTxInfo (TxInfo, Private->IpChoice);
> return Status;
> }
>
> - InsertTailList (&Private->TxList, &TxInfo->Link);
> Private->TxCount++;
>
> return EFI_SUCCESS;
> --
> 1.9.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-16 15:20 ` Carsey, Jaben
@ 2018-02-20 6:18 ` Meenakshi Aggarwal
2018-02-22 8:32 ` Ni, Ruiyu
0 siblings, 1 reply; 9+ messages in thread
From: Meenakshi Aggarwal @ 2018-02-20 6:18 UTC (permalink / raw)
To: Carsey, Jaben, Ni, Ruiyu, edk2-devel@lists.01.org,
lersek@redhat.com
Hi Ray,
Please share your comments.
Thanks,
Meenakshi
> -----Original Message-----
> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> Sent: Friday, February 16, 2018 8:51 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>
> Seems good to me. I will let Ray review also.
>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Meenakshi
> > Sent: Friday, February 16, 2018 12:45 AM
> > To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> > Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> > Importance: High
> >
> > From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >
> > Issue:
> > Reply for first ping packet was getting dropped.
> >
> > Cause:
> > Sometimes reply message comes even before trasmit
> > function returns, hence missing 1st reply
> >
> > Fix:
> > Prepare the TxList before calling Transmit function.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > ---
> > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > index bec9535..46ba701 100644
> > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > @@ -784,14 +784,17 @@ PingSendEchoRequest (
> > }
> >
> > ASSERT(Private->ProtocolPointers.Transmit != NULL);
> > +
> > + InsertTailList (&Private->TxList, &TxInfo->Link);
> > +
> > Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> > >Token);
> >
> > if (EFI_ERROR (Status)) {
> > + RemoveEntryList (&TxInfo->Link);
> > PingDestroyTxInfo (TxInfo, Private->IpChoice);
> > return Status;
> > }
> >
> > - InsertTailList (&Private->TxList, &TxInfo->Link);
> > Private->TxCount++;
> >
> > return EFI_SUCCESS;
> > --
> > 1.9.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> 4aQLVSNNti8%3D&reserved=0
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-20 6:18 ` Meenakshi Aggarwal
@ 2018-02-22 8:32 ` Ni, Ruiyu
2018-02-23 9:57 ` Meenakshi Aggarwal
0 siblings, 1 reply; 9+ messages in thread
From: Ni, Ruiyu @ 2018-02-22 8:32 UTC (permalink / raw)
To: Meenakshi Aggarwal, Carsey, Jaben, edk2-devel@lists.01.org,
lersek@redhat.com
On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
> Hi Ray,
>
> Please share your comments.
>
>
> Thanks,
> Meenakshi
>
>> -----Original Message-----
>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
>> Sent: Friday, February 16, 2018 8:51 PM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
>> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>
>> Seems good to me. I will let Ray review also.
>>
>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>>
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>>> Meenakshi
>>> Sent: Friday, February 16, 2018 12:45 AM
>>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
>>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>> Importance: High
>>>
>>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>
>>> Issue:
>>> Reply for first ping packet was getting dropped.
>>>
>>> Cause:
>>> Sometimes reply message comes even before trasmit
>>> function returns, hence missing 1st reply
>>>
>>> Fix:
>>> Prepare the TxList before calling Transmit function.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>> ---
>>> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> index bec9535..46ba701 100644
>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>>> }
>>>
>>> ASSERT(Private->ProtocolPointers.Transmit != NULL);
>>> +
>>> + InsertTailList (&Private->TxList, &TxInfo->Link);
>>> +
>>> Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
>>>> Token);
>>>
>>> if (EFI_ERROR (Status)) {
>>> + RemoveEntryList (&TxInfo->Link);
>>> PingDestroyTxInfo (TxInfo, Private->IpChoice);
>>> return Status;
>>> }
>>>
>>> - InsertTailList (&Private->TxList, &TxInfo->Link);
>>> Private->TxCount++;
>>>
>>> return EFI_SUCCESS;
>>> --
>>> 1.9.1
>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
>> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
>> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
>> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
>> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
>> 4aQLVSNNti8%3D&reserved=0
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-22 8:32 ` Ni, Ruiyu
@ 2018-02-23 9:57 ` Meenakshi Aggarwal
2018-02-23 10:17 ` Laszlo Ersek
0 siblings, 1 reply; 9+ messages in thread
From: Meenakshi Aggarwal @ 2018-02-23 9:57 UTC (permalink / raw)
To: Ni, Ruiyu, Carsey, Jaben, edk2-devel@lists.01.org,
lersek@redhat.com
Hi All,
Any comments on this patch or is it good to go?
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks,
Meenakshi
> -----Original Message-----
> From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com]
> Sent: Thursday, February 22, 2018 2:03 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>
> On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
> > Hi Ray,
> >
> > Please share your comments.
> >
> >
> > Thanks,
> > Meenakshi
> >
> >> -----Original Message-----
> >> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> >> Sent: Friday, February 16, 2018 8:51 PM
> >> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> >> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> >> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>
> >> Seems good to me. I will let Ray review also.
> >>
> >> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >>
> >>> -----Original Message-----
> >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> Of
> >>> Meenakshi
> >>> Sent: Friday, February 16, 2018 12:45 AM
> >>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> >>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org;
> lersek@redhat.com
> >>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>> Importance: High
> >>>
> >>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >>>
> >>> Issue:
> >>> Reply for first ping packet was getting dropped.
> >>>
> >>> Cause:
> >>> Sometimes reply message comes even before trasmit
> >>> function returns, hence missing 1st reply
> >>>
> >>> Fix:
> >>> Prepare the TxList before calling Transmit function.
> >>>
> >>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >>> ---
> >>> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> >>> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> index bec9535..46ba701 100644
> >>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
> >>> }
> >>>
> >>> ASSERT(Private->ProtocolPointers.Transmit != NULL);
> >>> +
> >>> + InsertTailList (&Private->TxList, &TxInfo->Link);
> >>> +
> >>> Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
> TxInfo-
> >>>> Token);
> >>>
> >>> if (EFI_ERROR (Status)) {
> >>> + RemoveEntryList (&TxInfo->Link);
> >>> PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >>> return Status;
> >>> }
> >>>
> >>> - InsertTailList (&Private->TxList, &TxInfo->Link);
> >>> Private->TxCount++;
> >>>
> >>> return EFI_SUCCESS;
> >>> --
> >>> 1.9.1
> >>>
> >>> _______________________________________________
> >>> edk2-devel mailing list
> >>> edk2-devel@lists.01.org
> >>>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> >> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> >>
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> >>
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >>
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> >> 4aQLVSNNti8%3D&reserved=0
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>
>
> --
> Thanks,
> Ray
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-23 9:57 ` Meenakshi Aggarwal
@ 2018-02-23 10:17 ` Laszlo Ersek
2018-02-23 10:26 ` Meenakshi Aggarwal
0 siblings, 1 reply; 9+ messages in thread
From: Laszlo Ersek @ 2018-02-23 10:17 UTC (permalink / raw)
To: Meenakshi Aggarwal, Ni, Ruiyu, Carsey, Jaben,
edk2-devel@lists.01.org
On 02/23/18 10:57, Meenakshi Aggarwal wrote:
> Hi All,
>
> Any comments on this patch or is it good to go?
>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Are you asking for someone to commit & push the patch?
Laszlo
>> -----Original Message-----
>> From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com]
>> Sent: Thursday, February 22, 2018 2:03 PM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Carsey, Jaben
>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>
>> On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
>>> Hi Ray,
>>>
>>> Please share your comments.
>>>
>>>
>>> Thanks,
>>> Meenakshi
>>>
>>>> -----Original Message-----
>>>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
>>>> Sent: Friday, February 16, 2018 8:51 PM
>>>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
>>>> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
>>>> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>>>
>>>> Seems good to me. I will let Ray review also.
>>>>
>>>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>>>>
>>>>> -----Original Message-----
>>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
>> Of
>>>>> Meenakshi
>>>>> Sent: Friday, February 16, 2018 12:45 AM
>>>>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
>>>>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org;
>> lersek@redhat.com
>>>>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>>>> Importance: High
>>>>>
>>>>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>>>
>>>>> Issue:
>>>>> Reply for first ping packet was getting dropped.
>>>>>
>>>>> Cause:
>>>>> Sometimes reply message comes even before trasmit
>>>>> function returns, hence missing 1st reply
>>>>>
>>>>> Fix:
>>>>> Prepare the TxList before calling Transmit function.
>>>>>
>>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>>>> ---
>>>>> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>>>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> index bec9535..46ba701 100644
>>>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>>>>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>>>>> }
>>>>>
>>>>> ASSERT(Private->ProtocolPointers.Transmit != NULL);
>>>>> +
>>>>> + InsertTailList (&Private->TxList, &TxInfo->Link);
>>>>> +
>>>>> Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
>> TxInfo-
>>>>>> Token);
>>>>>
>>>>> if (EFI_ERROR (Status)) {
>>>>> + RemoveEntryList (&TxInfo->Link);
>>>>> PingDestroyTxInfo (TxInfo, Private->IpChoice);
>>>>> return Status;
>>>>> }
>>>>>
>>>>> - InsertTailList (&Private->TxList, &TxInfo->Link);
>>>>> Private->TxCount++;
>>>>>
>>>>> return EFI_SUCCESS;
>>>>> --
>>>>> 1.9.1
>>>>>
>>>>> _______________________________________________
>>>>> edk2-devel mailing list
>>>>> edk2-devel@lists.01.org
>>>>>
>>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
>>>> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
>>>>
>> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
>>>>
>> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
>>>>
>> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
>>>> 4aQLVSNNti8%3D&reserved=0
>> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>>
>>
>> --
>> Thanks,
>> Ray
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-23 10:17 ` Laszlo Ersek
@ 2018-02-23 10:26 ` Meenakshi Aggarwal
2018-02-23 12:01 ` Laszlo Ersek
0 siblings, 1 reply; 9+ messages in thread
From: Meenakshi Aggarwal @ 2018-02-23 10:26 UTC (permalink / raw)
To: Laszlo Ersek, Ni, Ruiyu, Carsey, Jaben, edk2-devel@lists.01.org
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, February 23, 2018 3:48 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> <ruiyu.ni@Intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; edk2-
> devel@lists.01.org
> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>
> On 02/23/18 10:57, Meenakshi Aggarwal wrote:
> > Hi All,
> >
> > Any comments on this patch or is it good to go?
> >
> > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> > Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>
> Are you asking for someone to commit & push the patch?
>
I request for both, comments (if any), else please push this patch.
> Laszlo
>
> >> -----Original Message-----
> >> From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com]
> >> Sent: Thursday, February 22, 2018 2:03 PM
> >> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Carsey, Jaben
> >> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> >> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>
> >> On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
> >>> Hi Ray,
> >>>
> >>> Please share your comments.
> >>>
> >>>
> >>> Thanks,
> >>> Meenakshi
> >>>
> >>>> -----Original Message-----
> >>>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> >>>> Sent: Friday, February 16, 2018 8:51 PM
> >>>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> >>>> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> >>>> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>>>
> >>>> Seems good to me. I will let Ray review also.
> >>>>
> >>>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >>>>
> >>>>> -----Original Message-----
> >>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
> Behalf
> >> Of
> >>>>> Meenakshi
> >>>>> Sent: Friday, February 16, 2018 12:45 AM
> >>>>> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> >>>>> <jaben.carsey@intel.com>; edk2-devel@lists.01.org;
> >> lersek@redhat.com
> >>>>> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>>>> Importance: High
> >>>>>
> >>>>> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >>>>>
> >>>>> Issue:
> >>>>> Reply for first ping packet was getting dropped.
> >>>>>
> >>>>> Cause:
> >>>>> Sometimes reply message comes even before trasmit
> >>>>> function returns, hence missing 1st reply
> >>>>>
> >>>>> Fix:
> >>>>> Prepare the TxList before calling Transmit function.
> >>>>>
> >>>>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>>>> Signed-off-by: Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>
> >>>>> ---
> >>>>> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> >>>>> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> index bec9535..46ba701 100644
> >>>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> >>>>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
> >>>>> }
> >>>>>
> >>>>> ASSERT(Private->ProtocolPointers.Transmit != NULL);
> >>>>> +
> >>>>> + InsertTailList (&Private->TxList, &TxInfo->Link);
> >>>>> +
> >>>>> Status = Private->ProtocolPointers.Transmit (Private->IpProtocol,
> >> TxInfo-
> >>>>>> Token);
> >>>>>
> >>>>> if (EFI_ERROR (Status)) {
> >>>>> + RemoveEntryList (&TxInfo->Link);
> >>>>> PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >>>>> return Status;
> >>>>> }
> >>>>>
> >>>>> - InsertTailList (&Private->TxList, &TxInfo->Link);
> >>>>> Private->TxCount++;
> >>>>>
> >>>>> return EFI_SUCCESS;
> >>>>> --
> >>>>> 1.9.1
> >>>>>
> >>>>> _______________________________________________
> >>>>> edk2-devel mailing list
> >>>>> edk2-devel@lists.01.org
> >>>>>
> >>>>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> >>>> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> >>>>
> >>
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> >>>>
> >>
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >>>>
> >>
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> >>>> 4aQLVSNNti8%3D&reserved=0
> >> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> >>
> >>
> >> --
> >> Thanks,
> >> Ray
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-23 10:26 ` Meenakshi Aggarwal
@ 2018-02-23 12:01 ` Laszlo Ersek
2018-02-23 16:35 ` Carsey, Jaben
0 siblings, 1 reply; 9+ messages in thread
From: Laszlo Ersek @ 2018-02-23 12:01 UTC (permalink / raw)
To: Meenakshi Aggarwal; +Cc: Ni, Ruiyu, Carsey, Jaben, edk2-devel@lists.01.org
On 02/23/18 11:26, Meenakshi Aggarwal wrote:
>
>
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Friday, February 23, 2018 3:48 PM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
>> <ruiyu.ni@Intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; edk2-
>> devel@lists.01.org
>> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>>
>> On 02/23/18 10:57, Meenakshi Aggarwal wrote:
>>> Hi All,
>>>
>>> Any comments on this patch or is it good to go?
>>>
>>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>>> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>>
>> Are you asking for someone to commit & push the patch?
>>
> I request for both, comments (if any), else please push this patch.
The patch has been on the list for ~7 days, and it has R-b's from both
ShellPkg maintainers.
I've pushed it for you now. Commit d624deb7abf9.
Thank you for the bugfix!
Laszlo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC] ShellPkg/Ping: fix loss of first packet
2018-02-23 12:01 ` Laszlo Ersek
@ 2018-02-23 16:35 ` Carsey, Jaben
0 siblings, 0 replies; 9+ messages in thread
From: Carsey, Jaben @ 2018-02-23 16:35 UTC (permalink / raw)
To: Laszlo Ersek, Meenakshi Aggarwal; +Cc: Ni, Ruiyu, edk2-devel@lists.01.org
Thanks Laszlo!
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, February 23, 2018 4:02 AM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> Importance: High
>
> On 02/23/18 11:26, Meenakshi Aggarwal wrote:
> >
> >
> >> -----Original Message-----
> >> From: Laszlo Ersek [mailto:lersek@redhat.com]
> >> Sent: Friday, February 23, 2018 3:48 PM
> >> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> >> <ruiyu.ni@Intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; edk2-
> >> devel@lists.01.org
> >> Subject: Re: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> >>
> >> On 02/23/18 10:57, Meenakshi Aggarwal wrote:
> >>> Hi All,
> >>>
> >>> Any comments on this patch or is it good to go?
> >>>
> >>> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >>> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> >>
> >> Are you asking for someone to commit & push the patch?
> >>
> > I request for both, comments (if any), else please push this patch.
>
> The patch has been on the list for ~7 days, and it has R-b's from both
> ShellPkg maintainers.
>
> I've pushed it for you now. Commit d624deb7abf9.
>
> Thank you for the bugfix!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-02-23 16:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-16 8:45 [RFC] ShellPkg/Ping: fix loss of first packet Meenakshi
2018-02-16 15:20 ` Carsey, Jaben
2018-02-20 6:18 ` Meenakshi Aggarwal
2018-02-22 8:32 ` Ni, Ruiyu
2018-02-23 9:57 ` Meenakshi Aggarwal
2018-02-23 10:17 ` Laszlo Ersek
2018-02-23 10:26 ` Meenakshi Aggarwal
2018-02-23 12:01 ` Laszlo Ersek
2018-02-23 16:35 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox