public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	Jun Nie <jun.nie@linaro.org>
Subject: Re: [PATCH 1/2] MMC : Recieve response was missing after CMD12
Date: Fri, 1 Sep 2017 10:46:51 +0000	[thread overview]
Message-ID: <DB5PR04MB0998B981DA415F73EC57C4258E920@DB5PR04MB0998.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20170901104503.xeqzvei6lnukh4bq@bivouac.eciton.net>

Hi Leif,

Sorry I forgot to add the contribution agreement.
Will make sure to add this in next patch.

Yes, I agree to this.

Regards,
Meenakshi

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Friday, September 01, 2017 4:15 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: edk2-devel@lists.01.org; Haojian Zhuang <haojian.zhuang@linaro.org>;
> Jun Nie <jun.nie@linaro.org>
> Subject: Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after
> CMD12
> 
> On Thu, Aug 31, 2017 at 09:33:08PM +0800, Jun Nie wrote:
> > On 2017年08月31日 19:22, Leif Lindholm wrote:
> > > On Wed, Aug 30, 2017 at 07:50:58PM +0530, Meenakshi Aggarwal wrote:
> > > > We are not recieving the response from memory card after sending
> > > > CMD 12. It was not resulting in any failure but we should recieve
> > > > response after sending a command.
> >
> > Per spec, there is response data for CMD12. It is reasonable to read it.
> >
> > Reviewed-by: Jun Nie <jun.nie@linaro.org>
> 
> Thanks Jun for the review!
> Since this patch is valid on its own, I have pushed it as 1cc0f69bbe.
> No need to include in a v2 submission.
> 
> However, I noticed after pushing (Doh! and for some reason my pre-push
> hook didn't catch this), that your submission was missing the required
> Contributed-under tag, as described by Contributions.txt.
> 
> Can you confirm that you consider your contribution to be under this
> agreement, as well as ensure to include this in any further submissions?
> 
> /
>     Leif

      reply	other threads:[~2017-09-01 10:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 14:20 [PATCH 1/2] MMC : Recieve response was missing after CMD12 Meenakshi Aggarwal
2017-08-30 14:20 ` [PATCH 2/2] SD : Updated CMD 6 implememtation Meenakshi Aggarwal
2017-08-31  6:06   ` Meenakshi Aggarwal
2017-08-31 12:06   ` Leif Lindholm
2017-08-31 14:43     ` Jun Nie
2017-09-01  9:32       ` Meenakshi Aggarwal
2017-09-04  8:37         ` Meenakshi Aggarwal
2017-08-31  6:05 ` [PATCH 1/2] MMC : Recieve response was missing after CMD12 Meenakshi Aggarwal
2017-08-31 11:22 ` Leif Lindholm
2017-08-31 13:33   ` Jun Nie
2017-08-31 14:14     ` Meenakshi Aggarwal
2017-09-01 10:45     ` Leif Lindholm
2017-09-01 10:46       ` Meenakshi Aggarwal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB5PR04MB0998B981DA415F73EC57C4258E920@DB5PR04MB0998.eurprd04.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox