From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.77; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0077.outbound.protection.outlook.com [104.47.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59E1322283524 for ; Mon, 5 Mar 2018 21:08:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uLfYuuj8OW0OPcWoojf++cs+z7IPuAi2tmdgQHeV5U4=; b=peFUT2KoVUFw91iUZ5uDLq0CDNFwMvOArC6YwTt86KgiPwW54ZdETyzC/Pp7DAW9mo9Khs0+TigrwKkGiDsKMmejoUS2Y6L6yOwHA2NMCZf6JKnt1+nYUqfk7Wz92886t5JWB5dK6QBg64sbnVILZKV8Cu1DgFbcJ9lytynyupc= Received: from DB5PR04MB0998.eurprd04.prod.outlook.com (10.161.199.12) by DB5PR04MB1416.eurprd04.prod.outlook.com (10.162.221.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Tue, 6 Mar 2018 05:14:27 +0000 Received: from DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::5b4:dfb7:891f:32ce]) by DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::5b4:dfb7:891f:32ce%13]) with mapi id 15.20.0548.016; Tue, 6 Mar 2018 05:14:26 +0000 From: Meenakshi Aggarwal To: Ard Biesheuvel , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers Thread-Index: AQHTmWkgZDMSbRVhR0+W7RsCXsoHS6OMLTGAgDaxdMA= Date: Tue, 6 Mar 2018 05:14:26 +0000 Message-ID: References: <20171207224322.20362-1-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103BA1996C@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR04MB1416; 7:mLx4KMEhNvGyZmLV2OMpvfaCy14s1T18coIRHL6RC7fOEBCoE1GWQxdweVAY1DMaw3XjCGsWvXemBquPUr1BK80QQAnrZFPW1wTlxqdeBy/dCBhlfr5c0VLuYY62I1ioM+IIFH4A+dSZdZIehVoSNJRsii3Z/Z5BlwDWD39RKl6oNDKtdecbpYINv2gSLkpdkotac2WjHkysXZYxOaE29l1r1FSc6R4pVUsadC3Q+WDOhDxgFjwyiAMZIhRfQdRo x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: db3300bf-701b-49a7-6d35-08d5832121ed x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB5PR04MB1416; x-ms-traffictypediagnostic: DB5PR04MB1416: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meenakshi.aggarwal@nxp.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(788757137089)(162533806227266)(45079756050767)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3231220)(944501244)(52105095)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:DB5PR04MB1416; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB1416; x-forefront-prvs: 06036BD506 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(376002)(39380400002)(396003)(346002)(13464003)(189003)(199004)(86362001)(76176011)(316002)(93886005)(55016002)(74316002)(305945005)(6116002)(102836004)(3846002)(8936002)(45080400002)(68736007)(99286004)(7736002)(9686003)(14454004)(26005)(6436002)(25786009)(6306002)(3660700001)(5250100002)(2501003)(6246003)(186003)(53936002)(105586002)(7696005)(53546011)(478600001)(81166006)(66066001)(81156014)(110136005)(5660300001)(229853002)(966005)(8676002)(33656002)(59450400001)(2950100002)(55236004)(3280700002)(106356001)(6506007)(2900100001)(97736004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1416; H:DB5PR04MB0998.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8AWcp3a8+3hWzQsz5Ig1vZ9XSi/0kUKSh1mCGeouDW89P/TjfWQs7JIu9rz7lt4iTKP+wBTlcnapQMUeGkiVRYKTToY6xH1oJcgq882CbgVCjxemLfloEWAYWgU5uKwEawNYyLcxn8CUqiITq+Ao5JRTPlwNwN6b4n1Bvj6tK5DnpvAOo3ozpaZ4TkDGGHXmaR5bJg6rgIhd1gkEjUPzyjqgScbYUavfs14s8OLc158j4qMzI80G0Gx4GcFghFflY3InxpAxvsg3Z/D67nlETviNKpovrV7xuHp07avLUjyYx9+prl115y74pVK5sPIc1plgtaIgvF4qTTP4oZ3p2g== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: db3300bf-701b-49a7-6d35-08d5832121ed X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2018 05:14:26.8067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1416 Subject: Re: [PATCH v4 0/2] quirks handling for SDHCI controllers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 05:08:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi, I am using Mmc Driver implemented in " EmbeddedPkg/Universal/MmcDxe/" for m= y SD/MMC controller and my controller is not on PCI bus. I am a bit confused if i should move to SD implementation available in 'Mde= ModulePkg\Bus\Pci\SdMmcPciHcDxe". Please suggest. Thanks, Meenakshi > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, January 30, 2018 3:22 PM > To: Zeng, Star > Cc: Ni, Ruiyu ; Tian, Feng ; Wu, > Hao A ; edk2-devel@lists.01.org; > leif.lindholm@linaro.org; Kinney, Michael D > Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers >=20 > On 30 January 2018 at 01:24, Zeng, Star wrote: > > Reviewed-by: Star Zeng > > > > Thanks Hao's investigation and Ard's contribution. > > >=20 > Thanks all >=20 > Pushed as 864701886fc3..b23fc39cd3c3 >=20 > > > > Star > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Monday, January 29, 2018 4:26 PM > > To: Wu, Hao A ; Zeng, Star ; > Ni, Ruiyu > > Cc: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael = D > ; Tian, Feng > > Subject: Re: [PATCH v4 0/2] quirks handling for SDHCI controllers > > > > On 29 January 2018 at 05:13, Wu, Hao A wrote: > >> One minor comment, please help to remove the line (around line 1067): > >> @param[in] Capability The capability of the slot. > >> > >> within function description comment for SdMmcHcInitHost() in file: > >> MdeModulePkg\Bus\Pci\SdMmcPciHcDxe\SdMmcPciHci.c > >> > >> Other than that, the series is good to me: > >> Reviewed-by: Hao Wu > >> > > > > Thank you very much! > > > >> Really sorry for the delay. > >> > > > > No worries. Star, Ray, any more comments from your side? > > > > > >> > >>> -----Original Message----- > >>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > >>> Sent: Friday, December 08, 2017 6:43 AM > >>> To: edk2-devel@lists.01.org > >>> Cc: leif.lindholm@linaro.org; Kinney, Michael D; Zeng, Star; Tian, > >>> Feng; Ni, Ruiyu; Wu, Hao A; Ard Biesheuvel > >>> Subject: [PATCH v4 0/2] quirks handling for SDHCI controllers > >>> > >>> Many SDHCI implementations exist that are almost spec complicant, and > >>> could be driven by the generic SD/MMC host controller driver except > >>> for some minimal necessary init time tweaks. > >>> > >>> Adding such tweaks to the generic driver is undesirable. On the other > >>> hand, forking the driver for every platform that has such a SDHCI > >>> controller is problematic when it comes to upstreaming and ongoing > >>> maintenance (which is arguably the point of upstreaming in the first > >>> place). > >>> > >>> So these patches propose a workaround that is minimally invasive on > >>> the > >>> EDK2 side, but gives platforms a lot of leeway when it comes to > >>> applying SDHCI quirks. > >>> > >>> Changes since v3: > >>> - remove PassThru argument from protocol members: it is unclear > whether the > >>> protocol is available when the override protocol is invoked, and my > >>> example use case does not need it > >>> - replace incorrect HandleProtocol with LocateProtocol, given that th= e > override > >>> protocol is now a singleton instance > >>> - merge notifier calls into SdMmcHcReset() and SdMmcHcInitHost (), th= is > >>> required changing the prototype to take a > SD_MMC_HC_PRIVATE_DATA* > >>> argument > >>> and so the prototypes no longer belong in SdMmcPciHci.h and have > >>> been moved > >>> to SdMmcPciHcDxe.h > >>> - use VOID* type for capability not UINT64* since we don't know its > >>> alignment > >>> > >>> Changes since v2: > >>> - use a singleton instance of the SD/MMC protocol rather than one per > >>> controller; this is needed to support 'reconnect -r', as pointed ou= t > >>> by Ray > >>> - use EDKII prefixes for all types defined by the protocol > >>> - replace 'hook' with 'notify', and tweak some other identifiers > >>> - add missing function comment headers for factored out functions > >>> > >>> Changes since RFC/v1: > >>> - add EFI_SD_MMC_PASS_THRU_PROTOCOL* member to override > methods > >>> - use UINT64* not VOID* to pass capability structure (which is always= 64 > bits > >>> in size) > >>> > >>> Ard Biesheuvel (2): > >>> MdeModulePkg: introduce SD/MMC override protocol > >>> MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be > overridden > >>> > >>> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 35 > ++++++- > >>> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 36 > ++++++++ > >>> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 2 + > >>> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 95 > >>> +++++++++++++++++-- > >>> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 35 ------- > >>> MdeModulePkg/Include/Protocol/SdMmcOverride.h | 97 > >>> ++++++++++++++++++++ > >>> MdeModulePkg/MdeModulePkg.dec | 3 + > >>> 7 files changed, 257 insertions(+), 46 deletions(-) create mode > >>> 100644 MdeModulePkg/Include/Protocol/SdMmcOverride.h > >>> > >>> -- > >>> 2.11.0 > >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist > s.01.org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7Ce1c1a5872a7 > 1476d17fc08d567c7280c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% > 7C636529027474388370&sdata=3DgkmLosBokCxUJsWSPlvmsUABakEYdbIZTOho > qFsbbpI%3D&reserved=3D0