From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"lersek@redhat.com" <lersek@redhat.com>
Subject: Re: [RFC] ShellPkg/Ping: fix loss of first packet
Date: Tue, 20 Feb 2018 06:18:53 +0000 [thread overview]
Message-ID: <DB5PR04MB0998CFCC9B6C97E9C07BF4028ECF0@DB5PR04MB0998.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515CA3C5E4EB@FMSMSX103.amr.corp.intel.com>
Hi Ray,
Please share your comments.
Thanks,
Meenakshi
> -----Original Message-----
> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> Sent: Friday, February 16, 2018 8:51 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
>
> Seems good to me. I will let Ray review also.
>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Meenakshi
> > Sent: Friday, February 16, 2018 12:45 AM
> > To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> > Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> > Importance: High
> >
> > From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >
> > Issue:
> > Reply for first ping packet was getting dropped.
> >
> > Cause:
> > Sometimes reply message comes even before trasmit
> > function returns, hence missing 1st reply
> >
> > Fix:
> > Prepare the TxList before calling Transmit function.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > ---
> > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > index bec9535..46ba701 100644
> > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > @@ -784,14 +784,17 @@ PingSendEchoRequest (
> > }
> >
> > ASSERT(Private->ProtocolPointers.Transmit != NULL);
> > +
> > + InsertTailList (&Private->TxList, &TxInfo->Link);
> > +
> > Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> > >Token);
> >
> > if (EFI_ERROR (Status)) {
> > + RemoveEntryList (&TxInfo->Link);
> > PingDestroyTxInfo (TxInfo, Private->IpChoice);
> > return Status;
> > }
> >
> > - InsertTailList (&Private->TxList, &TxInfo->Link);
> > Private->TxCount++;
> >
> > return EFI_SUCCESS;
> > --
> > 1.9.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> 4aQLVSNNti8%3D&reserved=0
next prev parent reply other threads:[~2018-02-20 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 8:45 [RFC] ShellPkg/Ping: fix loss of first packet Meenakshi
2018-02-16 15:20 ` Carsey, Jaben
2018-02-20 6:18 ` Meenakshi Aggarwal [this message]
2018-02-22 8:32 ` Ni, Ruiyu
2018-02-23 9:57 ` Meenakshi Aggarwal
2018-02-23 10:17 ` Laszlo Ersek
2018-02-23 10:26 ` Meenakshi Aggarwal
2018-02-23 12:01 ` Laszlo Ersek
2018-02-23 16:35 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR04MB0998CFCC9B6C97E9C07BF4028ECF0@DB5PR04MB0998.eurprd04.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox