From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0044.outbound.protection.outlook.com [104.47.2.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2822721E43B63 for ; Fri, 22 Sep 2017 03:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q4/rJXPGC6deRmC3qQ/OekxU2TFKleSGV+fEYz07AD4=; b=wFClaNvaHtk9NKZrldGaB7nHwnhZC7gFCbvQpahlVLe9f8HQazEmRIYW8IuqxgyvwtgXJlr8clqNMFPbTn6eZN7CqBQ0Npr/RnUB5j2Pd18F/vXVelAfq3f8XHZH7E9h0td3UyxvFhcw+FgUwMKza1cqTrWm+9W01oHCSKGwOao= Received: from DB5PR04MB0998.eurprd04.prod.outlook.com (10.161.199.12) by VI1PR0402MB3341.eurprd04.prod.outlook.com (52.134.8.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 22 Sep 2017 10:25:50 +0000 Received: from DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::411c:6de2:e600:73c0]) by DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::411c:6de2:e600:73c0%14]) with mapi id 15.20.0077.011; Fri, 22 Sep 2017 10:25:49 +0000 From: Meenakshi Aggarwal To: Udit Kumar , "edk2-devel@lists.01.org" CC: "feng.tian@intel.com" , "star.zeng@intel.com" Thread-Topic: SNP transmit print Thread-Index: AdMywNaMiFux7IlLQ/ugA/lDM1tItwADtwfAAC8KUpA= Date: Fri, 22 Sep 2017 10:25:49 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meenakshi.aggarwal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0402MB3341; 6:M4pP+zml6oBLeiE5V1rjNuBQzmWbb45t3ag25vkTy/kdJ62+hFhvZMUkFycqqoXYBjOHwtW5sSVXsJc/3vbVChXTdOueZ6jMBWw98FcTcH3XzuaKULBW9ylWQL1leQL/vOsFx5f3QU7KW2d37viFD07PKhmthSO5RJIN7ofpz4qwV0FZnEP/aDdEq5eiY3+s4VFFeYhoy4mJ/VCiFBu1ZADTTpCHUKyXZieOB8AXAbfIUFZHrkjpKirWnEE5qfHpIvfIUM43lC1d/ZpDx2Tv5AJ3oNyVEcejUnzLidpDCvWJYZOsx7mUUWhm2sq/42/8j8mCN/UFEr4rMeLIe+4dvg==; 5:oP3CPRMr6/Nq3wlnat+jaNYN8gzvJojOId7BfcI/NY1PaJvd+t2Zc7hPOLImP0GGlZ2M4aTXx+aGQYh9KMO3mzT1x1WlvCyZOYLtqFfNaKIwtWHxqgxxS3fz29HuCPFqYkm/2LhrXQiCCEbmfoLoZg==; 24:H6+yOycSVnR/iBEcXag9lDYe10o5YMPzt7FP+TVv9ZGf5JvKmo6EQe9yVCFVZhzlsDbquXjMvTA4lWX+chAdi1ADnLJTFLewmYjpX1BD3Z8=; 7:DmFbzI/rrEoqx08xmxXwy4eVNN1Wvb95CRm1qvkFMCGiq2IAsXWoGV8zHn9gaVR604swrKNxT28QWE2D/NwMdOyUq1EDUiHQLTJo018MJ4VJEGTehIu+rOsEfSWU7YlTN4hj0y8isC1DqKpP7wpWCi+aGmxFhOT5Sb5JPKKWq5VA/SHFCZsVM7Yex6FOFskqioGV+GFS2Z8/b5mvkqPqRiamF52TQJ4t5G+kWwOIO/Y= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(13464003)(189002)(377454003)(199003)(2501003)(102836003)(6116002)(53936002)(25786009)(6306002)(9686003)(5250100002)(7696004)(5660300001)(55016002)(99286003)(6436002)(2950100002)(478600001)(966005)(86362001)(2906002)(316002)(189998001)(53546010)(3280700002)(33656002)(229853002)(7116003)(66066001)(2900100001)(3846002)(110136005)(54906003)(6246003)(54356999)(101416001)(81166006)(81156014)(4326008)(8676002)(97736004)(7736002)(105586002)(6506006)(3660700001)(14454004)(106356001)(68736007)(76176999)(8936002)(305945005)(3480700004)(74316002)(50986999); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB3341; H:DB5PR04MB0998.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: ecf95ca6-4fc9-4e09-4689-08d501a44b7f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR0402MB3341; x-ms-traffictypediagnostic: VI1PR0402MB3341: x-exchange-antispam-report-test: UriScan:(185117386973197)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0402MB3341; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0402MB3341; x-forefront-prvs: 0438F90F17 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2017 10:25:49.4596 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3341 Subject: Re: SNP transmit print X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 10:22:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Udit, Yes, I think we should print this message is Status is EFI_DEVICE_ERROR bec= ause in case of EFI_NOT_READY, we are retrying: // // Transmit the packet through SNP. // Status =3D Snp->Transmit ( Snp, HeaderSize, Length, Packet, TxData->SourceAddress, TxData->DestinationAddress, &ProtocolType ); if (Status =3D=3D EFI_NOT_READY) { Status =3D MnpRecycleTxBuf (MnpDeviceData); if (EFI_ERROR (Status)) { Token->Status =3D EFI_DEVICE_ERROR; goto SIGNAL_TOKEN; } DEBUG ((EFI_D_ERROR, "Snp->Transmit retry\n")); Status =3D Snp->Transmit ( Snp, HeaderSize, Length, Packet, TxData->SourceAddress, TxData->DestinationAddress, &ProtocolType ); } (MdeModulePkg/Universal/Network/MnpDxe/MnpIo.c) Please suggest if we can remove this print in case of BUSY status. Thanks, Meenakshi > -----Original Message----- > From: Udit Kumar > Sent: Thursday, September 21, 2017 5:21 PM > To: Meenakshi Aggarwal ; edk2- > devel@lists.01.org > Subject: RE: SNP transmit print >=20 > I think these error prints should be check against Status >=20 > Regards > Udit >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Meenakshi Aggarwal > > Sent: Thursday, September 21, 2017 3:36 PM > > To: edk2-devel@lists.01.org > > Subject: [edk2] SNP transmit print > > > > Hi, > > > > > > While performing tftp using PCI interface, below message is coming > > continuously: > > > > Snp->undi.transmit() 8000h:4h > > > > Snp->undi.transmit() 8000h:4h > > [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D> ] 34812 Kb > > Snp->undi.transmit() 8000h:4h > > > > Snp->undi.transmit() 8000h:4h > > > > Snp->undi.transmit() 8000h:4h > > > > Snp->undi.transmit() 8000h:4h > > > > > > It is coming from file > "MdeModulePkg/Universal/Network/SnpDxe/Transmit.c" > > > > DEBUG ( > > (EFI_D_ERROR, > > "\nSnp->undi.transmit() %xh:%xh\n", > > Snp->Cdb.StatFlags, > > Snp->Cdb.StatCode) > > ); > > > > > > I want to know if it is really an error message because tftp and ping > > are working perfectly, but this error message is coming. > > > > > > Thanks, > > Meenakshi > > > > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel