From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.0.63; helo=eur02-am5-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00063.outbound.protection.outlook.com [40.107.0.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3BAA222637DC6 for ; Wed, 18 Apr 2018 21:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=J08krCccqkYfvkd3nnvUzWD9QmWax1GTkfN0k0FnU30=; b=fshGNV83FYq9gcystYYvCFb/yjEPMAdDJKT7BG5RYROwChFKalmM8xbiOfxM22GBlGXDiXwFNdo8L0DMV/eSbT1AcTkBdhCtEa4BUnXiECcRIjZx8zT0Fy9cueNFs4hxLU7FrBvSqPF0JtUmXwFQComvT5dLkBExUdkLfVcIv6A= Received: from DB5PR04MB0998.eurprd04.prod.outlook.com (10.161.199.12) by DB5PR04MB1656.eurprd04.prod.outlook.com (10.164.39.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Thu, 19 Apr 2018 04:59:39 +0000 Received: from DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::18ce:390:67ab:40af]) by DB5PR04MB0998.eurprd04.prod.outlook.com ([fe80::18ce:390:67ab:40af%15]) with mapi id 15.20.0696.011; Thu, 19 Apr 2018 04:59:39 +0000 From: Meenakshi Aggarwal To: Leif Lindholm CC: "ard.biesheuvel@linaro.org" , "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi Thread-Topic: [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals Thread-Index: AQHTpwOAW5vj2JYFPE+qGPisqMNuQ6QHAU0AgAAPfgCAACOkgIAAs95Q Date: Thu, 19 Apr 2018 04:59:38 +0000 Message-ID: References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-4-git-send-email-meenakshi.aggarwal@nxp.com> <20180418151228.xdg7v2jfv2m36l4v@bivouac.eciton.net> <20180418181529.5huwswxe6t7nrifi@bivouac.eciton.net> In-Reply-To: <20180418181529.5huwswxe6t7nrifi@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR04MB1656; 7:01WmJqhvyJd3qhDeABMea/WDZ9hnnYK23EMqmzornpeOzxFydQauH9kU15VW2RdDILB/JyDcVOId0HuIH5QxnERaQofJ1XcaDsHMbXb1f4GzFAUd8NI/b9gH2jFDU0cxbDxUoNpxOAoHUWmuKXbTpeC6495mpCglNJ6IMDk7pOZC/QnQLGQu+Q2LIo/PsIAjGQ9F4HWugAjpmiykoVleZFOOD4TKp8wVWjF+/7hVmOzrQtHjRkc8UlwLu7hZw0Lt x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB5PR04MB1656; x-ms-traffictypediagnostic: DB5PR04MB1656: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231232)(944501376)(52105095)(6055026)(6041310)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB5PR04MB1656; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB1656; x-forefront-prvs: 0647963F84 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(39380400002)(346002)(81166006)(8676002)(2900100001)(3846002)(6116002)(74316002)(305945005)(7736002)(5660300001)(33656002)(66066001)(8936002)(14454004)(86362001)(2906002)(102836004)(6436002)(11346002)(316002)(53936002)(229853002)(55016002)(44832011)(9686003)(54906003)(446003)(476003)(26005)(6916009)(186003)(99286004)(25786009)(53546011)(5250100002)(6506007)(76176011)(7696005)(478600001)(4326008)(55236004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1656; H:DB5PR04MB0998.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: Gno0gmV/4GP2L5triVmMtbo+zbpkKNgngNZFR4pRqkZaWSAM7/4NiUYemI0ZwFEKjuOl/eVWpcjb7VdhjGijSYQc76yMZiDERDQLVVXIkHDHmtyJ0pl8sE+BgNeB18G7a8AOADmGmHtOThiQoHFrxkV7mUatGwD0wE64VLDNQI2EjJuh+/uIfN6Z3bIWb8un spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 0e49fe95-bd36-40d0-42f1-08d5a5b25af4 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e49fe95-bd36-40d0-42f1-08d5a5b25af4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2018 04:59:38.9324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1656 Subject: Re: [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 04:59:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, April 18, 2018 11:45 PM > To: Meenakshi Aggarwal > Cc: ard.biesheuvel@linaro.org; edk2-devel@lists.01.org; Udit Kumar > ; Varun Sethi > Subject: Re: [PATCH edk2-platforms 03/39] SocLib : Add support for > initialization of peripherals >=20 > On Wed, Apr 18, 2018 at 04:38:22PM +0000, Meenakshi Aggarwal wrote: > > > > + > > > > +/* > > > > + * Returns the bit mask for a bit index from 0 to 31 > > > > + */ > > > > +#define BIT(_BitIndex) (0x1u << (_BitIndex)) > > > > > > I don't see these being used for anything other than setting up BIT1 > > > BIT2 BIT3 and so on. We already have those in Base.h. > > > > > In Base.h, we have BIT1, BIT2 defined, here the requirement is to > > get set bit on basis of bit number, bit is not known in advance. >=20 > Ah, I missed the uses in SerDes.c and saw only the ones in UsbHcd.h > (which could use the Base.h defines). >=20 > But does it really simplify anything in SerDes.c? >=20 > *SerDesPrtclMap |=3D BIT (LanePrtcl); >=20 > is no clearer to me than >=20 > *SerDesPrtclMap |=3D (1u << LanePrtcl); >=20 This can also be used. > Best Regards, >=20 > Leif