public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Sami Mujawar <Sami.Mujawar@arm.com>
To: Jeff Westfahl <jeff.westfahl@ni.com>, Evan Lloyd <Evan.Lloyd@arm.com>
Cc: Ruiyu Ni Leif Lindholm <ruiyu.ni@intel.comleif.lindholm>,
	"edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>,
	Jaben Carsey <jaben.carsey@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	"linaro.org@ml01.01.org" <linaro.org@ml01.01.org>,
	Dong Wei <Dong.Wei@arm.com>
Subject: Re: [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables
Date: Fri, 17 Mar 2017 10:12:13 +0000	[thread overview]
Message-ID: <DB5PR0801MB27106C6447F3E08110DE0D4B84390@DB5PR0801MB2710.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1703161005050.11156@jmw-lm181>

Hi Jeff,

Thank you for letting us know these issues. I will provide an update to fix this soon.

Regards,

Sami Mujawar

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff Westfahl
Sent: 16 March 2017 03:12
To: Evan Lloyd
Cc: Ruiyu Ni Leif Lindholm; edk2-devel@ml01.01.org; Jaben Carsey; Jiewen Yao; Michael D Kinney; linaro.org@ml01.01.org; Dong Wei
Subject: Re: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables

Hi Evan,

I really appreciate this work, I've missed this functionality in the EFI shell.

Just a few minor things that I noticed:

1. In AcpiView.c, you use '\t' in a few places. For some reason, on my Intel PC, these tabs are displayed as a reverse color '?'. I'm not sure where the fault lies here. It seems like tab characters should be pretty universally understood, but I also don't see any tab characters in other parts of the shell code that are printed to the console.

2. In MadtParser.c, the error message at line 270 needs a newline. (No, my Intel PC doesn't have a GIC :)

Regards,
Jeff

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


  reply	other threads:[~2017-03-17 10:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09 23:49 [edk2-staging][PATCH 0/2] Create new acpiview branch evan.lloyd
2017-03-09 23:49 ` [edk2-staging][PATCH 1/2] ShellPkg: acpiview branch on edk2-staging evan.lloyd
2017-03-09 23:49 ` [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables evan.lloyd
2017-03-16 15:11   ` Jeff Westfahl
2017-03-17 10:12     ` Sami Mujawar [this message]
2017-03-28 19:49       ` Jeff Westfahl
2017-03-29 18:57         ` Sami Mujawar
2017-03-14 21:30 ` [edk2-staging][PATCH 0/2] Create new acpiview branch Jeff Westfahl
2017-03-27 18:25 ` Evan Lloyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB5PR0801MB27106C6447F3E08110DE0D4B84390@DB5PR0801MB2710.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox