From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on0618.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe09::618]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C7FAD8042F for ; Fri, 17 Mar 2017 03:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vo8FyM+0gIjiw1U/Hcw+BZS3Zud5nwQnfETdr2GxKdY=; b=btKAF9X6Nv7n5QHHqxoW6ezIRa1N/e5FyIjAfd0Ty3beoCkKLxYWS63kTt5O4FAv3xQuYs+HbSO+0rdPx6OZSL5iGaaEfIO97R1Xaot8WNIFSK75jqmF9HmlwQOfyYjjdKboqTYlKh5SPbGKklIxYPzJ2Xva2m33dNb0fNww3CY= Received: from DB5PR0801MB2710.eurprd08.prod.outlook.com (10.166.170.155) by DB5PR0801MB1447.eurprd08.prod.outlook.com (10.167.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Fri, 17 Mar 2017 10:12:14 +0000 Received: from DB5PR0801MB2710.eurprd08.prod.outlook.com ([10.166.170.155]) by DB5PR0801MB2710.eurprd08.prod.outlook.com ([10.166.170.155]) with mapi id 15.01.0977.017; Fri, 17 Mar 2017 10:12:14 +0000 From: Sami Mujawar To: Jeff Westfahl , Evan Lloyd CC: Ruiyu Ni Leif Lindholm , "edk2-devel@ml01.01.org" , Jaben Carsey , Jiewen Yao , Michael D Kinney , "linaro.org@ml01.01.org" , Dong Wei Thread-Topic: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables Thread-Index: AQHSmS/hdtcGPvhif02QRDE4AAJZ56GXnNuAgAE5iZA= Date: Fri, 17 Mar 2017 10:12:13 +0000 Message-ID: References: <20170309234942.11956-1-evan.lloyd@arm.com> <20170309234942.11956-3-evan.lloyd@arm.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.96.140] x-microsoft-exchange-diagnostics: 1; DB5PR0801MB1447; 7:ovh945cj1rR96Irb9RY8RCFDNqoXMj77Ou1K/YcR5Yq7tKyk7WRmLQp146kyvab86F39Afn22RetGuTU4NH7jkUpWhWpB80/9rY91nmDr0zZY5SgrJ/m1G18XXFhH866Hr46omwx8ysfProSRLmefVYkGQe4rKTXtuOA3TnKap5IXf7cr9vCI+AZ000Co4yQt701svpTq7uTV/e6sAZeJUlZMySzYtpt+sxyP6yQrsJ6Sz4MD2SSIhupi/H2JCY6qeHtN/zOfZi/+0DdZznK4QpMp+CMSqq2eXFpDOKyg+xkzE8B9b8djWPjIFlHlHWphcoGf8URPMjkir5xrfN6ew== x-ms-office365-filtering-correlation-id: 17b9dc8a-5f73-4bdf-b8c4-08d46d1e1561 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:DB5PR0801MB1447; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123558025)(20161123560025)(20161123555025)(20161123564025)(6072148); SRVR:DB5PR0801MB1447; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0801MB1447; x-forefront-prvs: 0249EFCB0B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39410400002)(39850400002)(39450400003)(40434004)(13464003)(25786008)(345774005)(81166006)(33656002)(305945005)(7736002)(77096006)(8676002)(2950100002)(99286003)(53936002)(6636002)(9686003)(4326008)(76176999)(6246003)(50986999)(38730400002)(54356999)(7696004)(6436002)(8936002)(5660300001)(66066001)(189998001)(55016002)(3660700001)(53546008)(5890100001)(122556002)(3280700002)(102836003)(2900100001)(6306002)(86362001)(6116002)(3846002)(2906002)(6506006)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0801MB1447; H:DB5PR0801MB2710.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2017 10:12:13.9067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0801MB1447 Subject: Re: [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2017 10:12:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jeff, Thank you for letting us know these issues. I will provide an update to fix= this soon. Regards, Sami Mujawar -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff= Westfahl Sent: 16 March 2017 03:12 To: Evan Lloyd Cc: Ruiyu Ni Leif Lindholm; edk2-devel@ml01.01.org; Jaben Carsey; Jiewen Ya= o; Michael D Kinney; linaro.org@ml01.01.org; Dong Wei Subject: Re: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool t= o dump ACPI tables Hi Evan, I really appreciate this work, I've missed this functionality in the EFI sh= ell. Just a few minor things that I noticed: 1. In AcpiView.c, you use '\t' in a few places. For some reason, on my Inte= l PC, these tabs are displayed as a reverse color '?'. I'm not sure where t= he fault lies here. It seems like tab characters should be pretty universal= ly understood, but I also don't see any tab characters in other parts of th= e shell code that are printed to the console. 2. In MadtParser.c, the error message at line 270 needs a newline. (No, my = Intel PC doesn't have a GIC :) Regards, Jeff _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.