From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on062e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E092B2050AAFE for ; Wed, 29 Mar 2017 11:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iGKXTcZihRfSHstaABQ8bNRxR3nZhJVNJG+7NVUpi2E=; b=R/Fl51qOG/79rzkN1lN0ug1dIga+VZ/PKql3VYnhUyTi7F4vuL81y5ZLSdbaOWqtwnlrpYVQEvwD+e7eYO5s8iMC6T5pg6nOF+ujgcR+v3A0e4aqDsjJCvL7pier0W6d9DkRe8Jzxk6yljyYjpfRcQARO+5QL9C0foFnTAmDJsc= Received: from DB5PR0801MB2710.eurprd08.prod.outlook.com (10.166.170.155) by DB5PR0801MB1448.eurprd08.prod.outlook.com (10.167.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Wed, 29 Mar 2017 18:57:36 +0000 Received: from DB5PR0801MB2710.eurprd08.prod.outlook.com ([10.166.170.155]) by DB5PR0801MB2710.eurprd08.prod.outlook.com ([10.166.170.155]) with mapi id 15.01.0991.021; Wed, 29 Mar 2017 18:57:36 +0000 From: Sami Mujawar To: Jeff Westfahl CC: Evan Lloyd , Ruiyu Ni Leif Lindholm , "edk2-devel@ml01.01.org" , Jaben Carsey , Jiewen Yao , Michael D Kinney , "linaro.org@ml01.01.org" , Dong Wei Thread-Topic: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables Thread-Index: AQHSmS/hdtcGPvhif02QRDE4AAJZ56GXnNuAgAE5iZCAEfAkgIAA03tA Date: Wed, 29 Mar 2017 18:57:35 +0000 Message-ID: References: <20170309234942.11956-1-evan.lloyd@arm.com> <20170309234942.11956-3-evan.lloyd@arm.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.96.140] x-microsoft-exchange-diagnostics: 1; DB5PR0801MB1448; 7:wNU2x588m1ek+8mZLaI3UQDfDdZK63u7DGkRoubXDj+hGC4m2JgR7T81DS6uOnWJVv0tLaiipZzwEQajE4tRfd4Db0cQH9KjAq42USzjr/sEkJEsvPGhR+2kRVJDhONPblaTqkvoDjOVFhgDGxvfas5w997Gd8DZmh2ETjA499Oq18WGAHfPjH2/dhKUZhlaZ6angRtE4zgOHfrHsVAusewm4iYMOh2Ts7wTdIdaZIKvg8sCN19yYOBNupnkivMNuONQvktnB8XbbpbpMt9fK3Gs8Tj3WtrksVmBv67qOgwiCOKLmGzM2ABZ940iaG1XKc0dtyPVOpXXQqDeBpu1AQ== x-ms-office365-filtering-correlation-id: 9be6b6a1-1343-47bf-9806-08d476d576f4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:DB5PR0801MB1448; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266)(145744241990776); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406075)(20161123555025)(20161123564025)(20161123560025)(20161123558025)(20161123562025)(6072148); SRVR:DB5PR0801MB1448; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0801MB1448; x-forefront-prvs: 0261CCEEDF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39410400002)(39450400003)(39850400002)(39840400002)(39860400002)(13464003)(24454002)(54356999)(3660700001)(77096006)(76176999)(3280700002)(50986999)(6506006)(345774005)(3846002)(6116002)(102836003)(122556002)(33656002)(5660300001)(74316002)(93886004)(305945005)(7736002)(86362001)(5890100001)(6306002)(6246003)(66066001)(189998001)(2900100001)(38730400002)(2906002)(7696004)(9686003)(53936002)(6916009)(8936002)(2950100002)(99286003)(229853002)(25786009)(4326008)(53546009)(81166006)(8676002)(55016002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0801MB1448; H:DB5PR0801MB2710.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2017 18:57:35.7661 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0801MB1448 Subject: Re: [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 18:57:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jeff, Sadly, we do not have an environment setup to build tianocore-edk2 using Vi= sual Studio 2015. We build the edk2 from the windows command prompt using t= he linaro gcc toolchain for ARM/AARCH64. Is it possible to send the error log, please ? Evan has made a request for creation of a branch on the edk2-staging reposi= tory. We would be very happy for you to contribute changes once this is in = place. Regards, Sami Mujawar -----Original Message----- From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] Sent: 28 March 2017 08:50 To: Sami Mujawar Cc: Jeff Westfahl; Evan Lloyd; Ruiyu Ni Leif Lindholm; edk2-devel@ml01.01.o= rg; Jaben Carsey; Jiewen Yao; Michael D Kinney; linaro.org@ml01.01.org; Don= g Wei Subject: RE: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool t= o dump ACPI tables Hi Sami, Just another note, acpiview doesn't currently build on Windows, at least no= t with Visual Studio 2015. This isn't a problem for me as I don't usually b= uild the shell on Windows, I just happened to notice it. Regards, Jeff Westfahl On Fri, 17 Mar 2017, Sami Mujawar wrote: > Hi Jeff, > > Thank you for letting us know these issues. I will provide an update to f= ix this soon. > > Regards, > > Sami Mujawar > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jeff Westfahl > Sent: 16 March 2017 03:12 > To: Evan Lloyd > Cc: Ruiyu Ni Leif Lindholm; edk2-devel@ml01.01.org; Jaben Carsey; > Jiewen Yao; Michael D Kinney; linaro.org@ml01.01.org; Dong Wei > Subject: Re: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview > tool to dump ACPI tables > > Hi Evan, > > I really appreciate this work, I've missed this functionality in the EFI = shell. > > Just a few minor things that I noticed: > > 1. In AcpiView.c, you use '\t' in a few places. For some reason, on my In= tel PC, these tabs are displayed as a reverse color '?'. I'm not sure where= the fault lies here. It seems like tab characters should be pretty univers= ally understood, but I also don't see any tab characters in other parts of = the shell code that are printed to the console. > > 2. In MadtParser.c, the error message at line 270 needs a newline. > (No, my Intel PC doesn't have a GIC :) > > Regards, > Jeff > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.