From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.78; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=alexei.fedorov@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0078.outbound.protection.outlook.com [104.47.0.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3DDF22095B9EF for ; Tue, 17 Oct 2017 08:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5NKCMoHagkD93DBIoptaYB7Ykv4hLWF/a6HGnoS13nk=; b=f8EFyW+R+HbKryImgOOBwbgkxg3WUGY49IQvK8JrAJcs/u8JT5cWpP2N1gH6YJaE9vRPiEoYhWuf9MIgdm7ypQlm7IvTZ848RkCOm65u6PhQcZ08DYYtkK9NLU13aZOnSeX2lZmXCaTLf7xK99eF7UpRwtfokTT0u6UZyFr1h/M= Received: from DB5PR08MB1014.eurprd08.prod.outlook.com (10.166.14.11) by AM5PR0801MB1361.eurprd08.prod.outlook.com (10.167.217.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 17 Oct 2017 15:05:37 +0000 Received: from DB5PR08MB1014.eurprd08.prod.outlook.com ([fe80::4c98:c840:d411:4259]) by DB5PR08MB1014.eurprd08.prod.outlook.com ([fe80::4c98:c840:d411:4259%14]) with mapi id 15.20.0077.022; Tue, 17 Oct 2017 15:05:37 +0000 From: Alexei Fedorov To: Leif Lindholm , Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Sudeep Holla Thread-Topic: [PATCH edk2-platforms v2] Platform/ARM: use appropriate ReportStatusCodeLib resolution for RT drivers Thread-Index: AQHTR1BKczAHldTLE0yIWb9tq8t0b6LoI8cc Date: Tue, 17 Oct 2017 15:05:36 +0000 Message-ID: References: <20171017134205.3907-1-ard.biesheuvel@linaro.org>, <20171017140024.nnny4ik5ooquqfvv@bivouac.eciton.net> In-Reply-To: <20171017140024.nnny4ik5ooquqfvv@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM5PR0801MB1361; 6:JwUDSC6ElwqkMn9NIyOeo2Ct1YruN+lP6bKzkJf1o/0UDnTULcCwZzwTQbf+NF4ytRZdtUTu+ZUvP3e9bbhXwELjSTgFVdgOAJCRqeqhD1rwjKEIvID1aWGzFTsnMW2qEJPwL7HBKdIkspltueTcGNUIweNbkZeSsUOC0zVHj5pW8HhWG2sMjml7rgbNXdXSZLURM734tcbLBUazvblFc+3W1/CktUeylfrP09iCWSQVCr5sAQNvA+xRkwXFxlMyoHbtd7wIcDuSu6GM1CaOPqdBbgvO8SGkGY/oFqvVxQEtM5Qbn7BV/rJOUyRnn1VjxHCB4yhdOpi8AUlR3+R8KQ==; 5:neylx8/9hUaE60UGboG5n5MyjpfnctDLGsUbdXWJFmaWxjLYo6aKJq+5OlF0KwjLlgrDm3KbP+gzdTge2w6u1nKUIXB6lMho2zXHAY86U+XCB27mMN+zCENaC4fc17f02a1YS54NNCu1vJTZlRlRfw==; 24:PIs2ex9BKGjUDfYHJtvE/IXGluOr75Nlj2J7zHyb6EYkDm/WT+45/BzzKTi3ad8G/XbqNkFDkyWyHSo45m1eUic9JFed5/eCIOddtTvhoTg=; 7:mqVps8EdO/w1eJYPianwrXYwacGDhh3TV8dVVn3MnRXIed3NguvTDH5MmrMzvqsqtIDL+coxEZT9Ckf8xbt3QIoQZaxioWZDFJojzC53yoAS1vOM6PoJ7naEuSvkYnV+16UVUaoTHzsent4y1BY3+Km9AxgmCfx7DfN3R0enNp4p+cg04YLA7Kxb/kKGZbRfTcpaacuy25b8kgAVqoOwOeucktrVYdqnTbwCKEGB1M8= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: 258eb392-8658-4a3a-3878-08d5157085f5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:AM5PR0801MB1361; x-ms-traffictypediagnostic: AM5PR0801MB1361: x-exchange-antispam-report-test: UriScan:(158342451672863)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM5PR0801MB1361; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM5PR0801MB1361; x-forefront-prvs: 04631F8F77 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(40434004)(199003)(24454002)(102836003)(81156014)(101416001)(6116002)(7736002)(5660300001)(14454004)(229853002)(2900100001)(50986999)(8676002)(72206003)(478600001)(316002)(2906002)(76176999)(8936002)(2950100002)(54356999)(53546010)(81166006)(7696004)(25786009)(97736004)(33656002)(3660700001)(106356001)(55016002)(6246003)(3280700002)(5250100002)(99286003)(74316002)(3846002)(5890100001)(68736007)(54896002)(110136005)(53936002)(54906003)(6436002)(6506006)(189998001)(105586002)(9686003)(86362001)(66066001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB1361; H:DB5PR08MB1014.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2017 15:05:36.9972 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1361 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH edk2-platforms v2] Platform/ARM: use appropriate ReportStatusCodeLib resolution for RT drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 15:02:04 -0000 Content-Language: en-GB Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, system can be restarted properly with this patch. Alexei. ________________________________ From: Leif Lindholm Sent: 17 October 2017 15:00:24 To: Ard Biesheuvel; Alexei Fedorov Cc: edk2-devel@lists.01.org; Sudeep Holla Subject: Re: [PATCH edk2-platforms v2] Platform/ARM: use appropriate Report= StatusCodeLib resolution for RT drivers Thanks. Alexei, can you confirm that this addresses your concerns? / Leif On Tue, Oct 17, 2017 at 02:42:05PM +0100, Ard Biesheuvel wrote: > ResetSystemRuntimeDxe may be invoked by the OS at runtime, at which time > it will attempt to call into ReportStatusCodeLib. If we use the default > version for DXE drivers, this will access data structures that are no > longer there so switch to the special runtime version instead. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/= VExpressPkg/ArmVExpress.dsc.inc > index 8bcb84869c84..1605eedbdd8c 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -240,6 +240,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryA= llocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in= f > ArmPlatformSysConfigLib|ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpr= essSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib= /RuntimeDxeReportStatusCodeLib.inf > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > !endif > -- > 2.11.0 > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.