From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.2.67; helo=eur02-ve1-obe.outbound.protection.outlook.com; envelope-from=alexei.fedorov@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20067.outbound.protection.outlook.com [40.107.2.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5576A22361E67 for ; Thu, 8 Feb 2018 07:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vHgheVeTHLg8yTj2jTycJkcOA3o5VxU85n7ElYeoWw4=; b=KcU6zI8SW/ZWyZWinsRlBYCE49t60DkrtEUvSMtp2y30iMHp9LCXj2kuTl0xK9Mf193aJwbHMuTk/DuYxnlIuJQeszmXQ6s9shu8abhk40im/qIS38W/q1cUdOq7ir8fDZGeEWzYXK4BXot3SzBoc3UhTTYHLZNun1A7yCgCAhI= Received: from DB5PR08MB1014.eurprd08.prod.outlook.com (10.166.14.11) by DB5PR08MB0534.eurprd08.prod.outlook.com (10.161.245.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Thu, 8 Feb 2018 15:08:19 +0000 Received: from DB5PR08MB1014.eurprd08.prod.outlook.com ([fe80::c543:a54c:53b9:70da]) by DB5PR08MB1014.eurprd08.prod.outlook.com ([fe80::c543:a54c:53b9:70da%14]) with mapi id 15.20.0464.016; Thu, 8 Feb 2018 15:08:19 +0000 From: Alexei Fedorov To: Leif Lindholm , "edk2-devel@lists.01.org" CC: "ard.biesheuvel@linaro.org" , Evan Lloyd , Sami Mujawar , Girish Pathak , Mitch Ishihara , "Matteo Carlini" Thread-Topic: [edk2] [PATCH edk2-platforms 1/3] Platform/ARM: drop unused EmbeddedPkg Pcds Thread-Index: AQHTn22zJBk5LXSmf0y+J2DKFPS9UqOam3wh Date: Thu, 8 Feb 2018 15:08:19 +0000 Message-ID: References: <20180206171225.10676-1-leif.lindholm@linaro.org> In-Reply-To: <20180206171225.10676-1-leif.lindholm@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR08MB0534; 7:utgpEd8nMEnJqZnjljbMCwl/7hNdxNqDpyKqTrPPxWeh4y4CBd56zeRqtbioOBeZ9zdzT7YSmqDoZZ2/pbl/QPhSxf+UF2Yd60lVA48KvQW2T2teueqc9ObJADDXNSHPKo4aNU1skKo+htj6IaSfNx5RYiLhYlOyCyEO/NuxF9xdS9t+x3p+WJth9bvwL9XS+R7ysZApUWlg+Q/UldvUiFlIAC8Zu7TNA3IxmDe4DdoJ8sxtzkeBmdJ1oTn6XFt3 x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 890f582e-f103-4e66-e2c7-08d56f05c9af x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:DB5PR08MB0534; x-ms-traffictypediagnostic: DB5PR08MB0534: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(2400082)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DB5PR08MB0534; BCL:0; PCL:0; RULEID:; SRVR:DB5PR08MB0534; x-forefront-prvs: 0577AD41D6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(366004)(346002)(39380400002)(39860400002)(40434004)(189003)(199004)(5250100002)(6506007)(59450400001)(8676002)(102836004)(2501003)(81166006)(81156014)(33656002)(86362001)(5890100001)(345774005)(4326008)(478600001)(26005)(97736004)(186003)(606006)(7696005)(2950100002)(25786009)(99286004)(53546011)(66066001)(76176011)(8936002)(19627405001)(236005)(3660700001)(106356001)(2906002)(54896002)(9686003)(316002)(6306002)(2900100001)(966005)(5660300001)(54906003)(7736002)(110136005)(74316002)(6116002)(229853002)(72206003)(55016002)(68736007)(3846002)(105586002)(3280700002)(14454004)(53936002)(6606003)(6246003)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR08MB0534; H:DB5PR08MB1014.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: yVUrFGmpU+HOZChnxOif5iNCB1yFT7tTSTcUXZLTMTNJMPHze256vtmAracuABrCXDRLS6JdCV5ExH942XwGFQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 890f582e-f103-4e66-e2c7-08d56f05c9af X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2018 15:08:19.0653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0534 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: [PATCH edk2-platforms 1/3] Platform/ARM: drop unused EmbeddedPkg Pcds X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 15:02:40 -0000 Content-Language: en-GB Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable This patch causes Juno and other ARM platforms to raise an assert during MM= U initialisation in ArmConfigureMmu() (edk2\ArmPkg\Library\ArmMmuLib\AArch64\ArmMmuLibCore.c): ASSERT (TranslationTableAttribute =3D=3D ARM_MEMORY_REGION_ATTRIBUTE_WRIT= E_BACK || TranslationTableAttribute =3D=3D ARM_MEMORY_REGION_ATTRIBUTE_NONS= ECURE_WRITE_BACK); see debug output: UEFI firmware (version built at 12:01:21 on Feb 8 2018) add-symbol-file n:\edk2\Build\ArmJuno\DEBUG_GCC5\AARCH64\ArmPlatformPkg\Pre= Pi\PeiUniCore\DEBUG\ArmPlatformPrePiUniCore.dll 0xE0000800 ASSERT [ArmPlatformPrePiUniCore] n:\edk2\ArmPkg\Library\ArmMmuLib\AArch64\A= rmMmuLibCore.c(744): TranslationTableAttribute =3D=3D ARM_MEMORY_REGION_ATT= RIBUTE_WRITE_BACK || TranslationTableAttribute =3D=3D ARM_MEMORY_REGION_ATT= RIBUTE_NONSECURE_WRITE_BACK because removal of - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE from ArmVExpress.dsc.inc now makes ArmPlatformGetVirtualMemoryMap () functi= on in \edk2-platforms\Platform\ARM\JunoPkg\Library\ArmJunoLib\ArmJunoMem.c use default FALSE value defined in EmbeddedPkg.dec: [PcdsFeatureFlag.common] gEmbeddedTokenSpaceGuid.PcdCacheEnable|FALSE|BOOLEAN|0x00000042 & set CacheAttributes to DDR_ATTRIBUTES_UNCACHED: if (FeaturePcdGet(PcdCacheEnable) =3D=3D TRUE) { CacheAttributes =3D DDR_ATTRIBUTES_CACHED; } else { CacheAttributes =3D DDR_ATTRIBUTES_UNCACHED; } Thank you for your cooperation. Alexei. ________________________________ From: edk2-devel on behalf of Leif Lindho= lm Sent: 06 February 2018 17:12 To: edk2-devel@lists.01.org Cc: ard.biesheuvel@linaro.org Subject: [edk2] [PATCH edk2-platforms 1/3] Platform/ARM: drop unused Embedd= edPkg Pcds A set of mostly Ebl-related Pcds are about to be deleted from edk2. Delete references to them here to keep platforms building. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VE= xpressPkg/ArmVExpress.dsc.inc index 717f7332c9..b026ce3a42 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc @@ -257,20 +257,6 @@ [PcdsFeatureFlag.common] gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE - # - # Control what commands are supported from the UI - # Turn these on and off to add features or save size - # - gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE - gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE - gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE - gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE - gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE - gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE - gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE - - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE - # Use the Vector Table location in CpuDxe. We will not copy the Vector T= able at PcdCpuVectorBaseAddress gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE @@ -333,10 +319,6 @@ [PcdsFixedAtBuild.common] gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 - gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|"" - gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07 - gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000 - # # Optional feature to help prevent EFI memory map fragments # Turned on and off via: PcdPrePiProduceMemoryTypeInformationHob -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.