From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from BLU004-OMC2S35.hotmail.com (blu004-omc2s35.hotmail.com [65.55.111.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D9E7A802F6 for ; Sat, 11 Mar 2017 14:05:28 -0800 (PST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com ([65.55.111.72]) by BLU004-OMC2S35.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Sat, 11 Mar 2017 14:05:27 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=I7kmyHRT0dmaXkorGGnbmmW+rCrEnhGEQoLsa+18MoM=; b=SBEN5gVHdehLkIVr1ulxDkI4jVQrcimj+PD95b0KFWzoVrqmrLFcRud4zQ4bd2xwRim9BOaoI3HliP0nSQJ+/8/tSZL9CcUl2qw5u1vXRmvkd4JZsYhYdh6QqyR0QzlBGql5GAf/hme52D9jXBE4q2fKYK83he8pW8szlrULCyDnziUDkfY+t0RXXsxKnshp4XCzngbk8u9dfDOXdACh58hStL0K5XhzN8/9R4mAriegmeH+yr0W2aiMfrCJk8XWnc5flIuh1Ca0zm+mZT5nUph6kdsW8eR2aLGnL+W/J5Zrf9zH5XWxs4apxsrNQPCUJLSd9fAt2a092arredR3ZQ== Received: from DB5EUR03FT021.eop-EUR03.prod.protection.outlook.com (10.152.20.57) by DB5EUR03HT047.eop-EUR03.prod.protection.outlook.com (10.152.21.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.7; Sat, 11 Mar 2017 22:05:26 +0000 Received: from DB6PR0601MB2584.eurprd06.prod.outlook.com (10.152.20.57) by DB5EUR03FT021.mail.protection.outlook.com (10.152.20.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.10 via Frontend Transport; Sat, 11 Mar 2017 22:05:26 +0000 Received: from DB6PR0601MB2584.eurprd06.prod.outlook.com ([10.168.81.141]) by DB6PR0601MB2584.eurprd06.prod.outlook.com ([10.168.81.141]) with mapi id 15.01.0947.020; Sat, 11 Mar 2017 22:05:26 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains. Thread-Index: AQHSmrOWRSp8ZINmOkmndIXypyPKNA== Date: Sat, 11 Mar 2017 22:05:26 +0000 Message-ID: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:D06BBF43C2F4262F18805F2FA530F10C638AE0C6681ABEB262DACEE67ECB02D4; UpperCasedChecksum:71D5E7402439A4ECD941EB496EB9AA85FF8CE21834DE4B1570F369E5FD183FD2; SizeAsReceived:7651; Count:35 x-ms-exchange-messagesentrepresentingtype: 1 x-incomingheadercount: 35 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1; DB5EUR03HT047; 5:oH9K9hQO1uHIy/IhMhtIQQxyzPMUbwaz+2OitkEY8zReA4nYieZXNKf8LQkPoaeExl8G196JKX77uDb5X0HUZ8Y34VBCKLfzkofl36Boq3kIG8ZFFuYaut6q3Zt8YcnkOsS9V2tneO+X1s12HAS9nQ==; 24:WSZ6TbpZUeFhATNwfd7h0vft7BIYgoasDJWuWHP11a6skG6TvJmy6tS22htqdHen/gnC31AgquZLMqut6pqR/5vl4ve0p/UBYt8o87axTJ4=; 7:8BNGl1/bDnUoYUf8Ko9rqlq1g36bkES144w83eBHtzs7X6Yjf3i9nG09g9iuZbQxO3tcRMdZYOmyyq8G7dVExEulwoUopdlz6e7Hrbznuj3Fjhj8emoqm3LUmxoNfMxJ7Lo6k8uxFSuFAJ7hQ59BKq1UbtZo1QFdXCLTzCwU4PQ8y4MNx8g7PQfdLFCDrhIApZCy8ptYSviom0mWhBCD2C+dckdF3Qywjon76/Pv3xC7NwlhmFZf846zbboPMe4vAJaWobtnRdNO936ErP/bLsZRmTgs4S/FegKwesBPdEG0JLPY4Xf3km7Q05s0yyk6 x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(10019020)(98900016); DIR:OUT; SFP:1102; SCL:1; SRVR:DB5EUR03HT047; H:DB6PR0601MB2584.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 4e661f7c-5d43-436f-f3ae-08d468cab867 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702061074)(5061506573)(5061507331)(1603103135)(1603101448)(1601125254)(1701031045); SRVR:DB5EUR03HT047; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015087)(444000031); SRVR:DB5EUR03HT047; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR03HT047; x-forefront-prvs: 0243E5FD68 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2017 22:05:26.3054 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR03HT047 X-OriginalArrivalTime: 11 Mar 2017 22:05:28.0074 (UTC) FILETIME=[979E8EA0:01D29AB3] Subject: [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 22:05:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable modsi3.S references the symbol '__divsi3' by '___divsi3' which assumes the prefix is always required and supported. Use ASM_PFX() instead to support all compilers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S b/ArmPkg/Lib= rary/CompilerIntrinsicsLib/Arm/modsi3.S index 29e2df92b02f..d5624b90f9d5 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S +++ b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S @@ -19,7 +19,7 @@ ASM_FUNC(__modsi3) add r7, sp, #8 mov r5, r0 mov r4, r1 - bl ___divsi3 + bl ASM_PFX(__divsi3) mul r0, r4, r0 rsb r0, r0, r5 ldmfd sp!, {r4, r5, r7, pc} --=20 2.12.0.windows.1