From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.56; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=alexei.fedorov@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0056.outbound.protection.outlook.com [104.47.1.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA2782063E318 for ; Thu, 3 May 2018 06:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TTVyyA1ZDJ4hPqnvtFiuEpfeFWaindhoymXvQV8B6r4=; b=dnAF2OXAzzc7ZqCQdGJUZa8UjuoPlXmNbAQANOw/RGbrYCHZ/1/iAqvPE2JsoqAGRieg8ymq+VkoNYmmElSLtu+gYXCMlYLREOCziX85f4yUX+2X5ymv4In4/+29iC8xa4HpTeWZUhwqeoC/I/7mIquDeLb0SPPaUKuwEbcm1LI= Received: from DB6PR0801MB1766.eurprd08.prod.outlook.com (10.169.227.13) by DB6PR0801MB1926.eurprd08.prod.outlook.com (10.168.85.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.18; Thu, 3 May 2018 13:21:56 +0000 Received: from DB6PR0801MB1766.eurprd08.prod.outlook.com ([fe80::15b1:d95c:d513:6f59]) by DB6PR0801MB1766.eurprd08.prod.outlook.com ([fe80::15b1:d95c:d513:6f59%18]) with mapi id 15.20.0715.024; Thu, 3 May 2018 13:21:56 +0000 From: Alexei Fedorov To: Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , "Thomas Abraham" , Leif Lindholm , Matteo Carlini , Stephanie Hughes-Fitt , nd , Evan Lloyd Thread-Topic: [PATCH edk2-platforms v1] Platform/ARM: Correct GIC naming Thread-Index: AQHT4tPjBlt+ePIoTEOPx89odBv3A6Qd+/wj Date: Thu, 3 May 2018 13:21:55 +0000 Message-ID: References: <1525278402-43588-1-git-send-email-alexei.fedorov@arm.com>, In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0801MB1926; 7:7x/zXad6vsgzrN3l7p6V3mnddTOzoX4wF/3DQEsmCeNOrBsx6bSj4VEESWT72ExNQFwP8mQqeSBgGw2RA22Uj4rOwTPiDH/YNuGgiic7ssaYcj3ClZ1K4DMOVL4D5tmdTampdbDigic6AzKhzkm9rmKtsiOfwsvo96BmeoYlfOzocHKGDiaOpD8PEPk5N/pVuNp/xySwkSVXnFDTSs2qN/PkWCKCZK4QO0cwhS2mbbxlQ6U7xqf1iEYIK4CFeyrK x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0801MB1926; x-ms-traffictypediagnostic: DB6PR0801MB1926: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DB6PR0801MB1926; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0801MB1926; x-forefront-prvs: 066153096A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(39860400002)(39380400002)(396003)(346002)(199004)(189003)(606006)(72206003)(59450400001)(478600001)(5660300001)(26005)(966005)(53936002)(81166006)(8676002)(81156014)(14454004)(66066001)(2900100001)(11346002)(9686003)(446003)(486006)(86362001)(575784001)(316002)(3280700002)(4326008)(5250100002)(3660700001)(6916009)(74316002)(6506007)(53546011)(6606003)(54906003)(476003)(102836004)(2906002)(105586002)(6116002)(3846002)(186003)(19627405001)(229853002)(106356001)(97736004)(68736007)(8936002)(33656002)(7696005)(236005)(55016002)(54896002)(6306002)(7736002)(6436002)(6246003)(25786009)(99286004)(76176011)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0801MB1926; H:DB6PR0801MB1766.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eFv3icF7F8Ve4/+4P6xFUR0AsRfyR52oWUB42YVShFidT7qlLxG3euTjnQWKdBAhz+lDYZSV0QDk5WugKpQekyFGqdw7IFlvCuZi6LZ+UiGYwVqgHTdT5EV7tjb/Iprnym/5KjjIuPf4yugyiF64FvriTGpv2pZ/79/kk/Xw0ewiFvlYDs9V9GluAWBrlr9z spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 49204bf8-cb49-4424-baef-08d5b0f8d7c4 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49204bf8-cb49-4424-baef-08d5b0f8d7c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2018 13:21:55.9759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1926 X-Content-Filtered-By: Mailman/MimeDel 2.1.26 Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Correct GIC naming X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 13:22:00 -0000 Content-Language: en-GB Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Ard, >Care to update the second instance in this file as well? The second instance in VExpressPkg/ArmVExpress-CTA15-A7.dsc reads: "ARM General Interrupt Driver in Secure and Non-secure" Do you want it to be changed to "ARM Generic Interrupt Controller Driver in= Secure and Non-secure" or leave it as it is? >And while you're at it, care to update the other platforms too? Sure, I'll send a new patch after VExpressPkg/ArmVExpress-CTA15-A7.dsc is s= orted out (see above) Regards. Alexei. ________________________________ From: Ard Biesheuvel Sent: 03 May 2018 12:42 To: Alexei Fedorov Cc: edk2-devel@lists.01.org; Arvind Chauhan; Daniil Egranov; Thomas Abraham= ; Leif Lindholm; Matteo Carlini; Stephanie Hughes-Fitt; nd; Evan Lloyd Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Correct GIC naming On 2 May 2018 at 18:26, Alexei Fedorov wrote: > From: Alexei Fedorov > > ARM Generic Interrupt Controller is incorrectly named as > "ARM General Interrupt Controller" in ArmJuno.dsc, > ArmVExpress-CTA15-A7.dsc and ArmVExpress-FVP-AArch64.dsc. > > This patch corrects the comment by changing "General" to "Generic". > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > Reviewed-by: Evan Lloyd > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platforms/tree/261_correct_gic_nami= ng_v1 > > Notes: > v1: > - Change ARM "General" Interrupt Controller to "Generic" [Alexei] > Hello Alexei, > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 4 ++-- Care to update the second instance in this file as well? And while you're at it, care to update the other platforms too? $ git grep -i 'arm general interrupt' Platform/AMD/OverdriveBoard/OverdriveBoard.dsc: # ARM General Interrupt Controller Platform/ARM/JunoPkg/ArmJuno.dsc: # ARM General Interrupt Controller Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc: # ARM General Interrupt Driver in Secure and Non-secure Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc: # ARM General Interrupt Controller Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc: # ARM General Interrupt Controller Platform/Comcast/RDKQemu/RDKQemu.dsc: # ARM General Interrupt Controller Platform/Hisilicon/HiKey/HiKey.dsc: # ARM General Interrupt Controller Platform/Hisilicon/HiKey960/HiKey960.dsc: # ARM General Interrupt Controll= er Platform/LeMaker/CelloBoard/CelloBoard.dsc: # ARM General Interrupt Contro= ller Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc: # ARM General Interrupt Controller Thanks, Ard. > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJ= uno.dsc > index 5ec563cefbcd9d97614dc9944bfaeb3822c4634d..8d6dd0207db5f16d7fcc0c5fd= 59fea38498f3034 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -150,7 +150,7 @@ [PcdsFixedAtBuild.common] > gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout|40000 > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2C010000 > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x2C02F000 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform= /ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index ef737670126db980abcc0e0ac9b84321bfa97584..6405d955f15a87c8d7b379f8c= 05b43f3e0830c54 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2012-2017, ARM Limited. All rights reserved. > +# Copyright (c) 2012-2018, ARM Limited. All rights reserved. > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > @@ -156,7 +156,7 @@ [PcdsFixedAtBuild.common] > > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2C001000 > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x2C002000 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platf= orm/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index 600bffb66703305f4a6baec930cd044998744c24..ca19fd65265a531e8c0869460= aa9b6358b70bf91 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -147,7 +147,7 @@ [PcdsFixedAtBuild.common] > gArmPlatformTokenSpaceGuid.PcdPL180MciBaseAddress|0x1C050000 > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2f000000 > gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x2f100000 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >